On 07/09/14 22:22, Steven Chamberlain wrote:
> I wonder if there's some significance that it was templated for
> <_GError> whereas I think that should be a typedef to GError (without
> underscore)?

My test build finished - the change I tried didn't help - but looking
for _GError (with underscore) it seemed it was specific to GStreamer:

> $ grep _GError . -R
> Binary file 
> ./WebKitBuild/Release/Source/WebCore/obj/release/MediaPlayerPrivateGStreamer.o
>  matches
> Binary file 
> ./WebKitBuild/Release/Source/WebCore/obj/release/GStreamerUtilities.o matches
> Binary file 
> ./WebKitBuild/Release/Source/WebCore/obj/release/WebKitWebSourceGStreamer.o 
> matches

Then I found this related upstream commit mentioned in the 2.3.3 changelog:

> 24    2013-12-17  Alex Christensen  <achristen...@webkit.org>
> 25    
> 26            [Win] Fixed linker error with GStreamer.
> 27            https://bugs.webkit.org/show_bug.cgi?id=124861
> 28    
> 29            Reviewed by Martin Robinson.
> 30    
> 31            * wtf/gobject/GOwnPtr.cpp:
> 32            (WTF::GError):
> 33            * wtf/gobject/GOwnPtr.h:
> 34            Added WTF_EXPORT_PRIVATE to freeOwnedGPtr<GError> declaration 
> and definition.

I'm trying another test build now with this change applied:
http://trac.webkit.org/changeset/160716

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk

Reply via email to