Re: KDE 4 class for cdbs

[Armin Berres]

On Thu, 14 Feb 08 09:31, Peter Eisentraut wrote:
> Am Dienstag, 12. Februar 2008 schrieb Armin Berres:
> > On Tue, 12 Feb 08 12:28, Peter Eisentraut wrote:
> > > | DEB_CMAKE_EXTRA_FLAGS += \
> > > | -DCMAKE_BUILD_TYPE=Debian \
> > >
> > > I don't see "Debian" documented as a valid value for this variable.  What
> > > is this supposed to do?  Should this be in the cmake class?
> >
> > It is defined in this patch:
> >  >atches/08_add_debian_build_type.diff> Does every KDE 4 app use
> > FindKDE4Internal.cmake? If yes it should be in the class, otherwise it
> > shouldn't.
> 
> It seems to me that a much less roundabout way to accomplish that would be to 
> just add -DNDEBUG to CPPFLAGS in the debian/rules file.  I'll see whether 
> that is a viable alternative.

The Debian build type does one more thing apart from -DNDEBUG: It
removes some compiler flags. Using RELWITHDEBINFO we would always end up
with "-O2 -g" + the flags specified via command line. This means when
you build with noopt, you'll still build with -02.

/Armin

-- 
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-talk

Re: KDE 4 class for cdbs

[Peter Eisentraut]

Am Dienstag, 12. Februar 2008 schrieb Armin Berres:
> On Tue, 12 Feb 08 12:28, Peter Eisentraut wrote:
> > | DEB_CMAKE_EXTRA_FLAGS += \
> > | -DCMAKE_BUILD_TYPE=Debian \
> >
> > I don't see "Debian" documented as a valid value for this variable.  What
> > is this supposed to do?  Should this be in the cmake class?
>
> It is defined in this patch:
> atches/08_add_debian_build_type.diff> Does every KDE 4 app use
> FindKDE4Internal.cmake? If yes it should be in the class, otherwise it
> shouldn't.

It seems to me that a much less roundabout way to accomplish that would be to 
just add -DNDEBUG to CPPFLAGS in the debian/rules file.  I'll see whether 
that is a viable alternative.

-- 
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-talk

Re: KDE 4 class for cdbs

[Matthew Rosewarne]

On Tuesday 12 February 2008, Peter Eisentraut wrote:
> | ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
> | cdbs_treat_me_gently_arches := arm m68k alpha ppc64 armel armeb
> | ifeq (,$(filter $(DEB_HOST_ARCH_CPU),$(cdbs_treat_me_gently_arches)))
> | KDE4-ENABLE-FINAL = $(if
> | $(DEB_KDE_ENABLE_FINAL),-DKDE4_ENABLE_FINAL=true,) else
> | KDE4-ENABLE-FINAL =
> | endif
> | endif
>
> Ah yes, well, bug #379981 ...
>
> I could be OK with this handling if we had a less ad-hoc way of defining
> the "slow" architectures.  Who would have guessed that alpha and ppc64 are
> slow? How is that decided?  Should this be in a configuration file perhaps?
>  Any better ideas?

Perhaps a more general solution could satisfy this and the suggestion outlined 
in the "Proposalto introduce compiler options passed from dpkg-buildpackage" 
thread in d-d.

Perhaps a /usr/share/cdbs/1/rules/arch.mk with architecture-specific 
variables?


signature.asc
Description: This is a digitally signed message part.
-- 
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-talk

Re: KDE 4 class for cdbs

[Armin Berres]

On Tue, 12 Feb 08 12:28, Peter Eisentraut wrote:
> | DEB_CMAKE_EXTRA_FLAGS += \
> | -DCMAKE_BUILD_TYPE=Debian \
> 
> I don't see "Debian" documented as a valid value for this variable.  What is
> this supposed to do?  Should this be in the cmake class?

It is defined in this patch:

Does every KDE 4 app use FindKDE4Internal.cmake? If yes it should be in
the class, otherwise it shouldn't.

> | -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-undefined 
> -Wl,--as-needed" \
> | -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--no-undefined 
> -Wl,--as-needed" \
> | -DCMAKE_EXE_LINKER_FLAGS="-Wl,--no-undefined 
> -Wl,--as-needed"
> 
> These linker options are of course useful, but are we sure enough that they
> work with all KDE-related software packages?

No, there are definitely cases where the flags don't work. But these
packages should be fixed ;) 

> | binary-install/$(DEB_SOURCE_PACKAGE)-doc-html::
> 
> This also belongs in the team file.

I hope we can kill this completely. I didn't hear anyone speaking in
favour of the html documentation.

Greetings,
Armin

-- 
http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-talk