[Pkg-mozext-maintainers] Bug#816053: xul-ext-adblock-plus: Missing line ending in get-orig-source

[David Prévot]

Control: tags -1 pending

Hi Mathias,

Thanks for your interest and your contribution!

> Package: xul-ext-adblock-plus
> Version: 2.7.1+dfsg-1

> when adding adblockpluscore source in rules, a line ending was forgotten

I obviously didn’t test it. Anyway, this packaging includes a bit more of
manual processing (e.g., the actual version of adblockpluscore was not the
tip of its master branch, but the version pointed in ./dependencies, i.e.,
git:2ef1723
,
or making the source DFSG free, or doing subtree merges on upgrade and
worse when adding a new component…). Maybe the latest uscan and version=4
watch file will help automatizing this process, and I really should
document the (rest of the) process in debian/README.source…

> BTW: The package uses dfsg, but I couldn't find any explanation what has
> been cleaned out? Thanks for a short expalantion.

It’s in debian/copyright (just some fonts stripped away):

$ grep Files-Excluded: -A5 debian/copyright
Files-Excluded: adblockplusui/skin/fonts/CreteRound-Italic.otf
adblockplusui/skin/fonts/CreteRound-Regular.otf
adblockplusui/skin/fonts/SourceSansPro-Light.woff
adblockplusui/skin/fonts/SourceSansPro-Regular.woff
adblockplusui/skin/fonts/SourceSansPro-Semibold.woff

(Looks like gitlab ship half of them under OFL-1.1. Not sure it would be
way better with the proper fonts: the screens are not showed every day
anyway).

Regards

David

___
Pkg-mozext-maintainers mailing list
Pkg-mozext-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mozext-maintainers

[Pkg-mozext-maintainers] Bug#816053: xul-ext-adblock-plus: Missing line ending in get-orig-source

[Mathias Behrle]

Package: xul-ext-adblock-plus
Version: 2.7.1+dfsg-1
Severity: normal
Tags: patch

Dear Maintainer,

when adding adblockpluscore source in rules, a line ending was forgotten
leading to a missing version string in the downloaded tarball.

BTW: The package uses dfsg, but I couldn't find any explanation what has
been cleaned out? Thanks for a short expalantion.

Best wishes,
Mathias


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (400, 'unstable'), (300, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages xul-ext-adblock-plus depends on:
ii  icedove38.6.0-1
ii  iceweasel  44.0.2-1

xul-ext-adblock-plus recommends no packages.

xul-ext-adblock-plus suggests no packages.
diff --git a/debian/rules b/debian/rules
index 8eb2366..6ba9365 100755
--- a/debian/rules
+++ b/debian/rules
@@ -21,6 +21,6 @@ get-orig-source:
 		wget -O ../adblock-plus_$$VERSION.orig-jshydra.tar.gz \
 		https://github.com/adblockplus/jshydra/archive/master.tar.gz ; \
 		wget -O ../adblock-plus_$$VERSION.orig-adblockplusui.tar.gz \
-		https://github.com/adblockplus/adblockplusui/archive/master.tar.gz
+		https://github.com/adblockplus/adblockplusui/archive/master.tar.gz ; \
 		wget -O ../adblock-plus_$$VERSION.orig-adblockpluscore.tar.gz \
 		https://github.com/adblockplus/adblockpluscore/archive/master.tar.gz
___
Pkg-mozext-maintainers mailing list
Pkg-mozext-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mozext-maintainers