Re: sonic-pi_2.10.0~repack-2 ready

[Hanno Zulla]

Am 17.05.2016 um 20:24 schrieb James Cowgill:
> This lintian override is incorrect. Having an executable script without
> a #! is useless. Why not fix the permissions instead?

Thanks, I have sent a fix upstream with
https://github.com/samaaron/sonic-pi/pull/1239 and will fix it in the
packaging, too.

Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

sonic-pi_2.10.0~repack-2 ready

[Hanno Zulla]

Dear Multimedia Mantainers,

for a (minor) bugfix, please review the updated sonic-pi package and
upload if you agree.

Thanks,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider is marked for autoremoval from testing

[Hanno Zulla]

Hi,

> Felipe is correct - 3.7.0 is on track, and looking good IMHO.

That's great.

We probably should keep in mind that after the release of supercollider
3.7.0, the supercollider-sc3-plugins source package needs a minor
version bump too, to get its binaries compiled against the new
supercollider-dev package.

I will try to do so once it's time.

Kind regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider is marked for autoremoval from testing

[Hanno Zulla]

Hi,

Am 02.05.2016 um 06:39 schrieb Debian testing autoremoval watch:
> supercollider 1:3.6.6~repack-2-2 is marked for autoremoval from testing on 
> 2016-06-07
> 
> It is affected by these RC bugs:
> 822467: supercollider: FTBFS: error: 'random_device' is not a member of 'std'

As Sonic Pi depends on SuperCollider (thanks, great piece of software!),
I wanted to ask if assistance with fixing this is needed.

Is the packaging of supercollider 3.7.0 on track or should 3.6.6 be
fixed, first?

Kind regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider 3.7.0 in alioth to try

[Hanno Zulla]

Hi Dan,

> There's a new release of SuperCollider out (3.7) and I've imported and
> updated the packaging at pkg-multimedia/supercollider.git . It builds
> and works for me (on x64), and I'd like to ask others to have a look
> at it and consider testing/uploading it.

I'm really looking forward to the new SC release.

I tried building it on Debian Sid and on Ubuntu 15.10, both replied with

> -ljack -lboost_thread -lboost_system -lfftw3f -lrt
> /usr/bin/ld: ../../external_libraries/libtlsf.a(tlsf.c.o): relocation
> R_X86_64_32S against `.rodata' can not be used when making a shared
> object; recompile with -fPIC
> ../../external_libraries/libtlsf.a: error adding symbols: Bad value

Kind regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

sonic-pi_2.9.0~repack-5 ready

[Hanno Zulla]

Hi Petter,

thanks for this:

Am 26.02.2016 um 11:50 schrieb Debian FTP Masters:
> sonic-pi_2.9.0~repack-4_source.changes uploaded successfully to localhost

However, it wouldn't build because of the ruby 2.3 transition. That
causes the did_you_mean gem to install by default, which doesn't run
with ruby 2.2. So this was necessary:

http://anonscm.debian.org/cgit/pkg-multimedia/sonic-pi.git/commit/?id=ca582c210c4691e4feb5554783fa406f1667994e

Could you please upload -5?

Thanks,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Status of sonic-pi and supercollider-sc3-plugins (Re: Request for review & inclusion: sonic-pi, see #796550)

[Hanno Zulla]

Hi,

sorry, I will fix those lintian warnings tomorrow.

> I also think that the actual uploader should push (and ideally sign)
> the tag. Or at least push the tags after uploading.
> 
> If I remember correctly, our pet instance marks packages that have a proper
> distribution set without a tag as "ready for upload" so that sponsors can 
> easily
> find them.

Ok, thanks for the explanation.

Kind regards,

Hanno


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Status of sonic-pi and supercollider-sc3-plugins (Re: Request for review & inclusion: sonic-pi, see #796550)

[Hanno Zulla]

Hello Felipe,

thanks for your pointer in the right direction at

https://github.com/supercollider/sc3-plugins/pull/73

except for the stackrealign flag question (which I believe to be an
artefact in the original cmake rule), I believe
3.7.0~beta+git20151221.f978dc2~repack-7 fixes the sc3-plugins build.

Could you please have a look at it and if you agree, upload it?

Thanks,

Hanno


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Status of sonic-pi and supercollider-sc3-plugins (Re: Request for review & inclusion: sonic-pi, see #796550)

[Hanno Zulla]

Hi,

> I see the problem is in the stk subdir. Maybe the endianness test can
> be skipped if using a system stk?

Thanks, but the STK Ugen plugin is already using the system STK.

Upstream had been so nice to add a SYSTEM_STK=on configuration switch
just for Debian to allow this:
https://github.com/supercollider/sc3-plugins/pull/53

No, it isn't that. Must be something else, I'm debugging this.

Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Status of sonic-pi and supercollider-sc3-plugins (Re: Request for review & inclusion: sonic-pi, see #796550)

[Hanno Zulla]

Hi Petter,
Hi multimedia-maintainers,

first of all, thanks for getting the packages up to speed and ready for
Debian. It took a while, but I learned a lot. :-)

Thanks Petter, I have noticed the issues you mentioned already.


supercollider-sc3-plugins fails to build due to a problem with the cmake
configure run. Apparently, something goes wrong when cmake is calling
another cmake as a sub-process. As a result, on some, but not on all
platforms the cmake TEST_BIG_ENDIAN call fails. As sc3-plugins ought to
be endian-aware, I think this is a cmake problem.


sonic-pi however does have an indirect big endian problem. It uses the
ruby-wavefile gem and as it turned out, that was written, built and
tested upstream on little-endian hardware, only. As the Debian build for
this pure ruby arch:all package was run on a little-endian machine, this
problem wasn't noticed until now.


I'm installing a mips qemu image on my machine right now and then I'll
fix both problems.

> we can limit sonic-pi to the architectures where
> supercollider-sc-plugins is available.

This is still a sensible move. You can't use Sonic Pi without the sc3
plugin collection, so it doesn't make sense to build one where the other
isn't available.

Kind regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#814984: Supercollider: Add hardening flags to debian/rules in supercollider source package

[Hanno Zulla]

Hi,

> I have not tested this, does this actually pass the right variables?
> I'm wary of the interactions between the cdbs rules and including
> dpkg's makefile snippet. Unfortunately , bug #712729 means the
> built-int support in cdbs is currently broken :(

When I tested it locally, lintian stopped complaining about missing
hardening, so it seemed to work. But as I have no experience with cdbs,
it may be better to do this through cdbs instead of my patch and push
for 712729 to be fixed.

> This is OK, although given you are already in the team you could have
> pushed a branch and asked for review/merge to the git repo directly
> (or an ACK to do the merge yourself).

Ok, thanks.

Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#814984: Supercollider: Add hardening flags to debian/rules in supercollider source package

[Hanno Zulla]

Source: supercollider
Version: 1:3.6.6_repack-2-2
Severity: minor

Hi there,

sid's lintian complains about missing hardening in the supercollider
build. This patch adds the needed flags.

Please let me know

a) if this patch is correct

b) if this is the proper format to submit it

c) if this is the proper channel to submit patches like this.

Thanks.
diff --git a/debian/rules b/debian/rules
index 1dccb45..5c36a6a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,9 @@ include /usr/share/cdbs/1/rules/utils.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/cmake.mk
 
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+include /usr/share/dpkg/buildflags.mk
+
 DEB_DH_INSTALL_SOURCEDIR=debian/tmp
 
 # # Add here any variable or target overrides you need.
diff --git a/debian/supercollider-server.lintian-overrides b/debian/supercollider-server.lintian-overrides
new file mode 100644
index 000..a4425ae
--- /dev/null
+++ b/debian/supercollider-server.lintian-overrides
@@ -0,0 +1,2 @@
+# False positive, plugin is built with correct hardening flags
+supercollider-server: hardening-no-fortify-functions usr/lib/SuperCollider/plugins/UIUGens.so
diff --git a/debian/supercollider-supernova.lintian-overrides b/debian/supercollider-supernova.lintian-overrides
new file mode 100644
index 000..a9ee8a2
--- /dev/null
+++ b/debian/supercollider-supernova.lintian-overrides
@@ -0,0 +1,2 @@
+# False positive, plugin is built with correct hardening flags
+supercollider-supernova: hardening-no-fortify-functions usr/lib/SuperCollider/plugins/UIUGens_supernova.so
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider-sc3-plugins_3.7.0~beta+git20151221.f978dc2~repack-4_amd64.changes REJECTED

[Hanno Zulla]

Hi Thorsten,

Thank you for your review. We have reviewed the copyright file and
indeed found a mistake that has been fixed for the recently uploaded
version -5 of the package.

Allow me to clarify this problem you mentioned:

> unfortunately you forgot the CC-BY-SA 3.0 license mentioned in
>  supercollider-sc3-plugins/source/ATK/sc/README

The upstream github repo 
contains git submodules referring to two libraries, ATK and nova-simd.

For Debian, upstream has added a configure setting that allows compiling
the sc3 plugins against Debian's own ATK library, making the embedded
code copy obsolete. ATK has since been removed for the repacked Debian
source package.

However, some source files (e.g. ./source/ATK/sc/README) still refer to
the copyright of the ATK library and the ATK filters that come with it,
but these do not apply to the repacked Debian source package.



> unfortunately you forgot the CC-BY-SA 3.0 license mentioned in
>  
> supercollider-sc3-plugins/source/ATK/sc/HelpSource/Other/ATKDocsLicensing.schelp

True, this has been fixed. Sorry.

As an additional note, the author of the nova-simd library has requested
to not have his library distributed as a separate Debian package, it is
thus included as an embedded copy.



I hope to have cleared up all open questions. If you have questions
about the package or the packaging decisions made, please respond to
Petter or me.

Kind regards,

Hanno



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider-sc3-plugins_3.7.0~beta+git20151221.f978dc2~repack-4_amd64.changes REJECTED

[Hanno Zulla]

Hello Petter,

the main issue is fixed at



...but now that I learned a few new things to take care of while
packaging Sonic Pi, let me fix those lintian warnings before we try again.

Will report back when done.

Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider-sc3-plugins_3.7.0~beta+git20151221.f978dc2~repack-4_amd64.changes REJECTED

[Hanno Zulla]

Hello Thorsten,
hello Petter,

Thorsten:
> unfortunately you forgot the CC-BY-SA 3.0 license mentioned in
> supercollider-sc3-plugins/source/ATK/sc/README

Petter:
> As far as I can tell, the README refer to files that are not included
> in the source (at least not in git)

Indeed, they are not. I had asked upstream about this back in January:

https://github.com/supercollider/sc3-plugins/issues/61

The actual developers responsible for this code didn't respond, but as
far as my investigation goes, there is no CC-BY-SA 3.0 content found in
the repacked Debian source package.

Two different versions of the ATK library itself used to be shipped with
two plugins of the upstream release, but upstream has accepted a fix for
this here:

https://github.com/supercollider/sc3-plugins/pull/56

As of now, the upstream repo contains the ATK library only indirectly as
a git submodule and then compiles against it.

To assist us at Debian with packaging, upstream has added a configure
option to allow compiling against the system's ATK library instead here:

https://github.com/supercollider/sc3-plugins/pull/53

So in the end, there is no ATK library and no ATK filter kernels shipped
with the upstream sources

Thorsten:
> unfortunately you forgot the CC-BY-SA 3.0 license mentioned in
> supercollider-sc3-plugins/source/ATK/sc/README

Petter:
> As for ATKDocsLicensing.schelp, as far as I can tell it refer to the
> license of the CC logo or some documentation that is not in git:

This, unfortunately, is true. The file

source/ATK/sc/HelpSource/Guides/Intro-to-the-ATK.schelp

is CC-BY-SA 3.0 and I will fix that for the package.

Regards,

Hanno

P.S.: Also, there are a number of recordings mentioned in

source/ATK/sc/README_RECORDINGS
source/ATK/sc/HelpSource/Other/ATKLicensing.schelp

which, while mentioned, aren't actually part of upstream's source
distribution.


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: sonic-pi (see #796550)

[Hanno Zulla]

Hi,

Am 11.02.2016 um 19:51 schrieb IOhannes m zmölnig (Debian/GNU):

> then please add a lintian-override documenting the reason.

Done, thanks for pointing that out.

Am 11.02.2016 um 20:05 schrieb Sebastian Ramacher:

> nocheck[1] is not honored. You'll need something like the following:

Thanks for the code snippet. Please have a look if I'm using it
correctly now.

> dh_auto_test at the end of the override does not seem to run
> anything, so there is no need to keep it.

True, but it doesn't hurt to return to the default behaviour of
dh_auto_test to avoid unexpected missing functionality in a later
release. I'd want to keep that call.

Am 11.02.2016 um 22:36 schrieb Petter Reinholdtsen:
> I missed some hints in the debian/changelog file

Added as requested.

> I see in the rules file you use 'cd app/gui/qt; make clean' instead of
> 'make -C app/gui/qt clean.  I suspect -C is a better way to do this.

Ok, fixed.

> Some of the clean target should possibly be sent upstream as a patch to
> get the upstream clean target to remove all generated files.

I'll see if I can do that.


Thanks for the review. Updated as requested.

Should I restart the gbp repo, now that it's using the
watch/uscan/repack solution instead of debian/rules get-orig-source?

Also, is it now time to move the repo from github to
http://anonscm.debian.org/cgit/pkg-multimedia/ ?

Kind regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: sonic-pi (see #796550)

[Hanno Zulla]

Hi Petter,

> Should I restart the gbp repo, now that it's using the
> watch/uscan/repack solution instead of debian/rules get-orig-source?
> 
> Also, is it now time to move the repo from github to
> http://anonscm.debian.org/cgit/pkg-multimedia/ ?

Ok, the gbp repo is now restared and I have removed the stale unused
tags we stumbled over on IRC.

You put it on git.debian.org/git/pkg-multimedia/sonic-pi.git and if
you're now fine with it, please upload. Thanks!

Kind regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: sonic-pi (see #796550)

[Hanno Zulla]

Hello Sebastian,

thanks for the review.

I believe to have fixed all issues you have listed in your review.

Except one:

> I: sonic-pi: spelling-error-in-binary

Those are not spelling errors, lintian is spellchecking the translated
non-English document resources here, which are linked into the Qt
application binary during build.

Please give



a second try and be patient with my packaging effort. :-)

Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Request for review & inclusion: sonic-pi (see #796550)

[Hanno Zulla]

Hi Debian-Multimedia,
Hi Petter,

I *hope* the package is now in pretty good shape and request a review.

Please have a look at



and let me know what you think. The contents of the debian/ folder is
fairly well documented.


The remaining lintian errors are:

> W: sonic-pi: wrong-name-for-upstream-changelog
> usr/share/doc/sonic-pi/CHANGELOG.md.gz

Yes, but it's a markdown file, so what else should be done?

> W: sonic-pi: binary-without-manpage usr/bin/sonic-pi

Ok, does this binary really require a man page? It's a GUI application,
not to be used from the command line.

Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: supercollider-sc3-plugins_3.7.0~beta+git20151221.f978dc2~repack-3_amd64.changes REJECTED

[Hanno Zulla]

Hi Thorsten,

thanks for your review.

> please mention all files licensed under BSD, the Boost-license or a
> Creative Commons license in your debian/copyright.

In reference to the Creative Commons license:

CC is mentioned briefly in source/ATK/sc/README

> The filter kernels distributed with the Ambisonic Toolkit are
> licensed under a Creative Commons Attribution-Share Alike 3.0
> Unported License and are copyright the Ambisonic Toolkit Community
> and Joseph Anderson, 2011.

Reading the source in source/ATK/*, the plugin appears to copy source
and documentation from the ATK Ambisonic Toolkit project, including
sections of that README.

However, the sc3-plugins collection does not contain any "filter
kernels" as mentioned in that README in its tarball. So as far as I can
tell, there is no CC-licensed content in the upstream tarball.

I have asked the sc3-plugins upstream

and the first response agrees. However, I haven't heard back from the
original developers of the ATK sc3 plugin, yet.


Other than this, we have fixed the debian/copyright file and updated
(c)-information for all plugins where possible.

A new upload will follow soon for you to review.

Kind regards,

Hanno


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#805549: Patch for strech, jessie, wheezy

[Hanno Zulla]

Hi,

> Hanno, could you please test on a wheezy and on a jessie system that
> what is living in the debian/{wheezy,jessie} branches works? I don't
> foresee any problems, but we should test first.

Tested on both systems, using amd64.

Worked on both.

This patch fixes the original problem described in this bug.

Thank you,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: supercollider-sc3-plugins (see RFP #807364)

[Hanno Zulla]

Am 05.01.2016 um 00:03 schrieb IOhannes m zmölnig (Debian/GNU):
> On 01/04/2016 02:32 PM, Hanno Zulla wrote:
>> - the packages are depending on (= ${binary:Version}) for each other
> 
> are you sure that "supercollider-sc3-plugins-sclang" must *Depend* on
> "supercollider-sc3-plugins-scsynth"?
> what if i want to run language and synth on different computers?
> i'd recommend using *Recommends*.

If this is an actual use-case, then Debian's supercollider packages do
not support it.

<https://packages.debian.org/de/source/sid/supercollider>

Right now, supercollider is set up that users can install the
synth-server without the language, but not the language without the
synth-server.

supercollider-language depends on supercollider-server.

As a result, since supercollider-sc3-plugins-sclang depends on
supercollider-language, this will pull in supercollider-server. And thus
you need supercollider-sc3-plugins-scsynth, too.

So yes, given Debian's current supercollider package,
supercollider-sc3-plugins-sclang must depend on
supercollider-sc3-plugins-scsynth.

What I'm not so sure about is wether supercollider-sc3-plugins-scsynth
should recommend or suggest supercollider-sc3-plugins-ladspalist. I used
"recommend" right now, but reading up on the FAQ, it seems to me that
"suggest" is the better choice, or is it not?

Thanks,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: supercollider-sc3-plugins (see RFP #807364)

[Hanno Zulla]

Hi Sebastian,



fixed issues:

- the previously unresolvable build-dependency issue has been fixed by
  adding libjack-jackd2-dev

- ladspalist has been moved into its own, optional package

- ladspalist now has a man page

- the packages are depending on (= ${binary:Version}) for each other

- epoch has been removed from version number

I still don't know why "gbp clone" won't clone the pristine-tar branch
from github. If you know where my setup is wrong, please let me know.

In the meantime, you can use the "debian/rules get-orig-source" recipe
to have the tarball fetched from upstream & repacked.

Please review & give me a to-do list of items that need to be resolved.

Thanks,

Hanno


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: supercollider-sc3-plugins (see RFP #807364)

[Hanno Zulla]

Hi there,

> We have prepared a .deb package of supercollider-sc3-plugins at
> 
> and request review and, if acceptable, inclusion of the package.

After initial responses on IRC, I have tried to fix all issues discussed
there and (tada) started it anew, so the repository on github now
contains a fresh start.

Please review.

Thanks,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Request for review & inclusion: supercollider-sc3-plugins (see RFP #807364)

[Hanno Zulla]

Hi there,

> Please build with dh $@ --parallel if possible.

fixed.

> I: supercollider-sc3-plugins source: duplicate-short-description
> supercollider-sc3-plugins supercollider-sc3-plugins-scsynth
> supercollider-sc3-plugins-sclang
> I: supercollider-sc3-plugins-scsynth:
> extended-description-is-probably-too-short

should be fixed.

> W: supercollider-sc3-plugins source: outdated-autotools-helper-file
> source/StkUGens/stk-4.4.4/config/
>
> This is from the embedded copy of stk.

upstream has removed stk as an embedded copy per request.

> This needs an update for the new location of nova-simd.

fixed & repacked. (Correctly repacked?)

> W: supercollider-sc3-plugins-scsynth: binary-without-manpage
> usr/bin/ladspalist
>
> If the package is providing plugins to supercollider, should this
> binary really be on $PATH?

As discussed on IRC, it's unclear to me where to place this binary.

LADSPA plugins can be used through one of the supercollider sc3 ugen
plugins provided by this package.

The binary only lists those LADSPA plugins available to the user.

I'm not sure where else to put it but in /usr/bin. Packaging it in a
separate .deb seems like overkill. Please advise.

man page will follow soon, no problem.

> I: supercollider-sc3-plugins-sclang: package-contains-empty-directory
> usr/share/SuperCollider/Extensions/SC3plugins/local/
>
> Is this empty directory needed?

no, removed.

> Do the three packages suppercollider-sc3-plugins,
> supercollider-sc3-plugins-scsynth and
> supercollider-sc3-plugins-sclang work in
> any version combination should the dependencies by versioned?

They should be versioned. Do I have to mention the explicit version
number in debian/control or is there a placeholder for it?

> If supercollider-sc3-plugins is just an empty metapackage, please put
> it in the correct section.

fixed.

> Why do you install upstream's TODO?

fixed, removed.

> gbp buildpackage -uc -us -S
> gbp:error: Pristine-tar couldn't checkout
"supercollider-sc3-plugins_3.7.0~beta+git20151221.f978dc2~repack.orig.tar.xz"

Please try again, I restarted the github repo once more.

If that still doesn't work, please advice me on what I did wrong there
and how to fix it.

In the meantime, you can use the
debian/rules get-orig-source
recipe to have the tarball fetched from upstream & repacked.

> Never use an epoch unless you really have to. And you don't have to,
> since this was never in the Debian archive.

I have removed the epoch for now, but do want to put it in:

The package was in an Ubuntu PPA where a different versioning had been
used so far and I would want to override that. Also, Debian's
supercollider already uses an epoch and the sc3 plugins follow
supercollider's version scheme.


Thanks so far,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Request for review & inclusion: supercollider-sc3-plugins (see RFP #807364)

[Hanno Zulla]

Hi there,

Petter, Georges and I are preparing Sonic Pi (sonic-pi.net) for
Debian-compliant packaging, see RFP #796550


Sonic Pi combines an electronic synthesizer with a ruby interpreter to
create a new kind of electronic instrument. Made for school children
ages 8 and up, it teaches how to code through the joy of making music.

It comes pre-installed on Raspbian, but their .deb packaging rules are
unconvential.

Sonic Pi depends on supercollider as its synth backend and depends on
the supercollider sc3 plugin collection, see RFP #807364


We have prepared a .deb package of supercollider-sc3-plugins at



and request review and, if acceptable, inclusion of the package.

The package depends on libstk0-dev, but there was a packaging bug with
it that was fixed for sid with #805549 (thanks!). It would be beneficial
if the same libstk0-dev bug could be fixed for stretch, jessie and
wheezy to make the supercollider-sc3-plugins buildable there, see


Regards,

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#805549: Patch for strech, jessie, wheezy

[Hanno Zulla]

Hi,

thanks for fixing this in sid's package. I can confirm that it works to
package supercollider-sc3-plugins.

It would be beneficial if this could be fixed for

strech
jessie
wheezy

too. Why even back to wheezy? Because supercollider-sc3-plugins is also
meant to be used by Raspbian, which is packaging their distribution
based on wheezy and jessie.

Please find an attached patch which will fix this for all three versions
of the current Debian source package.

Thank you,

Hanno
*** stk-4.4.4/debian/patches/01-makefile.patch	2015-09-21 19:17:01.0 +0200
--- stk-4.4.4.patched/debian/patches/01-makefile.patch	2015-12-15 10:19:37.320848851 +0100
***
*** 64,70 
   
  +install-headers:
  +	install -d $(DESTDIR)/usr/include/stk
! +	cp -r ../include/*.h $(DESTDIR)/usr/include/stk
  +
  +install: $(SHAREDLIB) install-headers
  +	install -d  $(DESTDIR)/usr/share/stk
--- 64,70 
   
  +install-headers:
  +	install -d $(DESTDIR)/usr/include/stk
! +	cp -r ../include/* $(DESTDIR)/usr/include/stk
  +
  +install: $(SHAREDLIB) install-headers
  +	install -d  $(DESTDIR)/usr/share/stk
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#805549: libstk0-dev packaging bug, missing include files SKINI.msg and SKINI.tbl

[Hanno Zulla]

Hi,

please find new patch

stk-4.5.0/debian/patches/0006-Fix-install-rule-for-include-files.patch

attached. This fixes the issue for me.

Thanks,

Hanno
Index: stk-4.5.0/src/Makefile.in
===
--- stk-4.5.0.orig/src/Makefile.in	2015-12-10 15:23:05.622300539 +0100
+++ stk-4.5.0/src/Makefile.in	2015-12-10 15:24:03.238092077 +0100
@@ -95,7 +95,7 @@
 
 install-headers:
 	install -d $(DESTDIR)$(PREFIX)$(INCLUDEDIR)/stk
-	cp -r ../include/*.h $(DESTDIR)$(PREFIX)$(INCLUDEDIR)/stk
+	cp -r ../include/* $(DESTDIR)$(PREFIX)$(INCLUDEDIR)/stk
 
 install: $(SHAREDLIB) install-headers
 	install -d $(DESTDIR)$(PREFIX)$(LIBDIR)
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#805549: libstk0-dev packaging bug, missing include files SKINI.msg and SKINI.tbl

[Hanno Zulla]

Hello,

thanks for the new release.

However, it is still broken, the two required files are still missing in
libstk0-dev.

Upstream tarball contains

include/SKINI.msg
include/SKINI.tbl

Upstream tarball also contains src/Makefile, which says:

cp -r ../include/*.h $(DESTDIR)$(PREFIX)$(INCLUDEDIR)/st

So this is an upstream bug.

Upstream has fixed this since 4.5.0 by changing the names of those two
files to names ending with .h.

However, until then, please fix this for the Debian package by changing
the Makefile rule to

cp -r ../include/* $(DESTDIR)$(PREFIX)$(INCLUDEDIR)/st

Thanks.

Hanno

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#805549: libstk0-dev packaging bug, missing include files SKINI.msg and SKINI.tbl

[Hanno Zulla]

Package: libstk0-dev
Version: 4.4.4-5build2
Severity: normal

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

The debian libstk0-dev packaging rule only copies .h files to /usr/include/stk/
but the stk source package comes with two non .h files for that directory:
SKINI.msg and SKINI.tbl are thus missing from the resulting Debian package.

The bug is in the install-headers section of 01-makefile.patch:

+install-headers:
+   install -d $(DESTDIR)/usr/include/stk
+   cp -r ../include/*.h $(DESTDIR)/usr/include/stk

should be

+install-headers:
+   install -d $(DESTDIR)/usr/include/stk
+   cp -r ../include/* $(DESTDIR)/usr/include/stk

instead.

I noticed this while trying to package the supercollider sc3 plugins, which
requires SKINI.msg for building.

Thank you.

*** End of the template - remove these template lines ***


-- System Information:
Debian Release: jessie/sid
  APT prefers wily-updates
  APT policy: (500, 'wily-updates'), (500, 'wily-security'), (500, 'wily'), 
(100, 'wily-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-18-generic (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libstk0-dev depends on:
ii  librtaudio-dev  4.1.1~ds0-3
ii  librtmidi-dev   2.1.0~ds0-4
ii  libstk0c2a  4.4.4-5build2

libstk0-dev recommends no packages.

libstk0-dev suggests no packages.

-- no debconf information

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers