Re: package pkg-multimedia/crtmpserver looking for mentor(s)
понеділок 18 квітень 2011 17:53:45 Reinhard Tartler ви написали: > On Mon, Apr 18, 2011 at 15:13:17 (CEST), Andriy Beregovenko wrote: > > субота 16 квітень 2011 23:13:17 Reinhard Tartler ви написали: > >> On Fri, Apr 15, 2011 at 21:38:42 (CEST), Reinhard Tartler wrote: > >> > I had another look at the package. In debian/crtmpserver.install, the > >> > package installs crtmpserver/crtmpserver.lua -> > >> > etc/crtmpserver. However, this configuration file seems horribly > >> > specific to me; i.e., we can safely expect that every user *will* > >> > definitly want to edit and adjust the contents. This also means that > >> > dpkg *will* prompt on every package upgrade that changes anything in > >> > the file. > >> > > >> > Sorry, the more I think about it, I come to the conclusion that > >> > > >> > a) we should not install the config file to /etc/ > >> > b) not install the init script > >> > c) not create the system user > >> > > >> > This will reduce a lot of complexity in the package, which wouldn't > >> > help our users much anyway. > >> > >> I have now implemented this change in a way that can be easily > >> reverted. Please have a look and either revert or OK this change. > > > > I'm novice in debian packing policy, so I prefer to listen to more > > experienced people. Also, your point of view is not meaningless. That is > > why I agree with most part of your modifications. > > But, I'm still not understand why "crtmpserver.lua" is "horribly > > specific". All other issues follow by this one. > > Well, the file does not seem to be meant used unmodified; au contrary, > AFAIUI you *must* edit it to specify what content you want to stream. Mostly not need. Current configuration file is big cause it there are many explanations what we can do. Also it is "generic" :). Yes, we can specify some "static" configuration like pulling/pushing streams, static pointing to some directory with media files and few other options. But main work of this software is dynamic streaming. Someone push stream into it, and another one play it :) Anyway, currently there are plans to move configuration to separated files (in conf.d style) Also you can simply specify your own configuration file via defaults. For novice it works by default. Anyway I review configuration file and I will make it less specific. > And these are the modification that will trigger conffile > changes on every upgrade, which I think we should avoid. I think about this, but there are many packages which has like situation(squid for example). > I take your mail as OK to the simplification and will upload it tonight > or tomorrow then. Yes, I would be very grateful. > Cheers! ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
On Mon, Apr 18, 2011 at 15:13:17 (CEST), Andriy Beregovenko wrote: > субота 16 квітень 2011 23:13:17 Reinhard Tartler ви написали: >> On Fri, Apr 15, 2011 at 21:38:42 (CEST), Reinhard Tartler wrote: >> > I had another look at the package. In debian/crtmpserver.install, the >> > package installs crtmpserver/crtmpserver.lua -> >> > etc/crtmpserver. However, this configuration file seems horribly >> > specific to me; i.e., we can safely expect that every user *will* >> > definitly want to edit and adjust the contents. This also means that >> > dpkg *will* prompt on every package upgrade that changes anything in the >> > file. >> > >> > Sorry, the more I think about it, I come to the conclusion that >> > >> > a) we should not install the config file to /etc/ >> > b) not install the init script >> > c) not create the system user >> > >> > This will reduce a lot of complexity in the package, which wouldn't help >> > our users much anyway. >> >> I have now implemented this change in a way that can be easily >> reverted. Please have a look and either revert or OK this change. > > I'm novice in debian packing policy, so I prefer to listen to more > experienced > people. Also, your point of view is not meaningless. That is why I agree with > most part of your modifications. > But, I'm still not understand why "crtmpserver.lua" is "horribly specific". > All other issues follow by this one. Well, the file does not seem to be meant used unmodified; au contrary, AFAIUI you *must* edit it to specify what content you want to stream. And these are the modification that will trigger conffile changes on every upgrade, which I think we should avoid. I take your mail as OK to the simplification and will upload it tonight or tomorrow then. Cheers! -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
субота 16 квітень 2011 23:13:17 Reinhard Tartler ви написали: > On Fri, Apr 15, 2011 at 21:38:42 (CEST), Reinhard Tartler wrote: > > I had another look at the package. In debian/crtmpserver.install, the > > package installs crtmpserver/crtmpserver.lua -> > > etc/crtmpserver. However, this configuration file seems horribly > > specific to me; i.e., we can safely expect that every user *will* > > definitly want to edit and adjust the contents. This also means that > > dpkg *will* prompt on every package upgrade that changes anything in the > > file. > > > > Sorry, the more I think about it, I come to the conclusion that > > > > a) we should not install the config file to /etc/ > > b) not install the init script > > c) not create the system user > > > > This will reduce a lot of complexity in the package, which wouldn't help > > our users much anyway. > > I have now implemented this change in a way that can be easily > reverted. Please have a look and either revert or OK this change. I'm novice in debian packing policy, so I prefer to listen to more experienced people. Also, your point of view is not meaningless. That is why I agree with most part of your modifications. But, I'm still not understand why "crtmpserver.lua" is "horribly specific". All other issues follow by this one. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
On Fri, Apr 15, 2011 at 21:38:42 (CEST), Reinhard Tartler wrote: > I had another look at the package. In debian/crtmpserver.install, the > package installs crtmpserver/crtmpserver.lua -> > etc/crtmpserver. However, this configuration file seems horribly > specific to me; i.e., we can safely expect that every user *will* > definitly want to edit and adjust the contents. This also means that > dpkg *will* prompt on every package upgrade that changes anything in the > file. > > Sorry, the more I think about it, I come to the conclusion that > > a) we should not install the config file to /etc/ > b) not install the init script > c) not create the system user > > This will reduce a lot of complexity in the package, which wouldn't help > our users much anyway. I have now implemented this change in a way that can be easily reverted. Please have a look and either revert or OK this change. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
On Fri, Apr 15, 2011 at 14:32:34 (CEST), Andriy Beregovenko wrote: > Hi. > > Any news ? :) please don't top quote > понеділок 11 квітень 2011 23:58:42 Reinhard Tartler ви написали: >> On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote: >> > On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote: >> >> Hi, >> >> >> >> Still looking for uploader :) >> >> As I understand package now is clean. >> > >> > I'll try to have a look tonight or tomorrow evening. >> >> It seems that Alessio is already on it. Alessio, do you want to take >> over? >> >> I took a brief look and found the system user creation a bit >> strange. If you created the user in postinst, you wouldn't need the >> pre-dependency on adduser. And moreover, since the default configuration >> doesn't start the daemon anyways, I'd rather skip the system user >> creation completely and install the crtmpserver.lua config file in >> /usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along >> with some instructions to the users how to start the daemon. >> >> This will save you a lot of headaches and bugreports. I had another look at the package. In debian/crtmpserver.install, the package installs crtmpserver/crtmpserver.lua -> etc/crtmpserver. However, this configuration file seems horribly specific to me; i.e., we can safely expect that every user *will* definitly want to edit and adjust the contents. This also means that dpkg *will* prompt on every package upgrade that changes anything in the file. Sorry, the more I think about it, I come to the conclusion that a) we should not install the config file to /etc/ b) not install the init script c) not create the system user This will reduce a lot of complexity in the package, which wouldn't help our users much anyway. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi.
Any news ? :)
понеділок 11 квітень 2011 23:58:42 Reinhard Tartler ви написали:
> On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote:
> > On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote:
> >> Hi,
> >>
> >> Still looking for uploader :)
> >> As I understand package now is clean.
> >
> > I'll try to have a look tonight or tomorrow evening.
>
> It seems that Alessio is already on it. Alessio, do you want to take
> over?
>
> I took a brief look and found the system user creation a bit
> strange. If you created the user in postinst, you wouldn't need the
> pre-dependency on adduser. And moreover, since the default configuration
> doesn't start the daemon anyways, I'd rather skip the system user
> creation completely and install the crtmpserver.lua config file in
> /usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along
> with some instructions to the users how to start the daemon.
>
> This will save you a lot of headaches and bugreports.
>
> The file debian/source/local-options is missing, see the wiki for
> details
>
> In debian/rules, where do the variables ${SVER} and ${DEBPATH} come from?
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
понеділок 11 квітень 2011 23:58:42 Reinhard Tartler ви написали:
> On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote:
> > On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote:
> >> Hi,
> >>
> >> Still looking for uploader :)
> >> As I understand package now is clean.
> >
> > I'll try to have a look tonight or tomorrow evening.
>
> It seems that Alessio is already on it. Alessio, do you want to take
> over?
>
> I took a brief look and found the system user creation a bit
> strange. If you created the user in postinst, you wouldn't need the
> pre-dependency on adduser.
Has no reason to finish package install if user can not be created(or not
already exist). That is why I put user creation in preinst. Also adduser dep
was added looking into other packages. Need I remove this dep ?
> And moreover, since the default configuration
> doesn't start the daemon anyways,
Hm... By default after install, daemon must start. This works for me and some
another test platforms. So if it not start this is bug. In that way please
describe me a little you situation about this.
> I'd rather skip the system user
> creation completely and install the crtmpserver.lua config file in
> /usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along
> with some instructions to the users how to start the daemon.
>
> This will save you a lot of headaches and bugreports.
>
> The file debian/source/local-options is missing, see the wiki for
> details
Fixed.
> In debian/rules, where do the variables ${SVER} and ${DEBPATH} come from?
This was used by me, at time of build in my env. Of course this is
unacceptable for package at all. So I move ${SVER} to static string in rules,
and ${DEBPATH} to $(shell pwd).
Also I understand that "$(shell pwd)" is exactly wrong form, but right now I
do not see any way to provide value for CRMPSERVER_SOURCE_ROOT variable. If
you know how, please tell me(CRMPSERVER_SOURCE_ROOT must be pointed to package
source root).
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Reinhard,
I’m quite busy these days, so please go ahead if you have some time for this
package.
--
Sent from my Toshiba Folio 100 with Android
Reinhard Tartler ha scritto:
On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote: > On Wed, Apr
06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote: > >> Hi, >> >> Still
looking for uploader :) >> As I understand package now is clean. > > I'll try
to have a look tonight or tomorrow evening. It seems that Alessio is already on
it. Alessio, do you want to take over? I took a brief look and found the system
user creation a bit strange. If you created the user in postinst, you wouldn't
need the pre-dependency on adduser. And moreover, since the default
configuration doesn't start the daemon anyways, I'd rather skip the system user
creation completely and install the crtmpserver.lua config file in
/usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along with some
instructions to the users how to start the daemon. This will save you a lot of
headaches and bugreports. The file debian/source/local-options is missing, see
the wiki for details In debian/rules, where do the variables ${SVER} and
${DEBPATH} come from? -- Gruesse/greetings, Reinhard Tartler, KeyID
945348A4_
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote:
> On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote:
>
>> Hi,
>>
>> Still looking for uploader :)
>> As I understand package now is clean.
>
> I'll try to have a look tonight or tomorrow evening.
It seems that Alessio is already on it. Alessio, do you want to take
over?
I took a brief look and found the system user creation a bit
strange. If you created the user in postinst, you wouldn't need the
pre-dependency on adduser. And moreover, since the default configuration
doesn't start the daemon anyways, I'd rather skip the system user
creation completely and install the crtmpserver.lua config file in
/usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along
with some instructions to the users how to start the daemon.
This will save you a lot of headaches and bugreports.
The file debian/source/local-options is missing, see the wiki for
details
In debian/rules, where do the variables ${SVER} and ${DEBPATH} come from?
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote: > Hi, > > Still looking for uploader :) > As I understand package now is clean. I'll try to have a look tonight or tomorrow evening. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi, Still looking for uploader :) As I understand package now is clean. On Friday 25 March 2011 11:53:16 Andriy Beregovenko wrote: > Hi. > I'm still looking for mentor for my package crtmpserver. > Also, if someone can, please review package and show me the flaws that > prevent it from uploading. > It is here: http://git.debian.org/?p=pkg-multimedia/crtmpserver.git > > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi. Finally I remove tinyxml from sources and crtmpserver success build with systemwide tinyxml. Also cleaned copyright. So looking for review package and (if all clean) for uploader. п'ятниця 25 березень 2011 14:06:27 Andriy Beregovenko ви написали: > п'ятниця 25 березень 2011 13:25:39 Alessio Treglia ви написали: > > Please take a look at this too: > > > > E: crtmpserver: embedded-library usr/lib/crtmpserver/libcommon.so: > > tinyxml N: > > N:The given ELF object appears to have been statically linked to a > > N:library. Doing this is strongly discouraged due to the extra work > > needed N:by the security team to fix all the extra embedded copies or > > trigger the N:package rebuilds, as appropriate. > > N: > > N:If the package uses a modified version of the given library it is > > highly N:recommended to coordinate with the library's maintainer to > > include the N:changes on the system version of the library. > > N: > > N:Refer to Debian Policy Manual section 4.13 (Convenience copies of > > code) N:for details. > > N: > > N:Severity: serious, Certainty: possible > > Waiting for upstream update which allows to use systemwide tinyxml. > This will happen today :) > > > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
п'ятниця 25 березень 2011 13:25:39 Alessio Treglia ви написали: > Please take a look at this too: > > E: crtmpserver: embedded-library usr/lib/crtmpserver/libcommon.so: tinyxml > N: > N:The given ELF object appears to have been statically linked to a > N:library. Doing this is strongly discouraged due to the extra work > needed N:by the security team to fix all the extra embedded copies or > trigger the N:package rebuilds, as appropriate. > N: > N:If the package uses a modified version of the given library it is > highly N:recommended to coordinate with the library's maintainer to > include the N:changes on the system version of the library. > N: > N:Refer to Debian Policy Manual section 4.13 (Convenience copies of > code) N:for details. > N: > N:Severity: serious, Certainty: possible Waiting for upstream update which allows to use systemwide tinyxml. This will happen today :) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Please take a look at this too: E: crtmpserver: embedded-library usr/lib/crtmpserver/libcommon.so: tinyxml N: N:The given ELF object appears to have been statically linked to a N:library. Doing this is strongly discouraged due to the extra work needed N:by the security team to fix all the extra embedded copies or trigger the N:package rebuilds, as appropriate. N: N:If the package uses a modified version of the given library it is highly N:recommended to coordinate with the library's maintainer to include the N:changes on the system version of the library. N: N:Refer to Debian Policy Manual section 4.13 (Convenience copies of code) N:for details. N: N:Severity: serious, Certainty: possible -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer | quadris...@ubuntu.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
п'ятниця 25 березень 2011 12:47:44 Alessio Treglia ви написали: > Hi Andriy, > > On Fri, Mar 25, 2011 at 10:53 AM, Andriy Beregovenko wrote: > > Hi. > > I'm still looking for mentor for my package crtmpserver. > > Also, if someone can, please review package and show me the flaws that > > prevent it from uploading. > > It is here: http://git.debian.org/?p=pkg-multimedia/crtmpserver.git > > I'm on it, please would you extend the description of the patches, > filling them with all fields needed as per DEP-3 spec? [1] > Moreover, just saying what the patch does is not enough, it would be > good to elaborate a bit the rationale. I'll fix this in few "ten minute". > Great job man! > > [1] http://dep.debian.net/deps/dep3/ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi Andriy, On Fri, Mar 25, 2011 at 10:53 AM, Andriy Beregovenko wrote: > Hi. > I'm still looking for mentor for my package crtmpserver. > Also, if someone can, please review package and show me the flaws that prevent > it from uploading. > It is here: http://git.debian.org/?p=pkg-multimedia/crtmpserver.git I'm on it, please would you extend the description of the patches, filling them with all fields needed as per DEP-3 spec? [1] Moreover, just saying what the patch does is not enough, it would be good to elaborate a bit the rationale. Great job man! [1] http://dep.debian.net/deps/dep3/ -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer | quadris...@ubuntu.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
