Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Hi, apologies for the delay. Finally found time to investigate the random failures -- turned out to be reading a variable that's uninitialized after my original patch. The attached fix works for me. -- Anton Khirnov From 414522d5049a230e71a2c2fef45a6b525d6a9803 Mon Sep 17 00:00:00 2001 From: Anton Khirnov an...@khirnov.net Date: Sun, 26 Oct 2014 18:29:48 +0100 Subject: [PATCH] Fix uninitialized read. --- xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.cpp b/xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.cpp index 932985a..9d90a9c 100644 --- a/xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.cpp +++ b/xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.cpp @@ -1095,9 +1095,6 @@ int CDecoder::Decode(AVCodecContext *avctx, AVFrame *pFrame) CSingleLock lock(m_DecoderSection); - if (m_DecoderError pFrame) -return VC_ERROR; - if (!m_vdpauConfigured) return VC_ERROR; -- 2.0.0.rc2 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
On 14 October 2014 00:02, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2014-10-13 23:46 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: Yes, VDPAU acceleration fails with the latest package. But it's a bit better than before, because I have one example of working movie which was not working with previous libav based xbmc packages. All other tested movies fails with VDPAU. But everything works fine with ffmpeg based xbmc. This is my card: 01:00.0 VGA compatible controller: NVIDIA Corporation GK107 [GeForce GTX 650] (rev a1) Driver: nvidia-vdpau-driver:amd64340.46-1 How can I help? I suspect some codecs work but others don't. Please collect xbmc logs while playing the working and not working files and attach them to the bug. It's strange. I have tried to play sample videos attached by Sergej Wildemann. And they sometimes work but not always. It's random. I have attached logs for both cases. vdpau_blank_xbmc.log.gz Description: GNU Zip compressed data vdpau_good_xbmc.log.gz Description: GNU Zip compressed data ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Hi Wojciech, 2014-10-19 14:22 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: On 14 October 2014 00:02, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2014-10-13 23:46 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: Yes, VDPAU acceleration fails with the latest package. But it's a bit better than before, because I have one example of working movie which was not working with previous libav based xbmc packages. All other tested movies fails with VDPAU. But everything works fine with ffmpeg based xbmc. This is my card: 01:00.0 VGA compatible controller: NVIDIA Corporation GK107 [GeForce GTX 650] (rev a1) Driver: nvidia-vdpau-driver:amd64340.46-1 How can I help? I suspect some codecs work but others don't. Please collect xbmc logs while playing the working and not working files and attach them to the bug. It's strange. I have tried to play sample videos attached by Sergej Wildemann. And they sometimes work but not always. It's random. I have attached logs for both cases. Thank you for the logs they are very useful. The symptom and the logs suggest that it it a threading problem (T is the thread id): bad: ... 14:09:30 T:139908127639296 NOTICE: CDVDVideoCodecFFmpeg::GetFormat - Creating VDPAU(1280x720) 14:09:30 T:139908119246592 NOTICE: running thread: CDVDPlayerAudio::Process() 14:09:30 T:139908119246592 DEBUG: CDVDPlayerAudio - CDVDMsg::GENERAL_RESYNC(5000.00, 1) 14:09:30 T:139908119246592 NOTICE: Creating audio stream (codec id: 86019, channels: 6, sample rate: 48000, no pass-through) 14:09:30 T:139908589209344INFO: CActiveAESink::OpenSink - initialize sink 14:09:30 T:139908589209344 DEBUG: CActiveAESink::OpenSink - trying to open device ALSA:@ 14:09:30 T:139908589209344 DEBUG: CAESinkALSA::GetChannelLayout - Input Channel Count: 2 Output Channel Count: 2 14:09:30 T:139908589209344 DEBUG: CAESinkALSA::GetChannelLayout - Requested Layout: FL,FR 14:09:30 T:139908589209344 DEBUG: CAESinkALSA::GetChannelLayout - Got Layout: FL,FR 14:09:30 T:139908589209344INFO: CAESinkALSA::Initialize - Attempting to open device @ 14:09:30 T:139908119246592 DEBUG: CDVDPlayerAudio:: synctype set to 0: clock feedback 14:09:30 T:139908127639296 NOTICE: VDPAU::CreateContext - creating decoder context 14:09:30 T:139908589209344INFO: CAESinkALSA::Initialize - Opened device sysdefault 14:09:30 T:139908589209344INFO: CAESinkALSA::InitializeHW - Your hardware does not support AE_FMT_FLOAT, trying other formats ... 14:09:30 T:139908127639296 DEBUG: CVDPAU::SetWidthHeight Setting OutWidth: 870 OutHeight: 489 14:09:30 T:139908127639296 NOTICE: (VDPAU) screenWidth:870 vidWidth:1280 surfaceWidth:1280 14:09:30 T:139908127639296 NOTICE: (VDPAU) screenHeight:489 vidHeight:720 surfaceHeight:720 14:09:30 T:139907351705344 NOTICE: Thread Vdpau Output start, auto delete: false 14:09:30 T:139907351705344 NOTICE: COutput::OnStartup: Output Thread created 14:09:30 T:139907351705344 NOTICE: VDPAU::COutput::CreateGlxContext - created context 14:09:30 T:139907351705344 NOTICE: VDPAU::COutput: vdpau gl interop initialized 14:09:30 T:139907343312640 NOTICE: Thread Vdpau Mixer start, auto delete: false 14:09:30 T:139907343312640 NOTICE: CMixer::OnStartup: Output Thread created 14:09:30 T:139907343312640 NOTICE: (VDPAU) Creating the video mixer 14:09:30 T:139907351705344 NOTICE: VDPAU::COutput::InitBufferPool - Output Surface created 14:09:30 T:139908127639296 NOTICE: Previous line repeats 3 times. 14:09:30 T:139908127639296 DEBUG: CDVDPlayerVideo - CDVDMsg::GENERAL_RESYNC(208000.00, 0) 14:09:30 T:139908127639296 DEBUG: CDVDPlayerVideo - video decoder returned error 14:09:30 T:139909238515776 DEBUG: Previous line repeats 53 times. 14:09:30 T:139909238515776 DEBUG: LogindUPowerSyscall - Received unknown signal NameAcquired 14:09:30 T:139908127639296 DEBUG: CDVDPlayerVideo - video decoder returned error 14:09:31 T:139908127639296 DEBUG: Previous line repeats 163 times. 14:09:31 T:139908127639296 WARNING: CDVDMessageQueue(video)::Get - asked for new data packet, with nothing available ... good: ... 14:17:40 T:139776842725120INFO: CDVDPlayerVideo - Stillframe left, switching to normal playback 14:17:40 T:139776842725120 NOTICE: CDVDVideoCodecFFmpeg::GetFormat - Creating VDPAU(1280x720) 14:17:40 T:139776842725120 NOTICE: VDPAU::CreateContext - creating decoder context 14:17:40 T:139777614022720 NOTICE: WebServer: Started the webserver 14:17:40 T:139777614022720 NOTICE: starting upnp server 14:17:40 T:139776867903232 DEBUG: CZeroconfAvahi::doPublishService identifier: servers.webserver type: _http._tcp name:XBMC (home) port:8123 14:17:40 T:139776867903232 DEBUG: CZeroconfAvahi::doPublishService: client not running, queued for publishing 14:17:40 T:139776867903232 DEBUG: CZeroconfAvahi::doPublishService identifier: servers.jsonrpc-http type: _xbmc-jsonrpc-h._tcp name:XBMC (home) port:8123 ... 14:17:40 T:139776054740736 NOTICE:
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
2014-10-19 14:22 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: It's strange. I have tried to play sample videos attached by Sergej Wildemann. And they sometimes work but not always. It's random. I have attached logs for both cases. After testing for some days, i also noticed that they tend to work randomly. Most files show a video after start/stopping them a few times. Regards, Sergej ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Hi, 2014-10-14 2:01 GMT+02:00 Sergej Wildemann wildem...@finf.uni-hannover.de: Hi, i tested the current xbmc package in unstable 13.2+dfsg1-2. Some videos play, some don't. I couldn't see a reason for that. In my tests it was like 50:50. All files are mkv with x264 video. The computer has a radeon GPU: 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Wrestler [Radeon HD 6320] You can find problematic samples here: http://krul.finf.uni-hannover.de/~fjen/xbmc/ This one works for example: http://ftp.halifax.rwth-aachen.de/blender/demo/movies/Sintel.2010.720p.mkv Thank you for the samples. I have updated the bug at Libav here: https://bugzilla.libav.org/show_bug.cgi?id=674 Cheers, Balint ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
On 2014-10-14 02:01:31, Sergej Wildemann wrote: You can find problematic samples here: http://krul.finf.uni-hannover.de/~fjen/xbmc/ fwiw, they all play fine here. Cheers -- Sebastian Ramacher signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
2014-10-14 14:32 GMT+02:00 Sebastian Ramacher sramac...@debian.org: On 2014-10-14 02:01:31, Sergej Wildemann wrote: You can find problematic samples here: http://krul.finf.uni-hannover.de/~fjen/xbmc/ fwiw, they all play fine here. Do you use amd64, too? Cheers, Balint ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
On 2014-10-14 16:37:38, Bálint Réczey wrote: 2014-10-14 14:32 GMT+02:00 Sebastian Ramacher sramac...@debian.org: On 2014-10-14 02:01:31, Sergej Wildemann wrote: You can find problematic samples here: http://krul.finf.uni-hannover.de/~fjen/xbmc/ fwiw, they all play fine here. Do you use amd64, too? Yes Cheers -- Sebastian Ramacher signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Hi, 2014-10-08 21:57 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: Hello. I am using VDPAU on my NVIDIA card and latest working version was 2:13.2+dfsg1-2~exp1 based on ffmpeg libs. In current version 2:13.2+dfsg1-2 I have a blank video again. VDPAU in 2:13.2+dfsg1-2 worked for Sebasian [1]. Sebastian, did you use NVIDIA cards for testing, too? Wojciech, are you sure VDPAU acceleration fails with the latest package? Cheers, Balint ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Yes, VDPAU acceleration fails with the latest package. But it's a bit better than before, because I have one example of working movie which was not working with previous libav based xbmc packages. All other tested movies fails with VDPAU. But everything works fine with ffmpeg based xbmc. This is my card: 01:00.0 VGA compatible controller: NVIDIA Corporation GK107 [GeForce GTX 650] (rev a1) Driver: nvidia-vdpau-driver:amd64340.46-1 How can I help? On 13 October 2014 15:21, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2014-10-08 21:57 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: Hello. I am using VDPAU on my NVIDIA card and latest working version was 2:13.2+dfsg1-2~exp1 based on ffmpeg libs. In current version 2:13.2+dfsg1-2 I have a blank video again. VDPAU in 2:13.2+dfsg1-2 worked for Sebasian [1]. Sebastian, did you use NVIDIA cards for testing, too? Wojciech, are you sure VDPAU acceleration fails with the latest package? Cheers, Balint ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
On Mon, Oct 13, 2014 at 5:46 PM, Wojciech Kuranowski wojci...@kuranowski.pl wrote: Yes, VDPAU acceleration fails with the latest package [xbmc with Anton's patch compiled against libav]. But it's a bit better than before, because I have one example of working movie which was not working with previous libav based xbmc packages. All other tested movies fails with VDPAU. But everything works fine with ffmpeg based xbmc. Can you provide samples of movies that do work and those that don't work? I've also CC'ed Anton from Libav, who kindly provided patches and suggestions in the context of this bug. This is my card: 01:00.0 VGA compatible controller: NVIDIA Corporation GK107 [GeForce GTX 650] (rev a1) Driver: nvidia-vdpau-driver:amd64340.46-1 How can I help? We need to find out why some videos break and others work so that the problem can be identified and fixed in the code. Thanks, Reinhard ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Hi, 2014-10-13 23:46 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: Yes, VDPAU acceleration fails with the latest package. But it's a bit better than before, because I have one example of working movie which was not working with previous libav based xbmc packages. All other tested movies fails with VDPAU. But everything works fine with ffmpeg based xbmc. This is my card: 01:00.0 VGA compatible controller: NVIDIA Corporation GK107 [GeForce GTX 650] (rev a1) Driver: nvidia-vdpau-driver:amd64340.46-1 How can I help? I suspect some codecs work but others don't. Please collect xbmc logs while playing the working and not working files and attach them to the bug. Cheers, Balint On 13 October 2014 15:21, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2014-10-08 21:57 GMT+02:00 Wojciech Kuranowski wojci...@kuranowski.pl: Hello. I am using VDPAU on my NVIDIA card and latest working version was 2:13.2+dfsg1-2~exp1 based on ffmpeg libs. In current version 2:13.2+dfsg1-2 I have a blank video again. VDPAU in 2:13.2+dfsg1-2 worked for Sebasian [1]. Sebastian, did you use NVIDIA cards for testing, too? Wojciech, are you sure VDPAU acceleration fails with the latest package? Cheers, Balint ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#742896: Blank screen on all videos with VDPAU and nVidia card (xbmc)
Hi, i tested the current xbmc package in unstable 13.2+dfsg1-2. Some videos play, some don't. I couldn't see a reason for that. In my tests it was like 50:50. All files are mkv with x264 video. The computer has a radeon GPU: 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Wrestler [Radeon HD 6320] You can find problematic samples here: http://krul.finf.uni-hannover.de/~fjen/xbmc/ This one works for example: http://ftp.halifax.rwth-aachen.de/blender/demo/movies/Sintel.2010.720p.mkv Thanks, Sergej ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
