Bug#853520: lives: ftbfs with GCC-7

[salsaman]

OK, all errors / warnings fixed I believe (with exception of the gtk+
warning). Will update after checking in to svn.

Regarding the gtk+ warning - the code calls a wrapper function which in
turn calls gtk_widget_set_valign() / gtk_widget_set_halign() which
presumably contain deprecated calls to  gtk_alignment_get_type(). As noted
this appears to be a gtk+ issue.






On Tue, Jan 31, 2017 at 11:33 AM, salsaman  wrote:

> Ah OK, got it - inlines now need to be explicitly static or declared in
> the header.
>
>
>
>
> On Tue, Jan 31, 2017 at 8:32 AM, Matthias Klose  wrote:
>
>> On 31.01.2017 12:04, salsaman wrote:
>> > The gcc error makes no sense as the function get_time_from_x() is
>> defined
>> > (inline) earlier in multitrack.c at line 971.
>> > You should report this as a bug in gcc.
>>
>> no. define it as static inline like the other zillions of inline
>> functions.
>>
>>
>
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#853520: lives: ftbfs with GCC-7

[salsaman]

Ah OK, got it - inlines now need to be explicitly static or declared in the
header.



On Tue, Jan 31, 2017 at 8:32 AM, Matthias Klose  wrote:

> On 31.01.2017 12:04, salsaman wrote:
> > The gcc error makes no sense as the function get_time_from_x() is defined
> > (inline) earlier in multitrack.c at line 971.
> > You should report this as a bug in gcc.
>
> no. define it as static inline like the other zillions of inline functions.
>
>
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#853520: lives: ftbfs with GCC-7

[Matthias Klose]

On 31.01.2017 12:04, salsaman wrote:
> The gcc error makes no sense as the function get_time_from_x() is defined
> (inline) earlier in multitrack.c at line 971.
> You should report this as a bug in gcc.

no. define it as static inline like the other zillions of inline functions.

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#853520: lives: ftbfs with GCC-7

[salsaman]

The gcc error makes no sense as the function get_time_from_x() is defined
(inline) earlier in multitrack.c at line 971.
You should report this as a bug in gcc.

The warning regarding  gtk_alignment_get_type() is internal to gtk+. You
should open a bug report there
.
The other warnings are vaid for LiVES but are trivial to fix.

Gabriel.


On Tue, Jan 31, 2017 at 6:33 AM, Matthias Klose  wrote:

> Package: src:lives
> Version: 2.8.3-1
> Severity: normal
> Tags: sid buster
> User: debian-...@lists.debian.org
> Usertags: ftbfs-gcc-7
>
> Please keep this issue open in the bug tracker for the package it
> was filed for.  If a fix in another package is required, please
> file a bug for the other package (or clone), and add a block in this
> package. Please keep the issue open until the package can be built in
> a follow-up test rebuild.
>
> The package fails to build in a test rebuild on at least amd64 with
> gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
> severity of this report may be raised before the buster release.
> There is no need to fix this issue in time for the stretch release.
>
> The full build log can be found at:
> http://people.debian.org/~doko/logs/gcc7-20170126/lives_
> 2.8.3-1_unstable_gcc7.log
> The last lines of the build log are at the end of this report.
>
> To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
> or install the gcc, g++, gfortran, ... packages from experimental.
>
>   apt-get -t=experimental install g++
>
> Common build failures are new warnings resulting in build failures with
> -Werror turned on, or new/dropped symbols in Debian symbols files.
> For other C/C++ related build failures see the porting guide at
> http://gcc.gnu.org/gcc-7/porting_to.html
>
> [...]
> callbacks.c:5975:15: warning: '*' in boolean context, suggest '&&' instead
> [-Wint-in-bool-context]
>  if (height*width) {
>  ~~^~
> callbacks.c:6006:15: warning: '*' in boolean context, suggest '&&' instead
> [-Wint-in-bool-context]
>if (!(height*width)&_type!=LIVES_PREVIEW_TYPE_IMAGE_ONLY) {
> ~~~^~~
> callbacks.c:6123:7: warning: 'gtk_alignment_get_type' is deprecated
> [-Wdeprecated-declarations]
>lives_alignment_set(LIVES_ALIGNMENT(mainw->fs_playalign),0.5,
>^~~
> In file included from /usr/include/gtk-3.0/gtk/gtk.h:251:0,
>  from main.h:74,
>  from callbacks.c:21:
> /usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:77:12: note: declared
> here
>  GType  gtk_alignment_get_type   (void) G_GNUC_CONST;
> ^~
> callbacks.c: In function 'on_full_screen_activate':
> callbacks.c:6716:33: warning: '*' in boolean context, suggest '&&' instead
> [-Wint-in-bool-context]
>  if (!(mainw->vpp->fwidth*mainw->vpp->fheight)) {
>   ~~~^
> callbacks.c: In function 'on_double_size_activate':
> callbacks.c:6903:29: warning: '*' in boolean context, suggest '&&' instead
> [-Wint-in-bool-context]
>  } while (!(mainw->pwidth*mainw->pheight));
>~~^~~~
> callbacks.c: In function 'on_sepwin_activate':
> callbacks.c:7088:35: warning: '*' in boolean context, suggest '&&' instead
> [-Wint-in-bool-context]
>if (!(mainw->vpp->fwidth*mainw->vpp->fheight)) {
> ~~~^
> main.c: In function 'switch_to_file':
> main.c:7105:19: warning: '*' in boolean context, suggest '&&' instead
> [-Wint-in-bool-context]
>if (old_file*new_file) mainw->preview_frame=0;
>^
> /bin/bash ../libtool  --tag=CC   --mode=link gcc -Wstrict-aliasing=0 -Wall
> -DHAVE_YUV4MPEG=1 -DHAVE_LDVGRAB=1 -I libavc1394/avc1394.h -I
> libraw1394/raw1394.h -I libraw1394/rom1394.h -DIS_LINUX_GNU=1
> -DENABLE_OSC=1  -I/usr/include/alsa -DALSA_MIDI=1 -I/usr/include/libpng16
> -DUSE_LIBPNG=1 -I/usr/include/x86_64-linux-gnu
> -I/usr/include/x86_64-linux-gnu -DUSE_SWSCALE=1 -DENABLE_JACK
> -DENABLE_JACK_TRANSPORT -lpulse -DHAVE_PULSE_AUDIO=1 -DENABLE_GIW=1
> -DHAVE_UNICAP=1   -DLIVES_LIBDIR=\""/usr/lib/x86_64-linux-gnu"\"
> -DHAVE_WEBM=1  -g -O2 -fdebug-prefix-map=/<>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
> -D_FORTIFY_SOURCE=2 -Wall -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0
> -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0
> -lglib-2.0 -pthread -shared  -Wl,-z,relro -o lives-exe widget-helper.o
> main.o support.o effects.o plugins.o effects-weed.o effects-data.o
> framedraw.o interface.o paramspecial.o paramwindow.o rfx-builder.o
> lives-yuv4mpeg.o preferences.o rte_window.o gui.o ce_thumbs.o htmsocket.o
> merge.o dialogs.o saveplay.o audio.o events.o resample.o osc.o omc-learn.o
> callbacks.o colourspace.o keyboard.o utils.o multitrack.o stream.o
> cvirtual.o startup.o pangotext.o videodev.o jack.o pulse.o ldvgrab.o
> ldvcallbacks.o ldvinterface.o 

Bug#853520: lives: ftbfs with GCC-7

[Matthias Klose]

Package: src:lives
Version: 2.8.3-1
Severity: normal
Tags: sid buster
User: debian-...@lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/lives_2.8.3-1_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
callbacks.c:5975:15: warning: '*' in boolean context, suggest '&&' instead 
[-Wint-in-bool-context]
 if (height*width) {
 ~~^~
callbacks.c:6006:15: warning: '*' in boolean context, suggest '&&' instead 
[-Wint-in-bool-context]
   if (!(height*width)&_type!=LIVES_PREVIEW_TYPE_IMAGE_ONLY) {
~~~^~~
callbacks.c:6123:7: warning: 'gtk_alignment_get_type' is deprecated 
[-Wdeprecated-declarations]
   lives_alignment_set(LIVES_ALIGNMENT(mainw->fs_playalign),0.5,
   ^~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:251:0,
 from main.h:74,
 from callbacks.c:21:
/usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:77:12: note: declared here
 GType  gtk_alignment_get_type   (void) G_GNUC_CONST;
^~
callbacks.c: In function 'on_full_screen_activate':
callbacks.c:6716:33: warning: '*' in boolean context, suggest '&&' instead 
[-Wint-in-bool-context]
 if (!(mainw->vpp->fwidth*mainw->vpp->fheight)) {
  ~~~^
callbacks.c: In function 'on_double_size_activate':
callbacks.c:6903:29: warning: '*' in boolean context, suggest '&&' instead 
[-Wint-in-bool-context]
 } while (!(mainw->pwidth*mainw->pheight));
   ~~^~~~
callbacks.c: In function 'on_sepwin_activate':
callbacks.c:7088:35: warning: '*' in boolean context, suggest '&&' instead 
[-Wint-in-bool-context]
   if (!(mainw->vpp->fwidth*mainw->vpp->fheight)) {
~~~^
main.c: In function 'switch_to_file':
main.c:7105:19: warning: '*' in boolean context, suggest '&&' instead 
[-Wint-in-bool-context]
   if (old_file*new_file) mainw->preview_frame=0;
   ^
/bin/bash ../libtool  --tag=CC   --mode=link gcc -Wstrict-aliasing=0 -Wall 
-DHAVE_YUV4MPEG=1 -DHAVE_LDVGRAB=1 -I libavc1394/avc1394.h -I 
libraw1394/raw1394.h -I libraw1394/rom1394.h -DIS_LINUX_GNU=1  
-DENABLE_OSC=1  -I/usr/include/alsa -DALSA_MIDI=1 -I/usr/include/libpng16 
-DUSE_LIBPNG=1 -I/usr/include/x86_64-linux-gnu -I/usr/include/x86_64-linux-gnu 
-DUSE_SWSCALE=1 -DENABLE_JACK -DENABLE_JACK_TRANSPORT -lpulse 
-DHAVE_PULSE_AUDIO=1 -DENABLE_GIW=1 -DHAVE_UNICAP=1   
-DLIVES_LIBDIR=\""/usr/lib/x86_64-linux-gnu"\"  -DHAVE_WEBM=1  -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -lgtk-3 -lgdk-3 
-lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 
-lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread -shared  -Wl,-z,relro -o lives-exe 
widget-helper.o main.o support.o effects.o plugins.o effects-weed.o 
effects-data.o framedraw.o interface.o paramspecial.o paramwindow.o rfx-builde
 r.o lives-yuv4mpeg.o preferences.o rte_window.o gui.o ce_thumbs.o htmsocket.o 
merge.o dialogs.o saveplay.o audio.o events.o resample.o osc.o omc-learn.o 
callbacks.o colourspace.o keyboard.o utils.o multitrack.o stream.o cvirtual.o 
startup.o pangotext.o videodev.o jack.o pulse.o ldvgrab.o ldvcallbacks.o 
ldvinterface.o giw/giwknob.o giw/giwvslider.o giw/giwled.o giw/giwtimeline.o 
-lX11 -lmjpegutils ../libOSC/.libs/libOSC.a 
../libOSC/client/.libs/libOSC_client.a -lm -ljack -lavc1394 -lraw1394 -lrom1394 
-lasound -lpulse -lpng16 -lswscale -lavutil  
/<>/libweed/libweed_slice.la 
/<>/libweed/libweed-utils.la -lm  -lunicap -lrt -ldl 
libtool: link: gcc -Wstrict-aliasing=0 -Wall -DHAVE_YUV4MPEG=1 -DHAVE_LDVGRAB=1 
-I libavc1394/avc1394.h -I libraw1394/raw1394.h -I libraw1394/rom1394.h 
-DIS_LINUX_GNU=1 -DENABLE_OSC=1 -I/usr/include/alsa -DALSA_MIDI=1 
-I/usr/include/libpng16