Re: review ghostess
Hi, There is a new upstream version with manpage now. I tried to merge it, but I do get patches related messages when running git-buildpackage. The short howto on the multimedia wiki says resolve merge conflicts, review your changes e.g. with gitk How to check if there are conflicts and how to resolve those? When i use gitk I get a 'crappy' GUI with letters I can't read clearly... done dh_clean rm -f debian/stamp-autotools-files rm -f debian/cdbs-install-list debian/cdbs-package-list debian/stamp-copyright-check debian/stamp-buildinfo dpkg-source -i -I -b ghostess dpkg-source: info: using source format `3.0 (quilt)' dpkg-source: info: building ghostess using existing ./ghostess_20100905.orig.tar.bz2 patching file config.h.in Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file config.h.in.rej patching file Makefile.in Reversed (or previously applied) patch detected! Skipping patch. 15 out of 15 hunks ignored -- saving rejects to file Makefile.in.rej patching file configure.ac Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file configure.ac.rej patching file config.guess Reversed (or previously applied) patch detected! Skipping patch. 9 out of 9 hunks ignored -- saving rejects to file config.guess.rej patching file config.sub Reversed (or previously applied) patch detected! Skipping patch. 5 out of 5 hunks ignored -- saving rejects to file config.sub.rej patching file configure Reversed (or previously applied) patch detected! Skipping patch. 381 out of 381 hunks ignored -- saving rejects to file configure.rej patching file Makefile.am Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file Makefile.am.rej patching file aclocal.m4 Reversed (or previously applied) patch detected! Skipping patch. 22 out of 22 hunks ignored -- saving rejects to file aclocal.m4.rej patching file ChangeLog Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file ChangeLog.rej The next patch would create the file ghostess.1, which already exists! Skipping patch. 1 out of 1 hunk ignored patching file ltmain.sh Reversed (or previously applied) patch detected! Skipping patch. 8 out of 8 hunks ignored -- saving rejects to file ltmain.sh.rej patching file README Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file README.rej patching file src/ghostess.c Reversed (or previously applied) patch detected! Skipping patch. 3 out of 3 hunks ignored -- saving rejects to file src/ghostess.c.rej patching file src/Makefile.in Reversed (or previously applied) patch detected! Skipping patch. 2 out of 2 hunks ignored -- saving rejects to file src/Makefile.in.rej patching file src/gtkknob.h Reversed (or previously applied) patch detected! Skipping patch. 2 out of 2 hunks ignored -- saving rejects to file src/gtkknob.h.rej patching file src/universal_gui.c Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file src/universal_gui.c.rej patching file src/gtkknob.c Reversed (or previously applied) patch detected! Skipping patch. 20 out of 20 hunks ignored -- saving rejects to file src/gtkknob.c.rej dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/debian-changes-20100326-1/ ghostess.orig.J2_mCQ/debian/patches/debian-changes-20100326-1 gave error exit status 1 dpkg-buildpackage: error: dpkg-source -i -I -b ghostess gave error exit status 2 /usr/local/bin/gbp-pbuilder returned 2 Couldn't run '/usr/local/bin/gbp-pbuilder' ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: review ghostess
On Wed, Aug 25, 2010 at 10:29:00PM +0200, rosea grammostola wrote: As a not very experienced packager, I've added ghostess http://git.debian.org/git/pkg-multimedia/ghostess.git/ Comments are welcome. A more useful URL than above is that of the Git browser for the project: http://git.debian.org/?p=pkg-multimedia/ghostess.git I see that you use CDBS. Nice! :-D Then I suggest to use auto-resolving of build-dependencies (currently they are not quite optimal): 1) copy debian/control to debian/control.in 2) edit debian/control.in replacing cdbs build-dpendency with @cdbs@ 3) invoke the following command to regenerate debian/control: DEB_MAINTAINER_MODE=1 fakeroot debian/rules clean 4) Check what changed in the now auto-updated debian/control 5) Remove manual entries from debian/control.in now auto-resolved 6) Repeat steps 3-5 until satisfied 6) Commit debian/control.in 7) Commit debian/control (separately!) I also suggest to enable tracking of copyright/licensing changes: 1) Include /usr/share/cdbs/1/rules/utils.mk 2) touch debian/copyright_hints 3) Invoke the following to generate debian/copyright_newhints: DEB_MAINTAINER_MODE=1 debian/rules pre-build 4) Rename debian/copyright_newhints to debian/copyright_hints 5) Commit debian/copyright_hints After that, at each build the source is scanned for copyright and licensing hints, and changes compared to the saved hints file trigger a warning (or a failure if DEB_MAINTAINER_MODE=1). I also suggest you enable upstream-tarball handling - i.e. a get-orig-source build target: 1) Include /usr/share/cdbs/1/rules/upstream-tarball.mk 2) Add hints to get upstream source (have a look inside the actual upstream-tarball.mk file, or look at e.g. jackd2 for an example) Kind regards, - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: review ghostess
26.08.2010 15:38, Jonas Smedegaard wrote: Then I suggest to use auto-resolving of build-dependencies (currently they are not quite optimal): 1) copy debian/control to debian/control.in 2) edit debian/control.in replacing cdbs build-dpendency with @cdbs@ 3) invoke the following command to regenerate debian/control: Eww!!! I didn't know CDBS even had debian/control.in functionality, but now that I know, it makes me like it even less... ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: review ghostess
On Thu, Aug 26, 2010 at 03:44:06PM +0700, Maia Kozheva wrote: 26.08.2010 15:38, Jonas Smedegaard wrote: Then I suggest to use auto-resolving of build-dependencies (currently they are not quite optimal): 1) copy debian/control to debian/control.in 2) edit debian/control.in replacing cdbs build-dpendency with @cdbs@ 3) invoke the following command to regenerate debian/control: Eww!!! I didn't know CDBS even had debian/control.in functionality, but now that I know, it makes me like it even less... Please elaborate. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: review ghostess
On Thu, Aug 26, 2010 at 10:03 AM, Alessio Treglia ales...@debian.orgwrote: I've fixed some packaging stuff. I can sponsor your uploads, if you like. That would be nice. Thanks in advance. \r ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: review ghostess
I see that you use CDBS. Nice! :-D Then I suggest to use auto-resolving of build-dependencies (currently they are not quite optimal): 1) copy debian/control to debian/control.in 2) edit debian/control.in replacing cdbs build-dpendency with @cdbs@ 3) invoke the following command to regenerate debian/control: DEB_MAINTAINER_MODE=1 fakeroot debian/rules clean 4) Check what changed in the now auto-updated debian/control 5) Remove manual entries from debian/control.in now auto-resolved I don't understand this step. Also it's not always clear when I should do a step or when CDBS is doing it for me... I tried to play with it, not sure if I get it for 100% though. 6) Repeat steps 3-5 until satisfied 6) Commit debian/control.in 7) Commit debian/control (separately!) I also suggest to enable tracking of copyright/licensing changes: 1) Include /usr/share/cdbs/1/rules/utils.mk 2) touch debian/copyright_hints 3) Invoke the following to generate debian/copyright_newhints: DEB_MAINTAINER_MODE=1 debian/rules pre-build 4) Rename debian/copyright_newhints to debian/copyright_hints 5) Commit debian/copyright_hints After that, at each build the source is scanned for copyright and licensing hints, and changes compared to the saved hints file trigger a warning (or a failure if DEB_MAINTAINER_MODE=1). I did this step. I also suggest you enable upstream-tarball handling - i.e. a get-orig-source build target: 1) Include /usr/share/cdbs/1/rules/upstream-tarball.mk 2) Add hints to get upstream source (have a look inside the actual upstream-tarball.mk file, or look at e.g. jackd2 for an example) I skipped this one. To keep it a bit simple for me atm. I've asked the upstream author to provide a manpage and desktop file. Regards, \r ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: review ghostess
*cough* just to say: an alternative choice to CDBS is called Debhelper 7 *cough* :) It doesn't make any difference to me if you prefer using CDBS or DH, I'll review and upload the package anyway. -- Alessio Treglia ales...@alessiotreglia.com Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
