Re: Bug#565860: still exists in 0.4.4-2
On Sun, Jan 24, 2010 at 2:09 PM, Adrian Knoth wrote: > That's what I do for jackd: > > libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386] > Thanks. -- Alessio Treglia Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Sun, Jan 24, 2010 at 01:58:08PM +0100, Alessio Treglia wrote: > >> Couldn't you just change the Build-Depends from "libasound2-dev" to > >> "libasound2-dev [linux-any]"? > >> > > > > +1 > > > > Seems the right way. > ...but it doesn't work on my amd64 chroot, the build fails due to unmet deps. > Should I set libasound2-dev [!kfreebsd-amd64 !kfreebsd-i386] instead > of libasound2-dev [linux-any]? That's what I do for jackd: libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386] HTH -- mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Wed, Jan 20, 2010 at 10:31 AM, Alessio Treglia wrote: > On Wed, Jan 20, 2010 at 10:26 AM, Fabian Greffrath > wrote: >> Couldn't you just change the Build-Depends from "libasound2-dev" to >> "libasound2-dev [linux-any]"? >> > > +1 > > Seems the right way. > ...but it doesn't work on my amd64 chroot, the build fails due to unmet deps. Should I set libasound2-dev [!kfreebsd-amd64 !kfreebsd-i386] instead of libasound2-dev [linux-any]? -- Alessio Treglia Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#565860: still exists in 0.4.4-2
On Wed, Jan 20, 2010 at 10:53:06AM +0100, Fabian Greffrath wrote:
>> The patch was against configure.ac. I don't know if the minimal
>> debian/rules is sufficient to re-generate configure after applying this
>> patch.
>> If need be, add a line like "autoreconf -f" somewhere before calling
>> configure.
> Personally, instead of running autoreconf (or similar) during build, I'd
> prefer a patch that contains all the changes to configure caused by the
> changes to configure.ac. This way the package stays idempotent, i.e. it
I've also considered this. Find patch attached.
Note that both versions of the patch can be dropped after the next
upstream release.
Cheerio
--
mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver
--- configure 2010-01-16 20:38:40.0 +0100
+++ configure.new 2010-01-20 11:11:09.0 +0100
@@ -4321,6 +4321,8 @@
# Check for SSE optimization.
if test "x$ac_sse" = "xyes"; then
ac_sse_cflags="-msse -mfpmath=sse -ffast-math"
+ CFLAGS_OLD="$CFLAGS"
+ CPPFLAGS_OLD="$CPPFLAGS"
CFLAGS="$ac_sse_cflags $CFLAGS"
CPPFLAGS="$ac_sse_cflags $CPPFLAGS"
{ $as_echo "$as_me:$LINENO: checking for SSE optimization" >&5
@@ -4400,6 +4402,9 @@
ac_sse=$ac_cv_sse
if test "x$ac_sse" = "xyes"; then
ac_cflags="$ac_sse_cflags $ac_cflags"
+ else
+ CFLAGS="$CFLAGS_OLD"
+ CPPFLAGS="$CPPFLAGS_OLD"
fi
fi
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
Am 20.01.2010 11:23, schrieb Reinhard Tartler: 11:20 I used to prefer to ship patches against configure and Makefile.in's, but as time passes by, I changed my mind 11:20 debian's maintenance on autofoo tools has improved dramatically, IME Funny coincidence. :) Idempotency is preserved if the clean target removes all intermediate files. Yes, the maintenance effort of keeping up with the list of files to be removed should be about the same as refreshing a patch, I admit. The price for this is the build dependency on autotools-dev and relying on working autotools packages. I think we can afford both, but YMMV. It's not that I don't trust the autofoo Debian packages. It's just that I think "why repeat the same steps again and again on every buildd if you already know the results and can apply them a priori?". Cheers, Fabian -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49 (0)234 / 32-26334 Fax: +49 (0)234 / 32-14227 E-Mail: greffr...@leat.ruhr-uni-bochum.de ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Mi, Jan 20, 2010 at 10:53:06 (CET), Fabian Greffrath wrote: > Am 19.01.2010 18:33, schrieb Adrian Knoth: >> The patch was against configure.ac. I don't know if the minimal >> debian/rules is sufficient to re-generate configure after applying this >> patch. >> If need be, add a line like "autoreconf -f" somewhere before calling >> configure. > > Personally, instead of running autoreconf (or similar) during build, I'd > prefer a patch that contains all the changes to configure caused by the > changes to configure.ac. 11:20 I used to prefer to ship patches against configure and Makefile.in's, but as time passes by, I changed my mind 11:20 debian's maintenance on autofoo tools has improved dramatically, IME > This way the package stays idempotent, i.e. it makes no difference if > you build it once or twice from the same source and after running > "debian/rules clean" everything is back in its initial state. Idempotency is preserved if the clean target removes all intermediate files. The price for this is the build dependency on autotools-dev and relying on working autotools packages. I think we can afford both, but YMMV. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
Am 19.01.2010 18:33, schrieb Adrian Knoth: The patch was against configure.ac. I don't know if the minimal debian/rules is sufficient to re-generate configure after applying this patch. If need be, add a line like "autoreconf -f" somewhere before calling configure. Personally, instead of running autoreconf (or similar) during build, I'd prefer a patch that contains all the changes to configure caused by the changes to configure.ac. This way the package stays idempotent, i.e. it makes no difference if you build it once or twice from the same source and after running "debian/rules clean" everything is back in its initial state. Fabian -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49 (0)234 / 32-26334 Fax: +49 (0)234 / 32-14227 E-Mail: greffr...@leat.ruhr-uni-bochum.de ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Wed, Jan 20, 2010 at 10:26 AM, Fabian Greffrath wrote: > Couldn't you just change the Build-Depends from "libasound2-dev" to > "libasound2-dev [linux-any]"? > +1 Seems the right way. -- Alessio Treglia Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Mi, Jan 20, 2010 at 10:12:54 (CET), Adrian Knoth wrote: > On Tue, Jan 19, 2010 at 09:02:21PM +0100, Alessio Treglia wrote: > > Hi! > >> I've already attached the correct patch (and pushed git repository). > > I've cloned the repository, and it works nicely on sparc. > > Looks like it's safe to upload. > > Just a last remark: I've seen build-errors for kfreebsd. Though I > haven't looked closer, it could be the missing alsa-seq interface. > (freebsd kernels don't have ALSA). > > You might need to disable the alsa-seq support on these platforms, but > it's probably OK to wait for the FTBFS, first. ;) I'd rather disable alsa-seq right now to avoid unnecessary build cycles on slower buildds. Your explanation makes pretty much sense. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
Am 20.01.2010 10:12, schrieb Adrian Knoth: Just a last remark: I've seen build-errors for kfreebsd. Though I haven't looked closer, it could be the missing alsa-seq interface. (freebsd kernels don't have ALSA). You might need to disable the alsa-seq support on these platforms, but it's probably OK to wait for the FTBFS, first. ;) Couldn't you just change the Build-Depends from "libasound2-dev" to "libasound2-dev [linux-any]"? -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49 (0)234 / 32-26334 Fax: +49 (0)234 / 32-14227 E-Mail: greffr...@leat.ruhr-uni-bochum.de ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Tue, Jan 19, 2010 at 09:02:21PM +0100, Alessio Treglia wrote: Hi! > I've already attached the correct patch (and pushed git repository). I've cloned the repository, and it works nicely on sparc. Looks like it's safe to upload. Just a last remark: I've seen build-errors for kfreebsd. Though I haven't looked closer, it could be the missing alsa-seq interface. (freebsd kernels don't have ALSA). You might need to disable the alsa-seq support on these platforms, but it's probably OK to wait for the FTBFS, first. ;) HTH -- mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Tue, Jan 19, 2010 at 8:35 PM, Reinhard Tartler wrote: > > I think you might want to call autoreconf as 'autoreconf -i -f'. > I've already attached the correct patch (and pushed git repository). Now that bug should be fixed. -- Alessio Treglia Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#565860: still exists in 0.4.4-2
On Di, Jan 19, 2010 at 19:48:51 (CET), Alessio Treglia wrote: > --- a/debian/rules > +++ b/debian/rules > @@ -1,4 +1,8 @@ > #!/usr/bin/make -f > > +override_dh_auto_configure: > + autoreconf > + dh_auto_configure -f > + > %: I think you might want to call autoreconf as 'autoreconf -i -f'. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#565860: still exists in 0.4.4-2
> I've prepared the attached patch, That's the right one. -- Alessio Treglia Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 --- a/debian/control +++ b/debian/control @@ -6,7 +6,7 @@ Uploaders: Free Ekanayaka , Gürkan Sengün , Alessio Treglia DM-Upload-Allowed: yes -Build-Depends: debhelper (>= 7), +Build-Depends: debhelper (>= 7.0.50~), libqt4-dev, libtool, automake, --- a/debian/rules +++ b/debian/rules @@ -1,4 +1,8 @@ #!/usr/bin/make -f +override_dh_auto_configure: + autoreconf -f + dh_auto_configure + %: dh --with quilt $@ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#565860: still exists in 0.4.4-2
Hello, Adrian, you're right, the minimal rules is not enought. I've prepared the attached patch, what do you think about it? Could it be the right solution? -- Alessio Treglia Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 --- a/debian/control +++ b/debian/control @@ -6,7 +6,7 @@ Uploaders: Free Ekanayaka , Gürkan Sengün , Alessio Treglia DM-Upload-Allowed: yes -Build-Depends: debhelper (>= 7), +Build-Depends: debhelper (>= 7.0.50~), libqt4-dev, libtool, automake, --- a/debian/rules +++ b/debian/rules @@ -1,4 +1,8 @@ #!/usr/bin/make -f +override_dh_auto_configure: + autoreconf + dh_auto_configure -f + %: dh --with quilt $@ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#565860: still exists in 0.4.4-2
On Tue, Jan 19, 2010 at 09:10:33AM -0700, dann frazier wrote: Hi, especially Alessio! > This issue persists with 0.4.4-2. The patch was against configure.ac. I don't know if the minimal debian/rules is sufficient to re-generate configure after applying this patch. If need be, add a line like "autoreconf -f" somewhere before calling configure. The above is all wrong if configure already gets regenerated by quilt. HTH -- mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#565860: still exists in 0.4.4-2
reopen 0.4.4-2 found 565860 0.4.4-2 thanks This issue persists with 0.4.4-2. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
