Bug#580113: [mplayer] No audio output to pulse
On Fri, May 07, 2010 at 22:45:51 (CEST), Adam wrote: Reinhard Tartler wrote: On Wed, May 05, 2010 at 14:53:29 (CEST), Adam wrote: I had the volume set in ~/.mplayer/config. If I uncomment the line (volume=25) pulseaudio works again. With this information ist should be reproducible by anybody: mplayer -ao pulse -volume 25 [file] fails again. That's a very useful testcase, thanks for this piece of information! So you can reproduce it now? Not really, but from looking at the source, I can now understand why it crashes. No, please don't start with vanilla mplayer, but make sure that you use the source provided from the debian package. As the second patch doesn't apply against the debian source, this doesn't seem to be an option. Am I missing something? I remember that I did apply at least one ao_pulse related patch to the rc3 branch, but I obviously didn't backport all patches. I need to take a closer look at the issue, and am sure that one of the two attached patches should fix the issue. It might need some massaging to apply, though, because not all whitespace fixes have been backported. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#580113: [mplayer] No audio output to pulse
Reinhard Tartler wrote: On Wed, May 05, 2010 at 14:53:29 (CEST), Adam wrote: I had the volume set in ~/.mplayer/config. If I uncomment the line (volume=25) pulseaudio works again. With this information ist should be reproducible by anybody: mplayer -ao pulse -volume 25 [file] fails again. That's a very useful testcase, thanks for this piece of information! So you can reproduce it now? Reinhard Tartler wrote: Can anyone who is affected by this please test these patches against mplayer? I'm pretty confident that they should fix the symptom. If still needed, I will do so the latest this weekend. What is the best way to do so? Building vanilla mplayer for both r30059 and r30061 then verify that only the later doesn't have the problem? No, please don't start with vanilla mplayer, but make sure that you use the source provided from the debian package. As the second patch doesn't apply against the debian source, this doesn't seem to be an option. Am I missing something? --Adam signature.asc Description: PGP signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#580113: [mplayer] No audio output to pulse
I had the volume set in ~/.mplayer/config. If I uncomment the line (volume=25) pulseaudio works again. With this information ist should be reproducible by anybody: mplayer -ao pulse -volume 25 [file] fails again. Reinhard Tartler wrote: Can anyone who is affected by this please test these patches against mplayer? I'm pretty confident that they should fix the symptom. If still needed, I will do so the latest this weekend. What is the best way to do so? Building vanilla mplayer for both r30059 and r30061 then verify that only the later doesn't have the problem? --Adam signature.asc Description: PGP signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#580113: [mplayer] No audio output to pulse
On Wed, May 05, 2010 at 14:53:29 (CEST), Adam wrote: I had the volume set in ~/.mplayer/config. If I uncomment the line (volume=25) pulseaudio works again. With this information ist should be reproducible by anybody: mplayer -ao pulse -volume 25 [file] fails again. That's a very useful testcase, thanks for this piece of information! Reinhard Tartler wrote: Can anyone who is affected by this please test these patches against mplayer? I'm pretty confident that they should fix the symptom. If still needed, I will do so the latest this weekend. What is the best way to do so? Building vanilla mplayer for both r30059 and r30061 then verify that only the later doesn't have the problem? No, please don't start with vanilla mplayer, but make sure that you use the source provided from the debian package. It was not taken from the trunk branch, but from 'branches/1.0rc3'. (or if you insist, make sure that you take the correct svn branch). The patches I've pasted are taken from trunk. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#580113: [mplayer] No audio output to pulse
I am having the same problem since the upgrade to 2:1.0~rc3+svn20100502 (see output[2] of mplayer). Output of `reportbug --template mplayer` included[1]. --Adam [1] $ reportbug --template mplayer [...] Package: mplayer Version: 2:1.0~rc3+svn20100502-1 Severity: wishlist -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: powerpc (ppc) Kernel: Linux 2.6.32-3-powerpc Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages mplayer depends on: ii libaa1 1.4p5-38 ascii art library ii libartsc0 1.5.9-3+b1 aRts sound system C support librar ii libasound2 1.0.22-2 shared library for ALSA applicatio ii libaudio2 1.9.2-3 Network Audio System - shared libr ii libavcodec524:0.5.1-3ffmpeg codec library ii libavformat52 4:0.5.1-3ffmpeg file format library ii libavutil49 4:0.5.1-3ffmpeg utility library ii libc6 2.10.2-7 Embedded GNU C Library: Shared lib ii libcaca00.99.beta17-1colour ASCII art library ii libcdparanoia0 3.10.2+debian-9 audio extraction tool for sampling ii libdirectfb-1.2-9 1.2.10.0-3 direct frame buffer graphics - sha ii libdvdread4 4.1.3-9 library for reading DVDs ii libenca01.13-1 Extremely Naive Charset Analyser - ii libesd0 0.2.41-7 Enlightened Sound Daemon - Shared ii libfontconfig1 2.8.0-2.1generic font configuration library ii libfreetype62.3.11-1 FreeType 2 font engine, shared lib ii libgcc1 1:4.4.4-1GCC support library ii libgif4 4.1.6-9 library for GIF images (library) ii libgl1-mesa-glx [libgl1 7.7.1-1 A free implementation of the OpenG ii libjack01.9.5~dfsg-4 JACK Audio Connection Kit (librari ii libjpeg62 6b-16.1 The Independent JPEG Group's JPEG ii liblircclient0 0.8.3-5 infra-red remote control support - ii liblzo2-2 2.03-2 data compression library ii libncurses5 5.7+20100313-2 shared libraries for terminal hand ii libogg0 1.2.0~dfsg-1 Ogg bitstream library ii libopenal1 1:1.11.753-1 Software implementation of the Ope ii libpng12-0 1.2.43-1 PNG library - runtime ii libpostproc51 4:0.5.1-3ffmpeg video postprocessing librar ii libpulse0 0.9.21-1.2 PulseAudio client libraries ii libsdl1.2debian 1.2.14-6 Simple DirectMedia Layer ii libsmbclient2:3.4.7~dfsg-2 shared library for communication w ii libspeex1 1.2~rc1-1The Speex codec runtime library ii libstdc++6 4.4.4-1 The GNU Standard C++ Library v3 ii libswscale0 4:0.5.1-3ffmpeg video scaling library ii libtheora0 1.1.1+dfsg.1-3 The Theora Video Compression Codec ii libx11-62:1.3.3-3X11 client-side library ii libxext62:1.1.1-3X11 miscellaneous extension librar ii libxinerama12:1.1-3 X11 Xinerama extension library ii libxt6 1:1.0.7-1X11 toolkit intrinsics library ii libxv1 2:1.0.5-1X11 Video extension library ii libxvmc12:1.0.5-1X11 Video extension library ii libxxf86dga12:1.1.1-2X11 Direct Graphics Access extensi ii libxxf86vm1 1:1.1.0-2X11 XFree86 video mode extension l ii zlib1g 1:1.2.3.4.dfsg-3 compression library - runtime mplayer recommends no packages. Versions of packages mplayer suggests: ii bzip2 1.0.5-4high-quality block-sorting file co ii fontconfig2.8.0-2.1 generic font configuration library pn mplayer-doc none (no description available) pn netselect | fping none (no description available) ii ttf-freefont 20090104-6 Freefont Serif, Sans and Mono True -- debconf information: mplayer/voutput: autodetect mplayer/rtc: false mplayer/ttfont: Sans mplayer/cfgnote: mplayer/replace-existing-files-bail: mplayer/replace-existing-files: false mplayer/no-ttfont: mplayer/install_codecs: mplayer/dvd_device: /dev/cdrom [...] [2] $ mplayer -msglevel ao=9 -ao pulse recording-tatort.ts Cannot connect to server socket err = No such file or directory Cannot connect to server socket jack server is not running or cannot be started Cannot connect to server socket err = No such file or directory Cannot connect to
Bug#580113: [mplayer] No audio output to pulse
On Tue, May 04, 2010 at 08:40:58 (CEST), Adam wrote:
AO: [pulse] 48000Hz 2ch s16be (2 bytes per sample)
Assertion 'channels 0' failed at pulse/volume.c:76, function
pa_cvolume_set(). Aborting.
This assertion doesn't look like it comes from mplayer, but rather from
libpulse. In fact, after having a quick look in the source, the
assertion triggered is in this function from the pulseaudio source:
,
| pa_cvolume* pa_cvolume_set(pa_cvolume *a, unsigned channels, pa_volume_t v) {
| int i;
|
| pa_assert(a);
| pa_assert(channels 0);
| pa_assert(channels = PA_CHANNELS_MAX);
|
| a-channels = (uint8_t) channels;
|
| for (i = 0; i a-channels; i++)
| a-values[i] = v;
|
| return a;
| }
`
okay, after having had a quick look at the mplayer source, it seems that
there are some upstream patches that should be considered for
backporting:
r30060 | reimar | 2009-12-18 21:22:39 +0100 (Fri, 18 Dec 2009) | 2 lines
Get rid of global volume variable, it is only used for temporary values.
Index: ao_pulse.c
===
--- ao_pulse.c (revision 29160)
+++ ao_pulse.c (revision 30060)
@@ -49,9 +49,6 @@
/** Main event loop object */
static struct pa_threaded_mainloop *mainloop;
-/** A temporary variable to store the current volume */
-static pa_cvolume volume;
-
static int broken_pause;
LIBAO_EXTERN(pulse)
@@ -144,6 +141,7 @@
char *host = NULL;
char *sink = NULL;
char *version = pa_get_library_version();
+struct pa_cvolume volume;
if (ao_subdevice) {
devarg = strdup(ao_subdevice);
@@ -350,13 +348,14 @@
* pa_context_get_sink_input_info() operation completes. Saves the
* volume field of the specified structure to the global variable volume. */
static void info_func(struct pa_context *c, const struct pa_sink_input_info
*i, int is_last, void *userdata) {
+struct pa_cvolume *volume = userdata;
if (is_last 0) {
GENERIC_ERR_MSG(context, Failed to get sink input info);
return;
}
if (!i)
return;
-volume = i-volume;
+*volume = i-volume;
pa_threaded_mainloop_signal(mainloop, 0);
}
@@ -365,8 +364,9 @@
case AOCONTROL_GET_VOLUME: {
ao_control_vol_t *vol = arg;
uint32_t devidx = pa_stream_get_index(stream);
+struct pa_cvolume volume;
pa_threaded_mainloop_lock(mainloop);
-if (!waitop(pa_context_get_sink_input_info(context, devidx,
info_func, NULL))) {
+if (!waitop(pa_context_get_sink_input_info(context, devidx,
info_func, volume))) {
GENERIC_ERR_MSG(context, pa_stream_get_sink_input_info()
failed);
return CONTROL_ERROR;
}
@@ -384,7 +384,9 @@
case AOCONTROL_SET_VOLUME: {
const ao_control_vol_t *vol = arg;
pa_operation *o;
+struct pa_cvolume volume;
+pa_cvolume_reset(volume, ao_data.channels);
if (volume.channels != 2)
pa_cvolume_set(volume, volume.channels,
(pa_volume_t)vol-left*PA_VOLUME_NORM/100);
else {
r30061 | reimar | 2009-12-18 21:26:28 +0100 (Fri, 18 Dec 2009) | 4 lines
Allow pulseaudio to restore the previous volume on init instead of forcing to
full volume.
The old behaviour can be restored by using -volume 100.
Index: ao_pulse.c
===
--- ao_pulse.c (revision 30060)
+++ ao_pulse.c (revision 30061)
@@ -141,7 +141,6 @@
char *host = NULL;
char *sink = NULL;
char *version = pa_get_library_version();
-struct pa_cvolume volume;
if (ao_subdevice) {
devarg = strdup(ao_subdevice);
@@ -187,8 +186,6 @@
pa_channel_map_init_auto(map, ss.channels, PA_CHANNEL_MAP_ALSA);
ao_data.bps = pa_bytes_per_second(ss);
-pa_cvolume_reset(volume, ss.channels);
-
if (!(mainloop = pa_threaded_mainloop_new())) {
mp_msg(MSGT_AO, MSGL_ERR, AO: [pulse] Failed to allocate main
loop\n);
goto fail;
@@ -222,7 +219,7 @@
pa_stream_set_write_callback(stream, stream_request_cb, NULL);
pa_stream_set_latency_update_callback(stream, stream_latency_update_cb,
NULL);
-if (pa_stream_connect_playback(stream, sink, NULL,
PA_STREAM_INTERPOLATE_TIMING|PA_STREAM_AUTO_TIMING_UPDATE, volume, NULL) 0)
+if (pa_stream_connect_playback(stream, sink, NULL,
PA_STREAM_INTERPOLATE_TIMING|PA_STREAM_AUTO_TIMING_UPDATE, NULL, NULL) 0)
goto unlock_and_fail;
/* Wait until the stream is ready */
Can anyone who is affected by this please test these patches against
mplayer? I'm pretty confident that they should fix the symptom.
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
Bug#580113: [mplayer] No audio output to pulse
tags 580113 unreproducible severity 580113 important thanks I too am not able to reproduce this problem. I have no issue using pulse as the audio output driver with latest mplayer. Setting this bug to important as well since more than one user was not able to reproduce the bug, and also since this issue, although it is a major issue if the bug indeed exists, does not make mplayer useless. There is more than one audio output driver that mplayer supports. If you have reportbug installed, please post the output of 'reportbug --template mplayer'. On Monday 03 May 2010 14:30:22 Alexander Hofbauer wrote: Any chance to check with other PA-enabled clients to verify our PA installation? (like vlc with the pulseaudio modules) Just tried vlc with vlc-plugin-pulse: --- pulse audio output: No. of Audio Channels: 2 pulse audio output debug: Pulse mainloop started pulse audio output debug: Pulse stream connected pulse audio output debug: Pulse initialized successfully pulse audio output debug: Buffer metrics: maxlength=141120, tlength=42336, prebuf=35280, minreq=7056 pulse audio output debug: Using sample spec 'float32le 2ch 44100Hz', channel map 'front-left,front-right'. pulse audio output debug: Connected to device alsa_output.pci-_00_1b.0.analog-stereo (0, not suspended). main audio output debug: using audio output module pulse pulse audio output debug: Pulse stream started --- I think this means that pulseaudio is working correctly here. -- Regards, Andres Mejia ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Processed: Re: Bug#580113: [mplayer] No audio output to pulse
Processing commands for cont...@bugs.debian.org: tags 580113 unreproducible Bug #580113 [mplayer] [mplayer] No audio output to pulse Added tag(s) unreproducible. severity 580113 important Bug #580113 [mplayer] [mplayer] No audio output to pulse Severity set to 'important' from 'serious' thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
