Bug#587898: Bug#587904: error message should say what to try next if codec not found
Am 02.07.2010 17:50, schrieb jida...@jidanni.org: So they spread the word forget ffmpeg. There is a reason for everything and there is even documentation for (nearly) everything. People who keep themselves informed should know about both and not render premature justice. So that's why your patch should at least say ***Probable causes:... There's only a small chance that the user will be nurd enough to dig out the README files and figure out what they mean. Come on... There's a much bigger chance that they will spread the word ffmpeg is busted. Skip it. So it appears your version is doing more harm than good in the world, maybe. Really, come on... Therefore in order to not damage ffmpeg's reputation, there should be a runtime ***Probable causes:... that tells the user all hope is not lost because they can simply install this other package as hinted to in the readme file... I'd say no for two reasons: First, ffmpeg itself is just more or less another random frontend to libavcodec. Consider how many packages use ffmpeg and are thus unable to convert to MP3 in Debian, e.g. vlc and the whole gstreamer framework including its multitude of frontends. Should we add a Probable cause error message to all of them? I don't think so. Calling the codec by name in the ffmpeg error message should be sufficient to motivate users to digg into documentation. Reading README isn't really considered an act of awesomeness in Debian. Second, what does Probable cause mean. The probable cause for a missing MP3 encoder is the fact that ffmpeg in Debian isn't built against libmp3lame. But again, that's easy to find out via the documentation shipped in this very package. I hope you don't want us to start a discussion about the legality to ship certain combinations of software in an error message? All I know is you mentioned it in the readme, so you can have the error message mention to see the readme at least. Yes, but we mention it in the README only to distance ourselves from this repository. Pointing to the README from the error message might be considered, but again, please see above. OK, I made https://roundup.ffmpeg.org/msg11039 https://roundup.ffmpeg.org/msg11041 Great, thanks! - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
OK, but still maybe the package Description shouldn't be as upbeat as it currently is. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
Am 05.07.2010 13:35, schrieb jida...@jidanni.org: Just say This version of ffmpeg is NOT compiled against ... or This package differs from the default compilation in that ... There is no such thing like a default compilation but anyway, the package descriptions could be improved to reflect the fact that we skip certain encoders. Reinhard, what do you say? ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
On Mon, Jul 05, 2010 at 08:14:26 (EDT), Fabian Greffrath wrote: Am 05.07.2010 13:35, schrieb jida...@jidanni.org: Just say This version of ffmpeg is NOT compiled against ... or This package differs from the default compilation in that ... There is no such thing like a default compilation but anyway, the package descriptions could be improved to reflect the fact that we skip certain encoders. Reinhard, what do you say? and moreover, lame has always been an optional feature of ffmpeg. since there is no lame in debian, why is it noteworthy that ffmpeg has not been compiled against a package that is not even available in debian? the right fix is to get lame accepted into debian. moreover, jidanni didn't provide a proper patch. The wording 'compiled against' doesn't fit the problem. Having said this, I do think that the description could and probably should be improved. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
Having said this, I do think that the description could and probably should be improved. Word. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
[Dammit, this didn't go to the bug and submitter by accident.] Am 02.07.2010 15:34, schrieb jida...@jidanni.org: The reason may be documented in /usr/share/doc/ffmpeg/README.Debian.gz but it is very hard to tell. I fail to see what is difficult to understand in this sentence from README.Debian: I did not activate MP3 encoding (through LAME) in libavcodec [...] However, I agree that the error message Encoder (codec id 86017) not found for output stream #0.0 should be improved to at least call the encoder by name. OK, probably the message should be **codec disabled for legal reasons by Debian. Try putting debian-multimedia... on top of your /etc/apt/sources.list... and do apt-get update, then reinstall their version of this package** We have very good reasons to never ever recommend using packages from this repository. Furthermore, the MP3 encoder has never been actively *disabled* in Debian. ffmpeg is simply not built against LAME, because this is not available in Debian at all. P.S., does this really turn 8 kb/s into 64 kb/s? Is that a good thing to do? Well I tried -ab 8k and found out that the Stream #0.1: Audio: mp3, 22050 Hz, 2 channels, s16, 8 kb/s must be wrong. ffprobe gives the same wrong answer. This is a completely different issue and should get its own bug report. P.S.S., the man page, -ac channels Set the number of audio channels (default = 1). is wrong. As you see above two channels were the output, even without this option. If it just extracts the mp3 then it should say so in several of the affected places on the man page. dito. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
Am 02.07.2010 15:59, schrieb Fabian Greffrath:
However, I agree that the error message
Encoder (codec id 86017) not found for output stream #0.0
should be improved to at least call the encoder by name.
Which will be done by the attached patch. Would you please try it out?
- Fabian
diff --git a/ffmpeg.c b/ffmpeg.c
index 6b9380f..e83e1a5 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -2133,8 +2133,8 @@ static int av_transcode(AVFormatContext **output_files,
if (!codec)
codec = avcodec_find_encoder(ost-st-codec-codec_id);
if (!codec) {
-snprintf(error, sizeof(error), Encoder (codec id %d) not found for output stream #%d.%d,
- ost-st-codec-codec_id, ost-file_index, ost-index);
+snprintf(error, sizeof(error), Encoder (codec name %s) not found for output stream #%d.%d,
+ ost-st-codec-codec_name, ost-file_index, ost-index);
ret = AVERROR(EINVAL);
goto dump_format;
}
@@ -2156,8 +2156,8 @@ static int av_transcode(AVFormatContext **output_files,
if (!codec)
codec = avcodec_find_decoder(ist-st-codec-codec_id);
if (!codec) {
-snprintf(error, sizeof(error), Decoder (codec id %d) not found for input stream #%d.%d,
-ist-st-codec-codec_id, ist-file_index, ist-index);
+snprintf(error, sizeof(error), Decoder (codec name %s) not found for input stream #%d.%d,
+ist-st-codec-codec_name, ist-file_index, ist-index);
ret = AVERROR(EINVAL);
goto dump_format;
}
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#587898: Bug#587904: error message should say what to try next if codec not found
All I know is it seems to the average user that ffmpeg can't even make .mp3s, a rather common format. So they spread the word forget ffmpeg. So that's why your patch should at least say ***Probable causes:... There's only a small chance that the user will be nurd enough to dig out the README files and figure out what they mean. There's a much bigger chance that they will spread the word ffmpeg is busted. Skip it. So it appears your version is doing more harm than good in the world, maybe. Therefore in order to not damage ffmpeg's reputation, there should be a runtime ***Probable causes:... that tells the user all hope is not lost because they can simply install this other package as hinted to in the readme file... FG We have very good reasons to never ever recommend using packages from FG this repository. Furthermore, the MP3 encoder has never been actively FG *disabled* in Debian. ffmpeg is simply not built against LAME, because FG this is not available in Debian at all. All I know is you mentioned it in the readme, so you can have the error message mention to see the readme at least. FG This is a completely different issue and should get its own bug report. OK, I made https://roundup.ffmpeg.org/msg11039 https://roundup.ffmpeg.org/msg11041 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
