Your message dated Tue, 03 May 2011 10:48:19 +0000
with message-id <e1qhd9p-0004bo...@franck.debian.org>
and subject line Bug#625282: fixed in jack-keyboard 2.5-3
has caused the Debian Bug report #625282,
regarding jack-keyboard: Pianola mode (MIDI-in) broken wrt channel numbers
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
625282: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625282
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: jack-keyboard
Version: 2.5-2
Severity: normal
Tags: patch
Per the manual page, jack-keyboard should pass through incoming MIDI
messages but replace the channel number with its own. It only recognizes
incoming messages sent on MIDI channel 0 however, and does not rewrite
the channel at all.
-- System Information:
Debian Release: squeeze/sid
APT prefers lucid-updates
APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500,
'lucid-proposed'), (500, 'lucid-backports'), (500, 'lucid')
Architecture: i386 (i686)
Kernel: Linux 2.6.31-11-rt (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages jack-keyboard depends on:
ii jackd 5danmppa1~lucid1 JACK Audio Connection Kit (default
ii libc6 2.11.1-0ubuntu7.8 Embedded GNU C Library: Shared lib
ii libgli 2.24.1-0ubuntu1 The GLib library of C routines
ii libgtk 2.20.1-0ubuntu2 The GTK+ graphical user interface
ii libjac 1:0.120.1+svn4142-2 JACK Audio Connection Kit (librari
ii liblas 0.6.0~rc2-1ubuntu2danmppa3~lucid1 LASH Audio Session Handler (LASH)
ii libx11 2:1.3.2-1ubuntu3 X11 client-side library
Versions of packages jack-keyboard recommends:
ii a2jmidid 6-0ubuntu2 daemon for exposing legacy ALSA MI
ii qjackctl 0.3.7-4danmppa1~lucid1 User interface for controlling the
Versions of packages jack-keyboard suggests:
ii ghoste 20100923-0ubuntu1danmppa2~lucid1 A graphical DSSI plugin host
ii lashd 0.6.0~rc2-1ubuntu2danmppa3~lucid1 LASH Audio Session Handler (LASH)
ii whysyn 20090403-1ubuntu1 DSSI Soft Synth Interface
-- no debconf information
>From 724fa8746dc00c32db9dfadfcfe9fa46fa6ed95e Mon Sep 17 00:00:00 2001
From: Dan A. Muresan <danm...@gmail.com>
Date: Tue, 3 May 2011 01:12:17 +0300
Subject: [PATCH] Fix pianola mode (MIDI-in).
Per the manual page, jack-keyboard should pass through incoming MIDI
messages but replace the channel number with its own. The code only
recognized incoming messages sent on MIDI channel 0 however, and did
not rewrite the channel at all.
---
src/jack-keyboard.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/jack-keyboard.c b/src/jack-keyboard.c
index 5f8bc7c..70c1027 100644
--- a/src/jack-keyboard.c
+++ b/src/jack-keyboard.c
@@ -199,23 +199,29 @@ process_received_message_async(gpointer evp)
{
int i;
struct MidiMessage *ev = (struct MidiMessage *)evp;
+ int b0 = ev->data [0], b1 = ev->data [1];
- if (ev->data[0] == MIDI_RESET || (ev->data[0] == MIDI_CONTROLLER &&
- (ev->data[1] == MIDI_ALL_NOTES_OFF || ev->data[1] ==
MIDI_ALL_SOUND_OFF))) {
+ /* Strip channel from channel messages */
+ if (b0 >= 0x80 && b0 <= 0xEF)
+ b0 = b0 & 0xF0;
+
+ if (b0 == MIDI_RESET || (b0 == MIDI_CONTROLLER &&
+ (b1 == MIDI_ALL_NOTES_OFF || b1 == MIDI_ALL_SOUND_OFF))) {
for (i = 0; i < NNOTES; i++) {
piano_keyboard_set_note_off(keyboard, i);
}
}
- if (ev->data[0] == MIDI_NOTE_ON) {
+ if (b0 == MIDI_NOTE_ON) {
piano_keyboard_set_note_on(keyboard, ev->data[1]);
}
- if (ev->data[0] == MIDI_NOTE_OFF) {
+ if (b0 == MIDI_NOTE_OFF) {
piano_keyboard_set_note_off(keyboard, ev->data[1]);
}
+ ev->data [0] = b0 | channel;
queue_message(ev);
return FALSE;
--
1.7.0.4
--- End Message ---
--- Begin Message ---
Source: jack-keyboard
Source-Version: 2.5-3
We believe that the bug you reported is fixed in the latest version of
jack-keyboard, which is due to be installed in the Debian FTP archive:
jack-keyboard_2.5-3.debian.tar.gz
to main/j/jack-keyboard/jack-keyboard_2.5-3.debian.tar.gz
jack-keyboard_2.5-3.dsc
to main/j/jack-keyboard/jack-keyboard_2.5-3.dsc
jack-keyboard_2.5-3_amd64.deb
to main/j/jack-keyboard/jack-keyboard_2.5-3_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 625...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alessio Treglia <ales...@debian.org> (supplier of updated jack-keyboard package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 03 May 2011 12:37:57 +0200
Source: jack-keyboard
Binary: jack-keyboard
Architecture: source amd64
Version: 2.5-3
Distribution: unstable
Urgency: low
Maintainer: Debian Multimedia Maintainers
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Alessio Treglia <ales...@debian.org>
Description:
jack-keyboard - Virtual MIDI keyboard for JACK MIDI
Closes: 625282
Changes:
jack-keyboard (2.5-3) unstable; urgency=low
.
* Add patch to fix pianola mode (Closes: #625282).
Thanks to Dan Muresan for the report and patch!
* Rewrite debian/copyright as per DEP-5 proposal.
* Drop lash support.
* Demote qjackctl to Suggests.
* Bump Standards.
* Regenerate debian/control file.
Checksums-Sha1:
1eda2eeb2623d247e904360751f49c8a8e41dfaa 1438 jack-keyboard_2.5-3.dsc
ded84deedf193a36dbae93e01336d642d5cce4f3 6743 jack-keyboard_2.5-3.debian.tar.gz
760287429acaf1e6bef3a7ef282859d19b13958e 37568 jack-keyboard_2.5-3_amd64.deb
Checksums-Sha256:
5f28ea238f7ad0933ecc5d56b0a01c9cc83db553b34802726e316f22107b6b74 1438
jack-keyboard_2.5-3.dsc
fe8791f4a2fa9ce2146e93c437e379096e581cbd4e3f8315d7a74e81bdd32ded 6743
jack-keyboard_2.5-3.debian.tar.gz
c4e08b8afc87c2c56ad84f553d0ce6318ac0d56e426153d1d391021e4f92c8d0 37568
jack-keyboard_2.5-3_amd64.deb
Files:
68c1f01e5aa551a6bba4df7f10637202 1438 sound optional jack-keyboard_2.5-3.dsc
ad07e80cc4deb9a243d8f56c0b8f3c81 6743 sound optional
jack-keyboard_2.5-3.debian.tar.gz
639e663b75b22b1451c011f8ba1532d8 37568 sound optional
jack-keyboard_2.5-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk2/2+sACgkQRdSMfNz8P9C5eQCfX3msk4XxVWU2QUveie1ELm8Q
YTcAn3iwx99F3teS2JP2gGye9YhkcL3e
=1yIn
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
