Bug#625536: audacity: remove artificial limits

2012-03-31 Thread Benjamin Drung
tags 625536 - patch
thanks

Hi Jamie,

the upstream developers rejected your patch as stated in [1]. Your patch
doesn't apply any more in Audacity 2.0.0. Can you address upstream's
comments and supply an updated patch?

[1] http://bugzilla.audacityteam.org/show_bug.cgi?id=192

-- 
Benjamin Drung
Debian  Ubuntu Developer


signature.asc
Description: This is a digitally signed message part
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#625536: audacity: remove artificial limits

2011-06-02 Thread Jamie Heilman
tags 625536 + patch
thanks

Here's a patch to remove the sample rate limit on imported raw, and
add 192k and 384k to the list of standard sample rates (as 192k is now
pretty common even in on-board consumer gear, and 384k isn't even all
that rare).  I've run with this patch for a while, I haven't
experienced any adverse side effects.  Seeing as the upstream bug is a
lowly P4, I don't hold out much hope for an official fix anytime soon,
and in the interim, having to retype my sample rate 3 times for every
raw import is just needless pain.  Also note the upstream mention of
the spectrogram limit seems to overlook that the 100kHz limit there
isn't a reference to the sampling rate (atleast, not directly, its
related to the sampling rate divided by two I suppose) but rather the
highest frequency visually displayable.  Limitations imposed there are
arguably less of a big deal given the app's intended use with audio.

-- 
Jamie Heilman http://audible.transient.net/~jamie/
Index: src/AudioIO.cpp
===
--- src/AudioIO.cpp	(revision 11191)
+++ src/AudioIO.cpp	(working copy)
@@ -342,7 +342,9 @@
32000,
44100,
48000,
-   96000
+   96000,
+   192000,
+   384000
 };
 const int AudioIO::NumStandardRates = sizeof(AudioIO::StandardRates) /
   sizeof(AudioIO::StandardRates[0]);
@@ -360,7 +362,8 @@
48000,
88200,
96000,
-   192000
+   192000,
+   384000
 };
 const int AudioIO::NumRatesToTry = sizeof(AudioIO::RatesToTry) /
   sizeof(AudioIO::RatesToTry[0]);
Index: src/import/ImportRaw.cpp
===
--- src/import/ImportRaw.cpp	(revision 11191)
+++ src/import/ImportRaw.cpp	(working copy)
@@ -453,10 +453,8 @@
   mPercent = 0.0;
if (mPercent  100.0)
   mPercent = 100.0;
-   if (mRate  100.0)
-  mRate = 100.0;
-   if (mRate  10.0)
-  mRate = 10.0;
+   if (mRate  1.0)
+  mRate = 1.0;
 
EndModal(true);
 }
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers