Re: [SCM] Free Firewire Audio Drivers (ffado.org) packaging branch, master, updated. debian/2.0.0+svn1806-1-10-ga1a93ce
On Tue, Apr 20, 2010 at 01:53:35PM +, adiknoth-gu...@users.alioth.debian.org wrote: The following commit has been merged in the master branch: commit 79e3bf02882e6d8733a6a6d1b9d65c1017194c10 Author: Adrian Knoth a...@drcomp.erfurt.thur.de Date: Tue Apr 20 14:18:32 2010 +0200 Include python site-packages for ffado-mixer (Closes: #578499) diff --git a/debian/ffado-mixer-qt4.install b/debian/ffado-mixer-qt4.install index 7e98b28..401d92c 100644 --- a/debian/ffado-mixer-qt4.install +++ b/debian/ffado-mixer-qt4.install @@ -1,3 +1,4 @@ debian/tmp/usr/share/libffado2/python/* debian/tmp/usr/bin/ffado-mixer +debian/tmp/usr/lib/python* support/xdg/ffado.org-ffadomixer.desktop usr/share/applications/ This looks wrong: Python modules should be packaged separately, following Debian Python Policy. Kind regards, - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] Free Firewire Audio Drivers (ffado.org) packaging branch, master, updated. debian/2.0.0+svn1806-1-10-ga1a93ce
On Tue, Apr 20, 2010 at 04:46:11PM +0200, Jonas Smedegaard wrote: Include python site-packages for ffado-mixer (Closes: #578499) +debian/tmp/usr/lib/python* support/xdg/ffado.org-ffadomixer.desktop usr/share/applications/ This looks wrong: Python modules should be packaged separately, following Debian Python Policy. We're talking about /usr/lib/python2.5/site-packages/ffado/ and http://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html#s-paths says Public Python modules not handled by python-central or python-support must be installed in the system Python modules directory, /usr/lib/pythonX.Y/dist-packages for python2.6 and later, and /usr/lib/pythonX.Y/site-packages for python2.5 and earlier. We could probably call python-support in the rules file, if it's not done automagically by cdbs. ;) In addition, http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html says Python packages are directories containing at least a __init__.py, other modules, extensions and packages (A package in the Python sense is unrelated to a Debian package) From these lines, I don't think we're required to package this very ffado-specific python support module into a separate package, it probably won't make any sense at all. (there is nobody else relying on it) The debconf package also places a debconf.py in site-packages. Cheerio -- mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] Free Firewire Audio Drivers (ffado.org) packaging branch, master, updated. debian/2.0.0+svn1806-1-10-ga1a93ce
On Tue, Apr 20, 2010 at 05:17:34PM +0200, Adrian Knoth wrote:
On Tue, Apr 20, 2010 at 04:46:11PM +0200, Jonas Smedegaard wrote:
Include python site-packages for ffado-mixer (Closes: #578499)
+debian/tmp/usr/lib/python*
support/xdg/ffado.org-ffadomixer.desktop usr/share/applications/
This looks wrong: Python modules should be packaged separately,
following Debian Python Policy.
We're talking about
/usr/lib/python2.5/site-packages/ffado/
and
http://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html#s-paths
says
Public Python modules not handled by python-central or python-support
must be installed in the system Python modules directory,
/usr/lib/pythonX.Y/dist-packages for python2.6 and later, and
/usr/lib/pythonX.Y/site-packages for python2.5 and earlier.
We could probably call python-support in the rules file, if it's not
done automagically by cdbs. ;)
I certainly recommend to use one of thos Python install systems, not try
to outsmart them.
Doing so with CDBS goes roughly like this:
* Include CDBS class python-module.mk
* Declare above CDBS inclusions which Python install system to use
* Add proper ${python:*} variables to control file
* Follow documentation of the chosen Python install system on what
other hints is needed
* Update build dependencies
In addition,
http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html
says
Python packages are directories containing at least a __init__.py,
other modules, extensions and packages (A package in the Python sense is
unrelated to a Debian package)
From these lines, I don't think we're required to package this very
ffado-specific python support module into a separate package, it
probably won't make any sense at all. (there is nobody else relying on
it)
The debconf package also places a debconf.py in site-packages.
Fair enough - if not a module then it need not be packaged separately,
but packaging still needs to follow Python Policy.
- Jonas
--
* Jonas Smedegaard - idealist Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] Free Firewire Audio Drivers (ffado.org) packaging branch, master, updated. debian/2.0.0+svn1806-1-10-ga1a93ce
On Tue, Apr 20, 2010 at 06:07:02PM +0200, Adrian Knoth wrote:
On Tue, Apr 20, 2010 at 05:50:08PM +0200, Jonas Smedegaard wrote:
We could probably call python-support in the rules file, if it's not
done automagically by cdbs. ;)
I certainly recommend to use one of thos Python install systems, not try
to outsmart them.
Doing so with CDBS goes roughly like this:
* Include CDBS class python-module.mk
* Declare above CDBS inclusions which Python install system to use
* Add proper ${python:*} variables to control file
* Follow documentation of the chosen Python install system on what
other hints is needed
* Update build dependencies
I completely agree, this sounds reasonable. (I don't have the slightest
clue about python packaging, so handing this over to those tools might
be a good idea).
Fair enough - if not a module then it need not be packaged
separately, but packaging still needs to follow Python Policy.
Are we violating the policy? I must admit I haven't read the
python-policy.
As far as I can tell, it's working, lintian isn't complaining, it has
the right build- and runtime-dependencies and it probably has the right
paths, too, though I'm not entirely sure about the last one.
If you feel we need to change something, please do so. It would take me
ten times longer to sort out all the nuances imposed by the policy I
haven't read, time that's better spent on actually coding something
useful. ;) (e.g. the FFADO-FTBFS-gcc-4.5, which I fixed this afternoon.
I'm pushing this upstream and then update to a new svn version
afterwards)
I'll have a closer look.
Even if accidentally(!) we do follow Python Policy, I would prefer to
let CDBS handle it, so as to potentially automagically update it too.
- Jonas
--
* Jonas Smedegaard - idealist Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
