Re: [SCM] faad2 packaging branch, master, updated. debian/2.7-4-5-ga421d73
Am 17.08.2010 17:40, schrieb Felipe Sateler: No, I don't see anything weird. I do not know the codebase, so I don't know if it is complete, though. Cool, thanks. I'd like to get some feedback from upstream about these patches and then ask again for an upload to Debian. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] faad2 packaging branch, master, updated. debian/2.7-4-5-ga421d73
On 17/08/10 04:44, Fabian Greffrath wrote: > Alright, it's not a secret anymore that I am better at reading C-code > than writing it. ;) Would you please have another look at the patch and > tell me if you see something obviously bogus? No, I don't see anything weird. I do not know the codebase, so I don't know if it is complete, though. -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] faad2 packaging branch, master, updated. debian/2.7-4-5-ga421d73
Alright, it's not a secret anymore that I am better at reading C-code than writing it. ;) Would you please have another look at the patch and tell me if you see something obviously bogus? Thanks, - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] faad2 packaging branch, master, updated. debian/2.7-4-5-ga421d73
Am 16.08.2010 18:41, schrieb Adrian Knoth: This seems to be a pretty big patch that should be implemented upstream. As a workaround, one might get along with something like this: #ifndef PATH_MAX #define PATH_MAX 1024 #endif Thanks for the feedback! I wasn't yet finished with this patch, anyway, because there is still a potential buffer overrun when an even longer pathname is given on the command line and strcpy'ed into the string buffer. Regarding PATH_MAX, I believe I'll set it to the original value of 255 for archs that have undef PATH_MAX. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] faad2 packaging branch, master, updated. debian/2.7-4-5-ga421d73
On Mon, Aug 16, 2010 at 12:27:14PM -0400, Felipe Sateler wrote: > > +-char aacFileName[255]; > > +-char audioFileName[255]; > > +-char adtsFileName[255]; > > ++char aacFileName[PATH_MAX + 1]; > > ++char audioFileName[PATH_MAX + 1]; > > ++char adtsFileName[PATH_MAX + 1]; > > I believe not all archs have PATH_MAX. I'm almost positive that hurd > doesn't have it. Exactly. The common workaround is to dynamically allocate the filename buffers depending on the actual filename length. This seems to be a pretty big patch that should be implemented upstream. As a workaround, one might get along with something like this: #ifndef PATH_MAX #define PATH_MAX 1024 #endif See http://www.gnu.org/software/hurd/hurd/porting/guidelines.html for more information. HTH -- mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] faad2 packaging branch, master, updated. debian/2.7-4-5-ga421d73
On 16/08/10 10:36, fabian-gu...@users.alioth.debian.org wrote: > The following commit has been merged in the master branch: > commit a421d733a6b9f24c72326e08bddccdbd5bc0ddf3 > Author: Fabian Greffrath > Date: Mon Aug 16 16:39:32 2010 +0200 > > Extend file name buffers for longer path names. > > diff --git a/debian/patches/path_max.patch b/debian/patches/path_max.patch > new file mode 100644 > index 000..c606354 > --- /dev/null > +++ b/debian/patches/path_max.patch > @@ -0,0 +1,27 @@ > +Description: Extend file name buffers for longer path names. > +Author: Fabian Greffrath > +Forwarded: me...@audiocoding.com > + > +--- faad2.orig/frontend/main.c > faad2/frontend/main.c > +@@ -42,6 +42,7 @@ > + #include > + #include > + #include > ++#include > + > + #include > + #include > +@@ -1107,9 +1108,9 @@ int main(int argc, char *argv[]) > + int mp4file = 0; > + int noGapless = 0; > + char *fnp; > +-char aacFileName[255]; > +-char audioFileName[255]; > +-char adtsFileName[255]; > ++char aacFileName[PATH_MAX + 1]; > ++char audioFileName[PATH_MAX + 1]; > ++char adtsFileName[PATH_MAX + 1]; I believe not all archs have PATH_MAX. I'm almost positive that hurd doesn't have it. -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
