Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
On Tue, Feb 22, 2011 at 08:43, Fabian Greffrath wrote: > Am 22.02.2011 08:49, schrieb Reinhard Tartler: >> >> Makes sense, > > and so it's done ;) In csound, I number patches according to the following scheme: 0xxx: Patches taken from upstream development 1xxx: Patches interesting for upstream (may or may not be forwarded/clean enough yet) 2xxx: Debian specific patches -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
Am 22.02.2011 08:49, schrieb Reinhard Tartler: Makes sense, and so it's done ;) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
On Tue, Feb 22, 2011 at 08:30:14 (CET), Fabian Greffrath wrote: > Am 21.02.2011 17:21, schrieb Reinhard Tartler: >> I'd suggest to drop them. the order is defined by debian/patches/series >> anyway > > Generally I agree with you. But for the sake of the smallest possible > debdiff with the version currently in stable, I think I should keep the > numbering of the present patches and simply assign higher prefixes to > the new ones. Makes sense, thanks! -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
Am 21.02.2011 17:21, schrieb Reinhard Tartler: I'd suggest to drop them. the order is defined by debian/patches/series anyway Generally I agree with you. But for the sake of the smallest possible debdiff with the version currently in stable, I think I should keep the numbering of the present patches and simply assign higher prefixes to the new ones. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
On Mon, Feb 21, 2011 at 16:47:38 (CET), Fabian Greffrath wrote: > Am 21.02.2011 16:37, schrieb Reinhard Tartler: >> the numbering looks very weird. Fabian, is that on purpose? perhaps we >> should remove the numbers from the filenames before the next upload? > > Yes, I admit it's weird. No, it's not on purpose. ;) > > It is because each time I backported a patch from upstream git, it was > the last available commit at that time, so git format-patch always > started numbering the patch at 1 again. > > If you think it is better to remove the numbers, I can do so. Or I just > renumber the patches in the right order. I'd suggest to drop them. the order is defined by debian/patches/series anyway -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
Am 21.02.2011 16:37, schrieb Reinhard Tartler: the numbering looks very weird. Fabian, is that on purpose? perhaps we should remove the numbers from the filenames before the next upload? Yes, I admit it's weird. No, it's not on purpose. ;) It is because each time I backported a patch from upstream git, it was the last available commit at that time, so git format-patch always started numbering the patch at 1 again. If you think it is better to remove the numbers, I can do so. Or I just renumber the patches in the right order. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libmms/squeeze: Apply another patch backported from upstream git to fixup bswap.h macros. This patch does not change anything functionally, but it does make the code read correctly.
On Mon, Feb 21, 2011 at 15:25:48 (CET), fabian-gu...@users.alioth.debian.org wrote: > diff --git a/debian/patches/series b/debian/patches/series > index f086ba3..8e6f538 100644 > --- a/debian/patches/series > +++ b/debian/patches/series > @@ -1,3 +1,4 @@ > 0001-Remove-unneeded-bswap.h-from-public-headers.patch > 0003-Bug-493735-libmms-dev-Incorrect-use-of-this-keyword-.patch > 0001-Endianness-macros-should-not-dereference-unaligned-p.patch > +0001-Fixup-bswap.h-macros.patch the numbering looks very weird. Fabian, is that on purpose? perhaps we should remove the numbers from the filenames before the next upload? -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
