Re: [SCM] qjackctl/master: Don't override DEB_MAKE_INSTALL_TARGET, otherwise FTBFS.
On Thu, Dec 02, 2010 at 07:50:29PM +0100, Alessio Treglia wrote: On Thu, Dec 2, 2010 at 3:55 PM, Jonas Smedegaard wrote: Why override DEB_CONFIGURE_EXTRA_FLAGS or DEB_MAKE_CLEAN_TARGET either? Dropped DEB_CONFIGURE_EXTRA_FLAGS, DEB_MAKE_CLEAN_TARGET is still needed otherwise: (experimental_amd64)quadris...@debomatic64:~/devel/qjackctl$ fakeroot debian/rules cleantest -x debian/rules dh_testroot rm -f debian/stamp-makefile-build debian/stamp-makefile-install /usr/bin/make -C . -k distclean make[1]: Entering directory `/home/quadrispro/devel/qjackctl' make[1]: *** No rule to make target `distclean'. Seems it calls make distclean, which is not provided by upstream's Makefile. Ah, makes sense: The project uses autoconf but not automake. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] qjackctl/master: Don't override DEB_MAKE_INSTALL_TARGET, otherwise FTBFS.
On Thu, Dec 2, 2010 at 3:55 PM, Jonas Smedegaard wrote: > Why override DEB_CONFIGURE_EXTRA_FLAGS or DEB_MAKE_CLEAN_TARGET either? Dropped DEB_CONFIGURE_EXTRA_FLAGS, DEB_MAKE_CLEAN_TARGET is still needed otherwise: (experimental_amd64)quadris...@debomatic64:~/devel/qjackctl$ fakeroot debian/rules cleantest -x debian/rules dh_testroot rm -f debian/stamp-makefile-build debian/stamp-makefile-install /usr/bin/make -C . -k distclean make[1]: Entering directory `/home/quadrispro/devel/qjackctl' make[1]: *** No rule to make target `distclean'. Seems it calls make distclean, which is not provided by upstream's Makefile. -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer | quadris...@ubuntu.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] qjackctl/master: Don't override DEB_MAKE_INSTALL_TARGET, otherwise FTBFS.
On Thu, Dec 02, 2010 at 02:38:04PM +, ales...@users.alioth.debian.org wrote: Don't override DEB_MAKE_INSTALL_TARGET, otherwise FTBFS. DEB_CONFIGURE_EXTRA_FLAGS := --prefix=/usr -DEB_MAKE_INSTALL_TARGET := install prefix=$(DEB_DESTDIR)/usr DEB_MAKE_CLEAN_TARGET := clean Why override DEB_CONFIGURE_EXTRA_FLAGS or DEB_MAKE_CLEAN_TARGET either? Both seem to set same values that are already defaults in CDBS. If really needed to override prefix during install, then I believe upstream code should be patched to properly use DESTDIR. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
