Re: Fix for TEMP-0000000-002932 and VideoLAN-SA-0901

2010-03-21 Thread Christophe Mutricy
Hello,


  Yes technically it can theoritically overflow with an very malformed
  AVI (i.e.
   more malformed that the ones trigerring VideoLAN-SA-0901)
 
  However on my simple test (attached) it doesn't wrap up to a negative
  value but
  produce a large integer. I'm not sure if we can rely on that feature
  of
  the compiler.
 
 It can't wrap to a negative value as it is promoted to unsigned. But it
 can
 wrap to something which is  sizeof(str) I think. No proper fix for an
 integer
 overflow in my opinion.

After a lapse of 5 months I'm coming back with a fix.

you can find a diff.gz at
http://people.videolan.org/~xtophe/debian/vlc_0.8.6.h-4+lenny3.diff.gz
(and  .dsc, debdiff and .debs)

or in the git repo, branch lenny :
http://git.debian.org/?p=pkg-multimedia/vlc.git;a=shortlog;h=refs/heads/lenny


Regards

-- 
Xtophe

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Re: Fix for TEMP-0000000-002932 and VideoLAN-SA-0901

2010-03-21 Thread Nico Golde
Hey,
* Christophe Mutricy xto...@chewa.net [2010-03-21 23:34]:
   Yes technically it can theoritically overflow with an very malformed
   AVI (i.e.
more malformed that the ones trigerring VideoLAN-SA-0901)
  
   However on my simple test (attached) it doesn't wrap up to a negative
   value but
   produce a large integer. I'm not sure if we can rely on that feature
   of
   the compiler.
  
  It can't wrap to a negative value as it is promoted to unsigned. But it
  can
  wrap to something which is  sizeof(str) I think. No proper fix for an
  integer
  overflow in my opinion.
 
 After a lapse of 5 months I'm coming back with a fix.
 
 you can find a diff.gz at
 http://people.videolan.org/~xtophe/debian/vlc_0.8.6.h-4+lenny3.diff.gz
 (and  .dsc, debdiff and .debs)
 
 or in the git repo, branch lenny :
 http://git.debian.org/?p=pkg-multimedia/vlc.git;a=shortlog;h=refs/heads/lenny

This one looks good!

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - n...@jabber.ccc.de - GPG: 0xA0A0
For security reasons, all text in this mail is double-rot13 encrypted.


pgpyAuiDUSSWy.pgp
Description: PGP signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers