This is an automated email from the git hooks/post-receive script.
ppm-guest pushed a commit to annotated tag v0.30
in repository libmath-prime-util-perl.
commit 3eded313a1ea00c09ff442e1ff7aff33ab706653
Author: Dana Jacobsen <d...@acm.org>
Date: Thu Aug 1 11:18:33 2013 -0700
Tested multicall with 5.8, 5.10, 5.16, 5.17s, 5.18 -- looks good so just
use it.
---
TODO | 4 ----
XS.xs | 3 +--
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/TODO b/TODO
index c89456e..fe89555 100644
--- a/TODO
+++ b/TODO
@@ -39,8 +39,4 @@
- Refactor where functions exist in .c. Lots of primality tests in factor.c.
-- Write a standalone function that demonstrates the memory leak with MULTICALL,
- so we can use MULTICALL. Seems to be fixed on 5.18.0. See if this was
- broken on 5.16 and previous, or if this was just a 5.17 issue.
-
- Switch to new text proofs.
diff --git a/XS.xs b/XS.xs
index 24e81d5..2150603 100644
--- a/XS.xs
+++ b/XS.xs
@@ -29,7 +29,7 @@
#endif
/* multicall compatibility stuff */
-#if PERL_VERSION < 7
+#if PERL_REVISION <= 5 && PERL_VERSION < 7
# define USE_MULTICALL 0 /* Too much trouble to work around it */
#else
# define USE_MULTICALL 1
@@ -768,7 +768,6 @@ forprimes (SV* block, IN SV* svbeg, IN SV* svend = 0)
if (beg <= end) {
ctx = start_segment_primes(beg, end, &segment);
while (next_segment_primes(ctx, &seg_base, &seg_low, &seg_high)) {
- /* TODO: Make sure this doesn't leak memory in 5.16 and previous */
if (!CvISXSUB(cv)) {
dMULTICALL;
I32 gimme = G_VOID;
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/pkg-perl/packages/libmath-prime-util-perl.git
_______________________________________________
Pkg-perl-cvs-commits mailing list
Pkg-perl-cvs-commits@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-perl-cvs-commits
