Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Christoph Berg
Re: Michael Biebl 2018-03-02 <4c3431e8-36e3-d86b-4bb8-1f99eaa38...@debian.org> > Am 02.03.2018 um 13:45 schrieb Christoph Berg: > > > I agree that it is not helpful that it doesn't raise an error here, > > but I think it is working as intended by systemd. Or should we rather > > be using

Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Michael Biebl
Am 02.03.2018 um 17:23 schrieb Christoph Berg: > Re: Michael Biebl 2018-03-02 <4c3431e8-36e3-d86b-4bb8-1f99eaa38...@debian.org> >> Am 02.03.2018 um 13:45 schrieb Christoph Berg: >> >>> I agree that it is not helpful that it doesn't raise an error here, >>> but I think it is working as intended by

Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Christoph Berg
Re: Michael Biebl 2018-03-02 > >>> I agree that it is not helpful that it doesn't raise an error here, > >>> but I think it is working as intended by systemd. Or should we rather > >>> be using AssertFileExists here? But starting the non-existing

Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Michael Biebl
Am 02.03.2018 um 20:48 schrieb Christoph Berg: > "systemctl start foo.service" throws an error, but does not mark > foo.service as failed. > > If "systemctl start postgresql@foo.service" would not have > ConditionFileExists, it would permanently be marked as failed (until > "systemctl

Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Michael Biebl
Am 01.03.2018 um 20:35 schrieb Felipe Sateler: > On Thu, Mar 1, 2018 at 2:46 PM, Michael Biebl wrote: >> Control: tags -1 moreinfo unreproducible >> >> Am 01.03.2018 um 16:00 schrieb Martin von Wittich: >>> Hi Michael, >>> >>> On Thu, 1 Mar 2018 15:10:26 +0100 Michael Biebl

Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Michael Biebl
Am 02.03.2018 um 13:45 schrieb Christoph Berg: > I agree that it is not helpful that it doesn't raise an error here, > but I think it is working as intended by systemd. Or should we rather > be using AssertFileExists here? But starting the non-existing "foo" > service doesn't put "foo" into a

Bug#891836: systemd: systemctl start/stop/restart valid-template@invalid-instance doesn't cause errors

2018-03-02 Thread Christoph Berg
Re: Michael Biebl 2018-03-02 > > I think the problem is postgres has: > > > > # -: ignore startup failure (recovery might take arbitrarily long) > > # the actual pg_ctl timeout is configured in pg_ctl.conf > > ExecStart=-/usr/bin/pg_ctlcluster