Re: [Pkg-tcltk-devel] [RFU] Naviserver

[Sergei Golovan]

Hi Hector,

On Thu, Mar 8, 2018 at 2:41 PM, Héctor Romojaro Gómez
 wrote:
> Hi Sergei,
>
>> > ...so i have removed  "Multi-Arch: same" from naviserver-dev in the
>> > control file, for the time being.
>>
>> I would also suggest to move the primary location of the2 include
>> directory
>> to /usr/lib//naviserver/include and create two
>> symlinks:
>> /usr/include/naviserver -> /usr/lib/> triplet>/naviserver/include
>> /usr/share/naviserver/include -> /usr/include/naviserver
>
> Done. I have pushed (no tag, see below) it to salsa.

Thank you! I'll check it out later.

>
>> > Aside from that, i have already fixed all the other issues, and
>> > pushed
>> > --force to salsa :)
>>
>> About that. May I suggest you to never ever do anything that would
>> require
>> using push --force? I'ts okay do do mistakes and fix them in the next
>> commit,
>> you don't have to rewrite history (especially already published
>> history,
>> it's good that I hadn't any local changes and could just reclone the
>> repository,
>> and what if I had?)
>
> Yes, it's an annoyance, also for me.
>
> The problem is the re-tagging. In order to change a tag with the same
> name (debian/4.99.16-1, for example) --force is required, so for first
> uploads, either they are not tagged remotely until they get into the
> archive, or the version is incremented with each change... not sure
> which is the best way.
>
> For the time being, maybe is better to just avoid tagging
> "debian/4.99.16-1" at all, until the end... what do you think?

Definitely. I tag my packages only after actual upload. May be it'd
be even better to wait till it's accepted.

Cheers!
-- 
Sergei Golovan

___
Pkg-tcltk-devel mailing list
Pkg-tcltk-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tcltk-devel

Re: [Pkg-tcltk-devel] [RFU] Naviserver

[Héctor Romojaro Gómez]

Hi Sergei,

> > ...so i have removed  "Multi-Arch: same" from naviserver-dev in the
> > control file, for the time being.
> 
> I would also suggest to move the primary location of the2 include
> directory
> to /usr/lib//naviserver/include and create two
> symlinks:
> /usr/include/naviserver -> /usr/lib/ triplet>/naviserver/include
> /usr/share/naviserver/include -> /usr/include/naviserver

Done. I have pushed (no tag, see below) it to salsa.

> > Aside from that, i have already fixed all the other issues, and
> > pushed
> > --force to salsa :)
> 
> About that. May I suggest you to never ever do anything that would
> require
> using push --force? I'ts okay do do mistakes and fix them in the next
> commit,
> you don't have to rewrite history (especially already published
> history,
> it's good that I hadn't any local changes and could just reclone the
> repository,
> and what if I had?)

Yes, it's an annoyance, also for me.

The problem is the re-tagging. In order to change a tag with the same
name (debian/4.99.16-1, for example) --force is required, so for first
uploads, either they are not tagged remotely until they get into the
archive, or the version is incremented with each change... not sure
which is the best way.

For the time being, maybe is better to just avoid tagging
"debian/4.99.16-1" at all, until the end... what do you think?

Kind regards,
Héctor

___
Pkg-tcltk-devel mailing list
Pkg-tcltk-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tcltk-devel

Re: [Pkg-tcltk-devel] [RFU] Naviserver

[Héctor Romojaro Gómez]

Hi Sergei,

> > > * there are many Makefiles inside/usr/share/naviserver/include.
> > > Please, get rid of them. Or they are useful in some way?
> > 
> > Some of them are sourced by other naviserver modules, that will
> > form
> > part of the naviserver-modules package.
> > 
> > For instance, nsdbpg's Makefile[1] includes
> > /usr/share/naviserver/include/Makefile.module, which also includes
> > /usr/share/naviserver/include/Makefile.global.
> 
> Okay then.

After further inspection of the remaining files in the include
directory, i have also noticed that they have some architecture
dependant paths:

$ grep x86_64-linux *
Makefile.global:NAVISERVER   = /usr/lib/x86_64-linux-gnu/naviserver
Makefile.global:NSLIBS  += -L/usr/lib/x86_64-linux-gnu -ltcl8.6 ${DL_LIBS} 
${LIBS} ${MATH_LIBS} -Wl,-z,relro -Wl,-z,now -Wl,--export-dynamic  
-L/usr/lib/x86_64-linux-gnu -lssl -lcrypto
nsversion.h:#define NS_NAVISERVER   "/usr/lib/x86_64-linux-gnu/naviserver"

...so i have removed  "Multi-Arch: same" from naviserver-dev in the
control file, for the time being.

Aside from that, i have already fixed all the other issues, and pushed
--force to salsa :)

Kind regards,
Héctor


___
Pkg-tcltk-devel mailing list
Pkg-tcltk-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tcltk-devel

Re: [Pkg-tcltk-devel] [RFU] Naviserver

[Sergei Golovan]

Hi Hector,

On Wed, Mar 7, 2018 at 4:23 PM, Héctor Romojaro Gómez
 wrote:
> Hi Sergei,
>
> Thanks a lot for looking into this.
>
>> There are a few imperfections, which I'd like you to fix:
>>
>> * there are many Makefiles inside/usr/share/naviserver/include.
>> Please, get rid of them. Or they are useful in some way?
>
> Some of them are sourced by other naviserver modules, that will form
> part of the naviserver-modules package.
>
> For instance, nsdbpg's Makefile[1] includes
> /usr/share/naviserver/include/Makefile.module, which also includes
> /usr/share/naviserver/include/Makefile.global.

Okay then.

-- 
Sergei Golovan

___
Pkg-tcltk-devel mailing list
Pkg-tcltk-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-tcltk-devel