[Pki-devel] [PATCH] 757 Added TPS token state transition validation.

2016-05-25 Thread Endi Sukma Dewata
The TPSSubsystem has been modified to load and validate the token state transition lists during initialization. If any of the lists is empty or any of the transitions is invalid, the initialization will fail and the subsystem will not start. https://fedorahosted.org/pki/ticket/2334 -- Endi S. De

[Pki-devel] [PATCH] 758 Fixed error handling in ProxyRealm.

2016-05-25 Thread Endi Sukma Dewata
The ProxyRealms for Tomcat 7 and 8 have been modified to return an error if the subsystem is not available instead of falling back to username/password authentication. https://fedorahosted.org/pki/ticket/2326 -- Endi S. Dewata >From cc10c05d122df43bb5b09cfc09c42099c1fd08bd Mon Sep 17 00:00:00 20

Re: [Pki-devel] [PATCH] 303-306 Various issues

2016-05-25 Thread Endi Sukma Dewata
On 5/24/2016 10:32 PM, Ade Lee wrote: Patches 303, 305 and 306 have been modified as discussed and checked in. Patch 304 has been revised as discussed on IRC. Please review. Ade Just one thing, the maxAge unit is still hours. I'm not sure anybody wants to purge CRLs less than a day old. Con

Re: [Pki-devel] [PATCH] pki-cfu-0123-Ticket-1665-Cert-Revocation-Reasons-not-being-update.patch

2016-05-25 Thread Christina Fu
pushed to master commit 03d578a6254620e4d4122b92b922f8711773ad40 thanks! Christina On 05/25/2016 10:34 AM, John Magne wrote: Looks good: Just a minor suggestion: The bookean to markAsRevoked, you might want to rename as "isAlreadyRevoked" to tell the reader more clearly what is going on. We k

Re: [Pki-devel] [PATCH] pki-cfu-0123-Ticket-1665-Cert-Revocation-Reasons-not-being-update.patch

2016-05-25 Thread John Magne
Looks good: Just a minor suggestion: The bookean to markAsRevoked, you might want to rename as "isAlreadyRevoked" to tell the reader more clearly what is going on. We know we want to revoke a cert, but this boolean covers the case when the cert to be revoked is already in the unique (on hold) sta