Re: [Pki-devel] [pki-devel][PATCH] 0083-PIN_RESET-policy-is-not-giving-expected-results-when.patch

2016-10-19 Thread Christina Fu
code looks fine. If tested to work, ACK. Christina On 10/18/2016 07:02 PM, John Magne wrote: PIN_RESET policy is not giving expected results when set on a token. Simple fix to actually honor the PIN_RESET=or policy for a given token. Minor logging improvements added as well for

Re: [Pki-devel] Karma Requests for pki-core-10.3.5-7 and pki-console-10.3.5-2

2016-10-19 Thread Matthew Harmsen
On 10/11/2016 01:12 PM, Matthew Harmsen wrote: *The following updated candidate builds of pki-core 10.3.5 and pki-console 10.3.5 were generated:* * *Fedora 24* o *pki-core-10.3.5-7.fc24 * o

Re: [Pki-devel] [pki-devel][PATCH] 0082-Cert-Key-recovery-is-successful-when-the-cert-serial.patch

2016-10-19 Thread John Magne
Pushed to master: commit 9090451aa9f1a2dfcef8b852bb1e1d13d270098d Author: Jack Magne Date: Tue Oct 18 15:08:44 2016 -0700 Cert/Key recovery is successful when the cert serial number and key id on the ldap user mismatches Fixes this bug

Re: [Pki-devel] [PATCH] 844 Fixed CryptoUtil.getTokenName().

2016-10-19 Thread Endi Sukma Dewata
On 10/18/2016 11:34 AM, Christina Fu wrote: Code looks good. ACK if tested to work in both FIPS and non-FIPS, with or without HSM. Might be a future exercise to find out where the string "Internal Key Storage Token" comes from. Christina Thanks! It works in the above cases. The patch has