Re: [Pki-devel] [PATCH] 844 Fixed CryptoUtil.getTokenName().

2016-10-19 Thread Endi Sukma Dewata
On 10/18/2016 11:34 AM, Christina Fu wrote: Code looks good. ACK if tested to work in both FIPS and non-FIPS, with or without HSM. Might be a future exercise to find out where the string "Internal Key Storage Token" comes from. Christina Thanks! It works in the above cases. The patch has

Re: [Pki-devel] [PATCH] 844 Fixed CryptoUtil.getTokenName().

2016-10-18 Thread Christina Fu
Code looks good. ACK if tested to work in both FIPS and non-FIPS, with or without HSM. Might be a future exercise to find out where the string "Internal Key Storage Token" comes from. Christina On 10/13/2016 06:57 PM, Endi Sukma Dewata wrote: The CryptoUtil.getTokenName() has been

[Pki-devel] [PATCH] 844 Fixed CryptoUtil.getTokenName().

2016-10-13 Thread Endi Sukma Dewata
The CryptoUtil.getTokenName() has been modified to check both the short name and full name of the internal token. The ConfigurationUtils.deleteCert() has also been modified to call CryptoUtil.getTokenName(). https://fedorahosted.org/pki/ticket/2500 Pushed to master under one-liner/trivial