Re: [Pki-devel] [pki-devel][PATCH]0061-Enhance-tkstool-for-capabilities-and-security.patch

2016-05-12 Thread John Magne
Message - From: "Christina Fu" <c...@redhat.com> To: pki-devel@redhat.com Sent: Wednesday, January 27, 2016 10:24:26 AM Subject: Re: [Pki-devel] [pki-devel][PATCH]0061-Enhance-tkstool-for-capabilities-and-security.patch I think I will be more conservative and give conditional A

Re: [Pki-devel] [pki-devel][PATCH]0061-Enhance-tkstool-for-capabilities-and-security.patch

2016-01-27 Thread Christina Fu
I think I will be more conservative and give conditional ACK to this patch pending on tests on servers running on both LunaSA and nethsm. Although the code in the patch might very well work for both, those two HSM's are known to require different sets of pk11AtrFlags and often one set would