Thanks Ade. Updated patch 0096 attached. Comments inline.
On Wed, Apr 20, 2016 at 11:30:52AM -0400, Ade Lee wrote:
> Comments:
>
> 95 - ack
>
> 96 -
>
> 1. You have made the return type of initSigUnit() to be boolean.
> Should you be checking the return value in init()?
>
It is not needed
Hi all,
Could someone with the relevant permissions please add a
"Lightweight CAs" feature to the pki trac? There's a substantial
quantity of outstanding tickets for this feature so it would be good
to have something more formal than the summary by which to group
them.
Thanks,
Fraser
On 4/19/2016 9:47 PM, Ade Lee wrote:
Some comments inline, although most of this was discussed on #irc.
I have added two additional patches which are to be applied on top
of 258=293.
294: This patch fixes the problems identified in this review. In
particular:
Review comments addressed:
Comments:
95 - ack
96 -
1. You have made the return type of initSigUnit() to be boolean.
Should you be checking the return value in init()?
2. In addInstanceToAuthorityKeyHosts(), you are still using only the
hostname. Should be host:port
3. The logic in the KeyRetrieverRunner class looks
