[Pki-devel] [PATCH] pki-cfu-0131-Ticket-2335-Missing-activity-logs-when-formatting-en.patch

2016-06-03 Thread Christina Fu
https://fedorahosted.org/pki/ticket/2335 Ticket #2335 Missing activity logs when formatting/enrolling unknown token This patch adds activity logs for adding unknown token during format or enrollment thanks, Christina >From 844c5c03d5981f6c881bb82f114c72e335478b44 Mon Sep 17 00:00:00 2001

[Pki-devel] [PATCH] 762 Removed selftest interface from TPS UI.

2016-06-03 Thread Endi Sukma Dewata
The selftest interface has been removed from TPS UI to avoid confusion due to its limited usefulness. https://fedorahosted.org/pki/ticket/2344 Pushed to master under one-liner/trivial rule. -- Endi S. Dewata >From af1d50bae945e14e1edc198d78d774b6ca491a5d Mon Sep 17 00:00:00 2001 From: "Endi S.

Re: [Pki-devel] [pki-devel][PATCH] 0069-Show-KeyOwner-info-when-viewing-recovery-requests.patch

2016-06-03 Thread John Magne
Pushed to master based on cfu's verbal conditional ACK for this (after I modded it the way she requested) Tested to work. commit 3cd58a98022141da2af4bf0bad29ab1dbdc86fbe Author: Jack Magne Date: Wed Jun 1 15:05:20 2016 -0700 Closing ticket #1512 -

Re: [Pki-devel] [pki-devel][PATCH] 0069-Show-KeyOwner-info-when-viewing-recovery-requests.patch

2016-06-03 Thread Christina Fu
while the patch works, I think the original code logic is somehow flawed in a way that it uses the "profile" attribute to determine whether the request was non-TMS archival requests, and if null it treats it as TMS. It would make better sense if we add a separate case instead of lumping the

[Pki-devel] [PATCH] 761 Fixed truncated token activity message in TPS UI.

2016-06-03 Thread Endi Sukma Dewata
The TPS UI has been modified to display the token activity message in a textarea to avoid truncation. The UI framework class has been modified to handle textarea. The CSS has been modified to align the field label with the top of textarea. https://fedorahosted.org/pki/ticket/2299 Pushed to

Re: [Pki-devel] [PATCH] pki-cfu-0129-Ticket-2352-TMS-missing-netkeyKeyRecovery-requests-o.patch

2016-06-03 Thread Christina Fu
The original "Show archival requests" and "Show recovery requests" are actually quite misleading, as they do NOT show any archival or recovery requests for TMS. However, for the lack of a better idea, I'll leave them as is. commit 1c5458150d583481415e2bde4e68d8ab7bbf56d9 thanks, Christina

Re: [Pki-devel] [PATCH] pki-cfu-0129-Ticket-2352-TMS-missing-netkeyKeyRecovery-requests-o.patch

2016-06-03 Thread John Magne
ACK Does the job with little fuss. One thing I would push for is to leave the original labels for standard requests the way they were and NOT call them "Non Token " requests. This we the old behavior remains and the user can explore the new options provided for TMS related requests if they

Re: [Pki-devel] [PATCH] 320 - pki-server db changes

2016-06-03 Thread Ade Lee
With patch this time: On Fri, 2016-06-03 at 08:59 -0400, Ade Lee wrote: > commit 9450b5f7695cc827cced6e86281694daa1e5c2c8 > Author: Ade Lee > Date: Thu Jun 2 09:41:35 2016 -0400 > > Add commands to db-server to help with DB related changes > > Added pki-server

[Pki-devel] [PATCH] 320 - pki-server db changes

2016-06-03 Thread Ade Lee
commit 9450b5f7695cc827cced6e86281694daa1e5c2c8 Author: Ade Lee Date: Thu Jun 2 09:41:35 2016 -0400 Add commands to db-server to help with DB related changes Added pki-server kra-db-vlv-add, kra-db-vlv-del, kra-db-vlv-reindex Added pki-server db-schema-upgrade

Re: [Pki-devel] [PATCH] 0120..0121 Remove pki-ipa-retrieve-key script

2016-06-03 Thread Fraser Tweedale
On Thu, Jun 02, 2016 at 11:45:43PM -0500, Endi Sukma Dewata wrote: > On 5/31/2016 11:45 PM, Fraser Tweedale wrote: > > G'day comrades, > > > > Please review the attached two patches, which... > > > > (Patch 0120) > > > > - provide for passing of configuration (from CS.cfg) to KeyRetriever > >