[Pki-devel] [PATCH 0005-0008] Misc. fixes for pki-server commands

2016-06-30 Thread Abhijeet Kasurde
Hi All, Please review these patches. Partially fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1351295 -- Thanks, Abhijeet Kasurde IRC: akasurde http://akasurde.github.io From c97514152a50e34936a465963d41965a33caa2a7 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde

Re: [Pki-devel] [PATCH] 781 Added instance and subsystem validation for pki-server ca-* commands.

2016-06-30 Thread Abhijeet Kasurde
Hi Fraser, All, I am working on some of the error messages in pki-* , you can track this under this BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1351295 On 07/01/2016 09:43 AM, Fraser Tweedale wrote: On Thu, Jun 30, 2016 at 08:38:57PM -0500, Endi Sukma Dewata wrote: The pki-server ca-*

Re: [Pki-devel] [PATCH] 781 Added instance and subsystem validation for pki-server ca-* commands.

2016-06-30 Thread Fraser Tweedale
On Thu, Jun 30, 2016 at 08:38:57PM -0500, Endi Sukma Dewata wrote: > The pki-server ca-* commands have been modified to validate > the instance and the CA subsystem before proceeding with the > operation. > > The usage() methods and invocations have been renamed into > print_help() for

Re: [Pki-devel] [PATCH] 780 Fixed pki-server subsystem-cert-update.

2016-06-30 Thread Fraser Tweedale
On Wed, Jun 29, 2016 at 11:19:46AM -0500, Endi Sukma Dewata wrote: > The pki-server subsystem-cert-update is supposed to restore the > system certificate data and requests into CS.cfg. The command was > broken since the CASubsystem class that contains the code to find > the certificate requests

Re: [Pki-devel] [PATCH] 0124 Add profiles container to LDAP if missing

2016-06-30 Thread Fraser Tweedale
On Thu, Jun 30, 2016 at 10:10:32AM -0500, Endi Sukma Dewata wrote: > On 6/22/2016 4:53 AM, Fraser Tweedale wrote: > > The attached patch fixes https://fedorahosted.org/pki/ticket/2285. > > See commit message and bz1323400[1] for full history and details. > > > > [1]

Re: [Pki-devel] [PATCH] 0126 Respond 400 if lightweight CA cert issuance fails

2016-06-30 Thread Fraser Tweedale
On Thu, Jun 30, 2016 at 10:49:12AM -0500, Endi Sukma Dewata wrote: > On 6/27/2016 9:52 PM, Fraser Tweedale wrote: > > The attached patch fixes https://fedorahosted.org/pki/ticket/2388. > > Wanted for 10.3.4. > > > > Thanks, > > Fraser > > Two things: > > 1. I don't think the patch author is

Re: [Pki-devel] [PATCH 0004] Updated notification message for kra-db-vlv-del command

2016-06-30 Thread Endi Sukma Dewata
On 6/30/2016 6:29 AM, Abhijeet Kasurde wrote: Hi All, Please review this patch, Partially fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1351295 -- Thanks, Abhijeet Kasurde Thanks! Pushed to master with some changes to return error code 1 if the KRA is missing. -- Endi S. Dewata

Re: [Pki-devel] [pki-devel][PATCH 0003] Added condition for checking instance id in kra commands

2016-06-30 Thread Endi Sukma Dewata
On 6/30/2016 5:09 AM, Abhijeet Kasurde wrote: Hi All, Please review this patch. Partially fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1351295 -- Thanks, Abhijeet Kasurde Thanks! Pushed to master with some changes: 1. The original code was supposed to normalize the token name, so if

Re: [Pki-devel] [pki-devel][PATCH 0002] Added fix for checking ldapmodify return code in db-schema-upgrade

2016-06-30 Thread Endi Sukma Dewata
On 6/29/2016 7:43 AM, Abhijeet Kasurde wrote: Hi All, Please review the patch. -- Thanks, Abhijeet Kasurde Thanks! Pushed to master with some changes to handle all LDAP errors instead of some specific ones. -- Endi S. Dewata ___ Pki-devel

Re: [Pki-devel] [PATCH] Bug 1203407 - tomcatjss: missing ciphers

2016-06-30 Thread Christina Fu
got verbal ack from Jack. Pushed to master (the dogtag patch): commit f0ad71e8a4fbae665a6b4875cce5b82895ad74f0 tomcatjss will be built in the next few days. Christina On 06/30/2016 03:04 PM, Christina Fu wrote: The tomcatjss patch address: *Bug 1203407*

[Pki-devel] [PATCH] Bug 1203407 - tomcatjss: missing ciphers

2016-06-30 Thread Christina Fu
The tomcatjss patch address: *Bug 1203407* -tomcatjss: missing ciphers 2nd patch is the accompanying dogtag change to remove references to the unsupported ciphers. There is no critical dependency of the new tomcatjss. thanks, Christina

Re: [Pki-devel] [PATCH] pki-cfu-0144-Ticket-1306-config-params-Add-granularity-to-token-t.patch

2016-06-30 Thread Christina Fu
got verbal ack from Jack. Pushed to master: commit 63a58cf51ef2982e8a35eff1f98dd42453e5681e thanks, Christina On 06/30/2016 02:11 PM, Christina Fu wrote: This patch is for https://fedorahosted.org/pki/ticket/1306 [RFE] Add granularity to token termination in TPS It 1. adds the missing

Re: [Pki-devel] [pki-devel][PATCH] 0075-Generting-Symmetric-key-fails-with-key-generate-when.patch

2016-06-30 Thread Matthew Harmsen
On 06/24/2016 06:23 PM, John Magne wrote: Generting Symmetric key fails with key-generate when --usages verify is passed Ticket #1114 Minor adjustment to the man page for the key management commands to say which usages are appropriate for sym keys and those

Re: [Pki-devel] [PATCH] Separate PKI Instances versus Shared PKI Instances

2016-06-30 Thread John Magne
ACK - Original Message - From: "Matthew Harmsen" To: "pki-devel" Sent: Wednesday, June 29, 2016 7:57:34 PM Subject: [Pki-devel] [PATCH] Separate PKI Instances versus Shared PKI Instances Please review the attached patch which addresses the

[Pki-devel] [PATCH] pki-cfu-0144-Ticket-1306-config-params-Add-granularity-to-token-t.patch

2016-06-30 Thread Christina Fu
This patch is for https://fedorahosted.org/pki/ticket/1306 [RFE] Add granularity to token termination in TPS It 1. adds the missing parameters 2. adds a table for revocation code thanks, Christina >From 63a58cf51ef2982e8a35eff1f98dd42453e5681e Mon Sep 17 00:00:00 2001 From: Christina Fu

Re: [Pki-devel] [PATCH] 0125 AuthInfoAccess: use default OCSP URI if configured

2016-06-30 Thread Endi Sukma Dewata
On 6/27/2016 1:38 AM, Fraser Tweedale wrote: Attached patch fixes https://fedorahosted.org/pki/ticket/2387 (wanted for 10.3.4). Thanks, Fraser Just one thing, maybe we should add a blank pki_default_ocsp_uri under the [CA] section in the default.cfg so people knows about this parameter?

Re: [Pki-devel] [PATCH] 0124 Add profiles container to LDAP if missing

2016-06-30 Thread Endi Sukma Dewata
On 6/22/2016 4:53 AM, Fraser Tweedale wrote: The attached patch fixes https://fedorahosted.org/pki/ticket/2285. See commit message and bz1323400[1] for full history and details. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1323400 The fix should be merged to master and DOGTAG_10_2_BRANCH,