Re: [Pki-devel] [PATCH] 0179 KRA: do not accumulate recovered keys in token

2017-04-26 Thread Fraser Tweedale
On Wed, Apr 26, 2017 at 06:40:59PM +1000, Fraser Tweedale wrote: > On Thu, Apr 06, 2017 at 05:22:34PM +1000, Fraser Tweedale wrote: > > The attached patch fixes a regression (I think?) where recovered > > keys accumulate in the key storage token. > > > > Thanks, > > Fraser > > Gerrit review:

[Pki-devel] [pki-devel][PATCH]

2017-04-26 Thread John Magne
CA in the certificate profiles the startTime parameter is not working as expected. This simple fix addresses an overflow in the "startTime" paramenter in 4 places in the code. I felt that honing in only on the startTime value was the best way to go. In some of the files other than

Re: [Pki-devel] [PATCH] pki-0178, jss-0000..0002 - PKCS #12 key bag AES encryption

2017-04-26 Thread Fraser Tweedale
On Tue, Apr 11, 2017 at 03:23:18PM -0700, Christina Fu wrote: > Thank you. Please see review comments: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1355358#c6 > > I will review PKCS12Util later. > > Christina > Updated patch jss-0002 and also created

Re: [Pki-devel] [PATCH] 0179 KRA: do not accumulate recovered keys in token

2017-04-26 Thread Fraser Tweedale
On Thu, Apr 06, 2017 at 05:22:34PM +1000, Fraser Tweedale wrote: > The attached patch fixes a regression (I think?) where recovered > keys accumulate in the key storage token. > > Thanks, > Fraser Gerrit review: https://review.gerrithub.io/#/c/358632/