Re: [Pki-devel] [PATCH] 0105 Add pki-server ca-cert-db-upgrade command

2016-05-13 Thread Endi Sukma Dewata
On 5/13/2016 12:06 AM, Fraser Tweedale wrote: The patch itself is fine. I'm just struggling with where this script should exist. pki-server ca-cert-db-upgrade seems like an awfully generic description for this operation - which basically provides a very specific db migration. For that matter,

Re: [Pki-devel] [PATCH] 0105 Add pki-server ca-cert-db-upgrade command

2016-05-12 Thread Fraser Tweedale
On Tue, May 10, 2016 at 02:42:52PM -0400, Ade Lee wrote: > The patch itself is fine. > > I'm just struggling with where this script should exist. > > pki-server ca-cert-db-upgrade seems like an awfully generic description > for this operation - which basically provides a very specific db >

Re: [Pki-devel] [PATCH] 0105 Add pki-server ca-cert-db-upgrade command

2016-05-09 Thread Fraser Tweedale
On Mon, May 09, 2016 at 04:06:46PM -0400, Ade Lee wrote: > Isn't all this predicated on a schema change that adds the issuer as an > optional field for the certRecord? > The schema already exists but was unused. > Ade > > On Mon, 2016-05-09 at 17:15 +1000, Fraser Tweedale wrote: > > Hi all, > >

Re: [Pki-devel] [PATCH] 0105 Add pki-server ca-cert-db-upgrade command

2016-05-09 Thread Ade Lee
Isn't all this predicated on a schema change that adds the issuer as an optional field for the certRecord? Ade On Mon, 2016-05-09 at 17:15 +1000, Fraser Tweedale wrote: > Hi all, > > The following patch adds a pki-server subcommand for updating > certificate records to add the issuerName

[Pki-devel] [PATCH] 0105 Add pki-server ca-cert-db-upgrade command

2016-05-09 Thread Fraser Tweedale
Hi all, The following patch adds a pki-server subcommand for updating certificate records to add the issuerName attribute. It is for #1667 (Database upgrade script to add issuerName attribute to all cert entries). Follow-up question: should I (and if so, how should I) also add an upgrade