Re: [Pki-devel] [PATCH] pki-0178, jss-0000..0002 - PKCS #12 key bag AES encryption

2017-04-26 Thread Fraser Tweedale
On Tue, Apr 11, 2017 at 03:23:18PM -0700, Christina Fu wrote: > Thank you. Please see review comments: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1355358#c6 > > I will review PKCS12Util later. > > Christina > Updated patch jss-0002 and also created

Re: [Pki-devel] [PATCH] pki-0178, jss-0000..0002 - PKCS #12 key bag AES encryption

2017-04-11 Thread Christina Fu
Thank you. Please see review comments: https://bugzilla.mozilla.org/show_bug.cgi?id=1355358#c6 I will review PKCS12Util later. Christina On 04/10/2017 11:30 PM, Fraser Tweedale wrote: On Thu, Apr 06, 2017 at 03:45:55PM -0700, Christina Fu wrote: Hi Fraser, Could you please do the

Re: [Pki-devel] [PATCH] pki-0178, jss-0000..0002 - PKCS #12 key bag AES encryption

2017-04-11 Thread Fraser Tweedale
On Thu, Apr 06, 2017 at 03:45:55PM -0700, Christina Fu wrote: > Hi Fraser, > > Could you please do the following first? > > 1. file a Mozilla bugzilla bug for this against Product JSS Release 4.4.1, > then assign to yourself: > https://bugzilla.mozilla.org/ > 2. After making sure your patch

Re: [Pki-devel] [PATCH] pki-0178, jss-0000..0002 - PKCS #12 key bag AES encryption

2017-04-06 Thread Christina Fu
Hi Fraser, Could you please do the following first? 1. file a Mozilla bugzilla bug for this against Product JSS Release 4.4.1, then assign to yourself: https://bugzilla.mozilla.org/ 2. After making sure your patch compiles well with the 4.4.1 base, attach the patch to that ticket, and mark

[Pki-devel] [PATCH] pki-0178, jss-0000..0002 - PKCS #12 key bag AES encryption

2017-04-04 Thread Fraser Tweedale
Hi team, Please review attached patches for JSS and Dogtag that: - add some new EncryptedPrivateKeyInfo export and import functions to JSS - update Dogtag's `pki pkcs12' command to use the new functions to achieve AES encryption of the key bags, with wrapping/unwrapping occurring on the