Re: Review Request: config

2009-05-01 Thread Chani
> The code is correct and will work that way. But we should try to get > everyone used to do: > > KAction *configAction = actions->addAction("configure"); > configAction->setIcon(KIcon("configure")); > configAction->setText("Widget Settings")) > configAction->setShortcut(KShortcut(

Re: Review Request: config

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-01 20:28:58.289288) Review request for Plasma. Changes ---

Re: custom property of a Plasma::Applet

2009-05-01 Thread Oszkar Ambrus
> yeah, I had to do this for security stuff... uhm... > applet.cpp:1685 > > So you're saying KServiceTypeTrader::self()->query("Plasma/Applet", ... has access to the properties of the plugin? Cheers, Oszkar ___ Plasma-devel mailing list Plasma-devel

Re: custom property of a Plasma::Applet

2009-05-01 Thread Oszkar Ambrus
>> I'd like to read a custom property of a Plasma::Applet defined in the >> .desktop file. >> I've seen that the Applet class has functions for standard properties >> (like name, icon, etc. that are a subset of KPluginInfo functions). >> >> Can I read for example the X-KDE-Library entry, which is

Re: Review Request: config

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-01 19:49:49.223570) Review request for Plasma. Changes ---

Review Request: non-modal mode for KShortcutsDialog

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/652/ --- Review request for kdelibs and Plasma. Summary --- kshortcutsdialog was desi

Re: Transparent themes without composition

2009-05-01 Thread Zack Rusin
On Friday 01 May 2009 19:15:52 David Nolden wrote: > >On Friday 01 May 2009, David Nolden wrote: > >> This already looks quite nice. But since many plasma themes have a > >> glassy look, they highly profit from something more shining through > >> them, since that's the only way they can retain that

trunk

2009-05-01 Thread Sebastian Kügler
SVN commit 962278 by sebas: Move opendesktop applet to kdereview. Nobody objected, although there are now quite some pointers where to move this in the future. For those who didn't follow, we're very late for the 4.3 merge, but Marco agreed to review it in time so we can ship this functionali

Re: Transparent themes without composition

2009-05-01 Thread Aaron J. Seigo
On Friday 01 May 2009, David Nolden wrote: > >On Friday 01 May 2009, David Nolden wrote: > >> This already looks quite nice. But since many plasma themes have a > >> glassy look, they highly profit from something more shining through > >> them, since that's the only way they can retain that look. T

Re: Review Request: config

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-01 12:50:52.542081) Review request for Plasma. Changes ---

Re: Transparent themes without composition

2009-05-01 Thread Aaron J. Seigo
On Friday 01 May 2009, David Nolden wrote: > When a theme designer makes a theme transparent, then he wants something to > show through the theme. Without composition, the window manager will not > supply that background, so in order to keep it looking similar to the way > the designer has intended

RE: Transparent themes without composition

2009-05-01 Thread David Nolden
>On Friday 01 May 2009, David Nolden wrote: >> This already looks quite nice. But since many plasma themes have a glassy >> look, they highly profit from something more shining through them, since >> that's the only way they can retain that look. Transparency is not > >and if you want that, use com

Re: Review Request: FIXME part of quicklaunch

2009-05-01 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-01 13:15:49.798493) Review request for Plasma and Aaron Seigo.

Re: Systray jobs

2009-05-01 Thread Aaron J. Seigo
On Friday 01 May 2009, Rob Scheepmaker wrote: > * Auto hiding after the dialog with jobs and notifications get's > automatically shown because one get's added. Currently this is hardcoded to > 6 seconds, but there are quite some requests for having no auto hiding at > all. I do very much prefer au

Re: custom property of a Plasma::Applet

2009-05-01 Thread Chani
On May 1, 2009 09:10:52 Oszkar Ambrus wrote: > Hi, > > I'd like to read a custom property of a Plasma::Applet defined in the > .desktop file. > I've seen that the Applet class has functions for standard properties > (like name, icon, etc. that are a subset of KPluginInfo functions). > > Can I read

Re: Systray jobs

2009-05-01 Thread Chani
On May 1, 2009 09:40:00 Rob Scheepmaker wrote: > Hello all, > > I would like in discuss what things should still be improved to the way > jobs are handled in the systemtray before the freeze. These are some of the > things I noticed or are often requested: > > * Auto hiding after the dialog with jo

Re: Systray jobs

2009-05-01 Thread Marco Martin
On Friday 01 May 2009, Rob Scheepmaker wrote: > Hello all, > > I would like in discuss what things should still be improved to the way > jobs are handled in the systemtray before the freeze. These are some of the > things I noticed or are often requested: > > * Auto hiding after the dialog with job

Re: custom property of a Plasma::Applet

2009-05-01 Thread Aaron J. Seigo
On Friday 01 May 2009, Oszkar Ambrus wrote: > Hi, > > I'd like to read a custom property of a Plasma::Applet defined in the > .desktop file. > I've seen that the Applet class has functions for standard properties > (like name, icon, etc. that are a subset of KPluginInfo functions). > > Can I read f

dropping remote content vol.2

2009-05-01 Thread Sebastian Kügler
I've been hacking on dropping URLs onto Plasma again, and although I got a bit further, I'm running into problems still. Let me first explain the concept: - Something is dropped onto Plasma - we don't understand its mimetype since it's remote content - we open a QMenu stating "fetching mimetype"

Review Request: FIXME part of quicklaunch

2009-05-01 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch is regardi

Re: kdereview/plasma/dataengines/geolocation

2009-05-01 Thread Andrew Coles
> no kidding. someone needs to blog about this! I've opened a blogspot account, figure I may as well have somewhere to vent my ideas or cool things I do KDE-wise. Will write about it on there, along with where I'm up to with wireless AP geolocation. > great work, Andrew ... Thanks :). Andre

Transparent themes without composition

2009-05-01 Thread David Nolden
I want to raise a discussion here how to make transparent themes look nice without composition support. So: When a theme designer makes a theme transparent, then he wants something to show through the theme. Without composition, the window manager will not supply that background, so in order to

Systray jobs

2009-05-01 Thread Rob Scheepmaker
Hello all, I would like in discuss what things should still be improved to the way jobs are handled in the systemtray before the freeze. These are some of the things I noticed or are often requested: * Auto hiding after the dialog with jobs and notifications get's automatically shown because o

Re: KDE/kdelibs/plasma

2009-05-01 Thread Aaron J. Seigo
On Thursday 30 April 2009, Aaron J. Seigo wrote: > On Thursday 30 April 2009, David Nolden wrote: > > SVN commit 961915 by zwabel: > > > > - Allow painting a background color, or a background pattern behind > > freely floating elements of the theme, to provide a better fallback > > mechanism for tr

Re: Review Request: Patch to add free space indicator into device notifier plasmoid

2009-05-01 Thread Christopher Blauvelt
On Tue, Apr 28, 2009 at 7:29 AM, wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/632/ > --- > > (Updated 2009-04-28 04:29:44.

custom property of a Plasma::Applet

2009-05-01 Thread Oszkar Ambrus
Hi, I'd like to read a custom property of a Plasma::Applet defined in the .desktop file. I've seen that the Applet class has functions for standard properties (like name, icon, etc. that are a subset of KPluginInfo functions). Can I read for example the X-KDE-Library entry, which is not of KPl

Re: kdereview/plasma/dataengines/geolocation

2009-05-01 Thread Aaron J. Seigo
On Friday 01 May 2009, Sebastian Kügler wrote: > That rocks, good to see that the iplocationtool guys are helping so nicely. no kidding. someone needs to blog about this! great work, Andrew ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7

Using PopupApplets with script engines without subclassing them

2009-05-01 Thread Richard Dale
I recently added a PopupApplet service that allows applet scripting engines to use Plasma::PopupApplets. However, the C++ api assumes that the applet can be sub-classed, and that isn't possible with the scripting engine api. To use an ExtenderItem with an Applet you need to be able to override App

[RFC] kimpanel applet in kdereview

2009-05-01 Thread Wang Hoi
I've moved kimpanel applet into kdereview serveral weeks ago, now i'd like to ask for review. It's under kdereview/plasma/applets/kimpanel "kimpanel" is short for "KDE Input method panel (applet)", it contains a plasma applet and also a standalone app (for users which don't use KDE). It's main f

Re: kdereview/plasma/dataengines/geolocation

2009-05-01 Thread Sebastian Kügler
On Friday 01 May 2009 11:01:40 Andrew Coles wrote: > SVN commit 961956 by coles: > > After chatting to the iplocationtools.com guys, I've managed to get them to > make a change to their API so that calling without an IP, rather than > failing, returns the visitor's location information. As such, i

kdereview/plasma/dataengines/geolocation

2009-05-01 Thread Andrew Coles
SVN commit 961956 by coles: After chatting to the iplocationtools.com guys, I've managed to get them to make a change to their API so that calling without an IP, rather than failing, returns the visitor's location information. As such, if we now just go to: http://iplocationtools.com/ip_query.