Re: Review Request: Patch to add free space indicator into device notifier plasmoid

2009-05-06 Thread martin . klapetek
On 2009-05-05 15:56:22, Aaron Seigo wrote: what's the status of this patch? Almost finished, it just need a little visual polishing and also some code polishing. I've been too busy lately to finish it, but I'll post the final version tomorrow. Hopefully. - mck182

Re: Review Request: Separator widget.

2009-05-06 Thread Ivan Cukic
On 2009-05-05 15:55:37, Aaron Seigo wrote: this will have to wait for 4.4 at this point, but it seems like a good idea. any reason why this would use an svg? could we get away with a simple QPainter drawing using Theme colours? Using a hard-coded painting would be strange concerning

Re: Moving code for Open With and ServiceMenu actions to kdelibs

2009-05-06 Thread David Faure
On Tuesday 05 May 2009, Allen Winter wrote: On Tuesday 17 March 2009 4:03:03 pm David Faure wrote: The code for handling open with action/submenus and servicemenus (RMB / Actions / ...) is currently in libkonq (and used by dolphin and konqueror), but I have received a number of

sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
hi... i've been getting various bits of feedback on the notification/jobs icon in the tray, such as: * it moves icons when it appears * when it's not there there's an ugly space showing tonight i played with just always showing it, and i think this might work out. this resulted in a couple of

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Aaron J. Seigo wrote: out. this resulted in a couple of observations: two more: * the cursor should change to the clickable link hand when the job/notifications widget is visible in the system tray (i've implemented this locally already) * the dark background behind

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote: hi... i've been getting various bits of feedback on the notification/jobs icon in the tray, such as: * it moves icons when it appears * when it's not there there's an ugly space showing tonight i played with just always showing it, and i

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote: On Wednesday 06 May 2009, Aaron J. Seigo wrote: out. this resulted in a couple of observations: two more: * the cursor should change to the clickable link hand when the job/notifications widget is visible in the system tray (i've implemented

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Rob Scheepmaker
On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote: * when an extender has groups, attachedItems() will return those groups as items. in turn, that makes the don't show the popup if we have nothing in it test in PopupAppletPrivate::internalTogglePopup fail because there's always something

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Rob Scheepmaker
On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote: hi... i've been getting various bits of feedback on the notification/jobs icon in the tray, such as: * it moves icons when it appears * when it's not there there's an ugly space showing tonight i played with just always showing it,

KNotificationItem::showMessage

2009-05-06 Thread Aaron J. Seigo
hi right now KNotificationItem::showMessage creates a visual notification. while simple to achieve, i'm wondering if it should be doing something a little more like a balloon message which shows some affinity to the item in the system tray itself? otherwise the application could just make

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Marco Martin wrote: On Wednesday 06 May 2009, Aaron J. Seigo wrote: On Wednesday 06 May 2009, Aaron J. Seigo wrote: out. this resulted in a couple of observations: two more: * the cursor should change to the clickable link hand when the job/notifications

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Marco Martin wrote: i think the old info icon when the thing is not spinning would look better, makes also sense, because it says: now it's not working, but if you click here you'll get informations of course, there is no information to had at that point. maybe a

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Rob Scheepmaker wrote: On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote: * when an extender has groups, attachedItems() will return those groups as items. in turn, that makes the don't show the popup if we have nothing in it test in

Review Request: Jobs/Notifications button always visible

2009-05-06 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/675/ --- Review request for Plasma. Summary --- Make the ExtenderTask, responsible

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote: On Wednesday 06 May 2009, Marco Martin wrote: On Wednesday 06 May 2009, Aaron J. Seigo wrote: On Wednesday 06 May 2009, Aaron J. Seigo wrote: out. this resulted in a couple of observations: two more: * the cursor should change

Re: KNotificationItem::showMessage

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote: hi right now KNotificationItem::showMessage creates a visual notification. while simple to achieve, i'm wondering if it should be doing something a little more like a balloon message which shows some affinity to the item in the system tray

Re: Review Request: Jobs/Notifications button always visible

2009-05-06 Thread Rob Scheepmaker
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/675/#review1078 --- Ship it! Looks good to me... this is indeed much less 'stressfull'. I

Re: Systray jobs

2009-05-06 Thread Rob Scheepmaker
On Tuesday 05 May 2009 18:57:49 Dario Freddi wrote: There is not a DBus interface exportable, however for 4.4 it would be nice if we could remove that code from PowerDevil and put it somewhere else (ideas, anyone?) Rob, feel free to contact me for more clarification on this. I really think

Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Marco Martin wrote: (speaking of which, the opaque version of the panel provides very, very low contrast :/ ) uuh whith what? with the last area of the systray? i will make it slightly more opaque, but i think it's good if it's quite subtle actually no,

Device Notifier - Western Digital USB drive not recognised

2009-05-06 Thread Mr Fixit
I'm not sure if this is an openSUSE problem or a KDE4 problem, so please excuse me if I have posted in the wrong area. Since I updated to KDE4.2.2 my external USB drive no longer shows up in device notifier when I plug it in. CDs and other USB memory sticks work perfectly, but not my USB

Re: Review Request: Jobs/Notifications button always visible

2009-05-06 Thread Aaron Seigo
On 2009-05-06 09:03:09, Rob Scheepmaker wrote: Looks good to me... this is indeed much less 'stressfull'. I was wondering though: wouldn't it make sense to use a an enabled info icon in case there are only notifications and/or completed jobs? Still paint the number in front of it,

Re: Notifications Features

2009-05-06 Thread Celeste Lyn Paul
On Sunday 03 May 2009 03:43:42 am Marco Martin wrote: On 5/2/09, Celeste Lyn Paul cele...@kde.org wrote: Some of you may or may not remember that I've also been working on interruptions and notifications; however as part of a uni project rather than for an open source project. Part

Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Sujith H
On 2009-05-05 16:14:28, Aaron Seigo wrote: trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp, lines 379-381 http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379 the easiest way i can think of doing this (even if its not super fast,

Re: Notifications Features

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Celeste Lyn Paul wrote: On Sunday 03 May 2009 03:43:42 am Marco Martin wrote: On 5/2/09, Celeste Lyn Paul cele...@kde.org wrote: Some of you may or may not remember that I've also been working on interruptions and notifications; however as part of a uni project

Plasma crashing with QGraphicsLinearLayout.addStretch

2009-05-06 Thread Johannes Wolter
Hello, I just got started with a simple Python-based Plasma widget. Right now I'm getting segfaults I cannot explain; so maybe someone could give me a hint, whether this is really a bug or a my fault. I roughly followed an howto from techbase and everything works fine until I call addStretch

Re: Plasma crashing with QGraphicsLinearLayout.addStretch

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Johannes Wolter wrote: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xb3db9720 (LWP 11622)] 0xb741e737 in QGraphicsLayoutItem::isLayout () from /usr/lib/libQtGui.so.4 (gdb) bt #0 0xb741e737 in QGraphicsLayoutItem::isLayout () from

JS Scriptengine in libplasma

2009-05-06 Thread Leonardo Franchi
hola folks, so i'm (finally) looking into adding scripted applet/dataengine support to amarok. it's really easy and transparent and all of that (yay plasma!) but we have a minor issue. we depend only on kdelibs, and the scriptengines are in kdebase/workspace. i understand that most of them

Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Sujith H
On 2009-05-05 16:14:28, Aaron Seigo wrote: trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp, lines 379-381 http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379 the easiest way i can think of doing this (even if its not super fast,

Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Aaron Seigo
On 2009-05-05 16:14:28, Aaron Seigo wrote: trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp, lines 379-381 http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379 the easiest way i can think of doing this (even if its not super fast,

Re: JS Scriptengine in libplasma

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Leonardo Franchi wrote: *-bindings package. But moving the javascript dataengine to the plasma in kdelibs would really be nice. it would probably belong in runtime, actually. kdebase/runtime/plasma/javascript? -- Aaron J. Seigo humru othro a kohnu se GPG

Re: JS Scriptengine in libplasma

2009-05-06 Thread Leonardo Franchi
On Wednesday 06 May 2009 21:54:19 Aaron J. Seigo wrote: On Wednesday 06 May 2009, Leonardo Franchi wrote: *-bindings package. But moving the javascript dataengine to the plasma in kdelibs would really be nice. it would probably belong in runtime, actually.

Re: JS Scriptengine in libplasma

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Leonardo Franchi wrote: On Wednesday 06 May 2009 21:54:19 Aaron J. Seigo wrote: On Wednesday 06 May 2009, Leonardo Franchi wrote: *-bindings package. But moving the javascript dataengine to the plasma in kdelibs would really be nice. it would probably belong

Re: Plasma crashing with QGraphicsLinearLayout.addStretch

2009-05-06 Thread Johannes Wolter
Johannes Wolter j at inutil.org writes: I just got started with a simple Python-based Plasma widget. Right now I'm getting segfaults I cannot explain; so maybe someone could give me a hint, whether this is really a bug or a my fault. [...] Sorry I forgot... I'm using Debian (mostly

Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Sujith H
On 2009-05-05 16:14:28, Aaron Seigo wrote: trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp, lines 379-381 http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379 the easiest way i can think of doing this (even if its not super fast,