Re: Review Request: Use sunrise and sunset times from the Environment Canada weather service to set weather icon to day/night, accordingly.

2009-09-14 Thread Beat Wolf
On 2009-05-03 16:42:23, Shawn Starr wrote: It seems to be working so far, it's already committed. Beat Wolf wrote: i can't find this code in svn, is it really commited? can somebody mark this as submitted? Shawn Starr wrote: Its been redone. But we still dont have proper

Re: Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons

2009-09-14 Thread Sebastian Kügler
On Monday 14 September 2009 05:35:21 Shafqat Bhuiyan wrote: Beat Wolf wrote: is there any news on the svn account or the patch? I got my svn account sorted and it seems to work fine now :) I still have the patch on my machine and I'll commit it once I figure it how to backport

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Sebastian Kügler
On Saturday 12 September 2009 16:49:01 Alessandro Diaferia wrote: I've had a look at the code and I feel it can be merged into MediaCenterComponents since I plan to provide models to navigate through webservices like picasa, youtube and so on. As from what i've achieved with mediacenter

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Alessandro Diaferia
2009/9/14 Sebastian Kügler se...@kde.org On Saturday 12 September 2009 16:49:01 Alessandro Diaferia wrote: I've had a look at the code and I feel it can be merged into MediaCenterComponents since I plan to provide models to navigate through webservices like picasa, youtube and so on. As

Re: Review Request: big revamp of Device Notifier

2009-09-14 Thread Giulio Camuffo
On 2009-09-11 19:44:22, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, line 366 http://reviewboard.kde.org/r/1370/diff/5/?file=10962#file10962line366 this is only needed if m_showOnlyRemovable changes, correct? wrote: it

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Sebastian Kügler
On Monday 14 September 2009 12:40:36 Alessandro Diaferia wrote: 2009/9/14 Sebastian Kügler se...@kde.org On Saturday 12 September 2009 16:49:01 Alessandro Diaferia wrote: I've had a look at the code and I feel it can be merged into MediaCenterComponents since I plan to provide models to

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Alessandro Diaferia
2009/9/14 Sebastian Kügler se...@kde.org On Monday 14 September 2009 12:40:36 Alessandro Diaferia wrote: 2009/9/14 Sebastian Kügler se...@kde.org On Saturday 12 September 2009 16:49:01 Alessandro Diaferia wrote: I've had a look at the code and I feel it can be merged into

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Sebastian Kügler
On Monday 14 September 2009 14:21:38 Alessandro Diaferia wrote: I can propose a draft. I think I'll discuss about it today live together with Francesco.. I'll post the draft here as soon as i get something convincing :) Cool, looking forward to seeing it. Keep in mind that we'll want to do

Review Request: Nepomuk Virtual Folders as Background

2009-09-14 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1605/ --- Review request for Plasma. Summary --- This patch enables the use of

[PATCH] Fix annoying wallpaper list update behavior.

2009-09-14 Thread Alessandro Diaferia
As from what happens with the current approach the view that lists available wallpapers is connected to the modified() SLOT through the activated() SIGNAL. But when the global preferences are set to use Double Click you have to double click each item in the view in order to see the preview before

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Alessandro Diaferia
2009/9/14 Sebastian Kügler se...@kde.org On Monday 14 September 2009 14:21:38 Alessandro Diaferia wrote: I can propose a draft. I think I'll discuss about it today live together with Francesco.. I'll post the draft here as soon as i get something convincing :) Cool, looking forward to

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Sebastian Kügler
On Monday 14 September 2009 15:06:35 Alessandro Diaferia wrote: That's great! Do we want to keep the API on the DataEngine's query side or do we want to provide a set of inherited DataEngines such as for example Plasma::MediaContentsDataEngine ? But probably that's too much. On the one hand,

Re: Review Request: Nepomuk Virtual Folders as Background

2009-09-14 Thread Artur Souza (MoRpHeUz)
On Monday 14 September 2009, 10:28 Sebastian Kügler wrote: This is something that would also be really cool for the picture frame applet. :) That's true! It would be awesome to have picture frame applets to show different nepomuk virtual folders! :) Cheers!

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-14 Thread David Faure
[Too much cross-posting, removing kde-devel from the CC list] On Wednesday 02 September 2009, 潘卫平(Peter Pan) wrote: === --- trashimpl.cpp (revision 1018673) +++ trashimpl.cpp (working copy) @@ -771,6 +771,7 @@

Re: Review Request: Add tooltips to the SystemTray show/icon hidden icons button

2009-09-14 Thread Darío Andrés
2009/9/13 Darío Andrés andresbajotie...@gmail.com: On 2009-05-05 15:57:15, Aaron Seigo wrote: this will have to wait for 4.4 now due to the string freeze, but that will also give us time to track down the tooltip issue? :) Beat Wolf wrote:     did anybody commit this? so the bugreport

Review Request: associate an external tool to an applet

2009-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1606/ --- Review request for Plasma. Summary --- first implementation of an idea

Re: workspace/plasma filesystem reorganization

2009-09-14 Thread Marco Martin
On Sunday 13 September 2009, Marco Martin wrote: Hi all, at tokamak we talked about moving stuff around in workspace/plsma, to better distinguish between the desktop shell, the netbook shell and possibly other future things. as i mentioned in an old message, i think a hyerarchy like that

Re: Review Request: big revamp of Device Notifier

2009-09-14 Thread Aaron Seigo
On 2009-09-11 19:44:22, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, line 366 http://reviewboard.kde.org/r/1370/diff/5/?file=10962#file10962line366 this is only needed if m_showOnlyRemovable changes, correct? wrote: it

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Sebastian Kügler wrote: It would be a good idea to make the API (names of sources, returned data) generic for image webservices, so it's easier to just exchange the dataengine in the background to use a different image webservice. instead of writing N different

Re: workspace/plasma filesystem reorganization

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Marco Martin wrote: uh, and another thing: maybe the widget explorer to be another separate library, so in workspace/libs we would have libplasmagenericshell (or libplasmageneric) and libplasmawidgetexplorer why? -- Aaron J. Seigo humru othro a kohnu se GPG

QtScript bindings

2009-09-14 Thread Ian Monroe
Mark said you were interested in QtScript bindings. Do you want bindings of the chunks of the Qt api + Plamsa API? Or just a simplified subset of the Plasma API? If its the former, we should talk. :) I've started the very beginnings of a Smoke-based binding. If its the latter, then you really

Plasma wallpaper changing via D-Bus

2009-09-14 Thread Renan Cakirerk
Hi, I am trying to implement D-Bus to plasma. I'm only interested in changing the wallpaper. I've downloaded the kdebase-workspace files and kdelibs. But I don't know where to go after here. I have intermediate knowledge of d-bus and intermediate knowledge of C++. Can you point me to the right

Review Request: fix a Plasma crash with a 16-bit screen depth and Qt 4.6

2009-09-14 Thread Benjamin Stuhl
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1608/ --- Review request for Plasma. Summary --- Meke sure that Plasma only tries to

Re: workspace/plasma filesystem reorganization

2009-09-14 Thread Emdek
On 14-09-2009 at 17:38:51 Marco Martin notm...@gmail.com wrote: uh, and another thing: maybe the widget explorer to be another separate library, so in workspace/libs we would have libplasmagenericshell (or libplasmageneric) and libplasmawidgetexplorer Maybe simply libplasmashell? I think that

Re: Plasma wallpaper changing via D-Bus

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Renan Cakirerk wrote: Hi, I am trying to implement D-Bus to plasma. I'm only interested in cool; I believe Ivan has started on d-bus introspection into plasma. what are your use case(s) for this? (that can impact how this is implemented) the short story for how d-bus

Re: [PATCH] Fix annoying wallpaper list update behavior.

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Alessandro Diaferia wrote: Is it ok for you to commit it? +1 -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a

Re: Review Request: fix a Plasma crash with a 16-bit screen depth and Qt 4.6

2009-09-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1608/#review2360 ---

Re: QtScript bindings

2009-09-14 Thread Tommi Mikkonen
Hi Guys, What I'd personally like to do is to create the same stuff downloadable at lively.cs.tut.fi/qt inside a plasmoid using plain JavaScript. In essence everything that runs in a separate window could be a plasmoid, to the extend that I could create a debugging plasmoid for some other

Re: MediaCenterComponents - Picasa Engine

2009-09-14 Thread Alessandro Diaferia
2009/9/14 Aaron J. Seigo ase...@kde.org On September 14, 2009, Sebastian Kügler wrote: It would be a good idea to make the API (names of sources, returned data) generic for image webservices, so it's easier to just exchange the dataengine in the background to use a different image

Re: QtScript bindings

2009-09-14 Thread Ian Monroe
We already talked about this on IRC, so just recording for everyone else. On Mon, Sep 14, 2009 at 12:14 PM, Aaron J. Seigo ase...@kde.org wrote: On September 14, 2009, Ian Monroe wrote: Do you want bindings of the chunks of the Qt api + Plamsa API? Or just a simplified subset of the Plasma

Re: QtScript bindings

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Tommi Mikkonen wrote: What I'd personally like to do is to create the same stuff downloadable at lively.cs.tut.fi/qt inside a plasmoid using plain JavaScript. In once we have full qt/kdelibs bindings available to us, this should be trivial. it would be really interesting

Re: QtScript bindings

2009-09-14 Thread Tommi Mikkonen
Aaron J. Seigo wrote: On September 14, 2009, Tommi Mikkonen wrote: What I'd personally like to do is to create the same stuff downloadable at lively.cs.tut.fi/qt inside a plasmoid using plain JavaScript. In once we have full qt/kdelibs bindings available to us, this should be

Re: QtScript bindings

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Tommi Mikkonen wrote: Having said that, what I would also like is a harmonized API; having finally spend some hours tonight (after traveling in conferences for some weeks!) on JS Plasmoid development with Lively content, I constantly seem to have problems on the names of

Re: QtScript bindings

2009-09-14 Thread Tommi Mikkonen
Aaron J. Seigo wrote: On September 14, 2009, Tommi Mikkonen wrote: Having said that, what I would also like is a harmonized API; having finally spend some hours tonight (after traveling in conferences for some weeks!) on JS Plasmoid development with Lively content, I constantly seem to

KDE/kdebase/workspace/plasma

2009-09-14 Thread Marco Martin
SVN commit 1023511 by mart: move stuff around: all containments,applets etc are in the subdirectory of their topic: that is

Re: KDE/kdebase/workspace/plasma

2009-09-14 Thread Marco Martin
On Monday 14 September 2009, Marco Martin wrote: SVN commit 1023511 by mart: move stuff around: all containments,applets etc are in the subdirectory of their topic: that is generic: stuff that is condivided among different shells desktop: desktop shell specific netbook: shell,

Re: [PATCH] Fix annoying wallpaper list update behavior.

2009-09-14 Thread Shaun Reich
On Mon, Sep 14, 2009 at 4:57 PM, Aaron J. Seigo ase...@kde.org wrote: On September 14, 2009, Alessandro Diaferia wrote: Is it ok for you to commit it? +1 -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43 KDE core developer

Re: Review Request: big revamp of Device Notifier

2009-09-14 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-09-14 21:26:48.596052) Review request for Plasma. Changes

Re: [PATCH] Fix annoying wallpaper list update behavior.

2009-09-14 Thread Alessandro Diaferia
2009/9/14 Shaun Reich predator...@gmail.com Also, the problem(imho) , is that with the Open File Dialog, last time I checked, did not select(click), the item that you have just chosen in that dialog... this is not related, right? Because I'd really like that problem fixed... it's kind of

Re: [PATCH] Fix annoying wallpaper list update behavior.

2009-09-14 Thread Alessandro Diaferia
2009/9/14 Alessandro Diaferia alediafe...@gmail.com 2009/9/14 Shaun Reich predator...@gmail.com Also, the problem(imho) , is that with the Open File Dialog, last time I checked, did not select(click), the item that you have just chosen in that dialog... this is not related, right? Because

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-14 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/ --- (Updated 2009-09-14 23:24:56.419041) Review request for Plasma and Shawn Starr.

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-14 Thread Amos Kariuki
On 2009-09-13 22:28:30, Shawn Starr wrote: It looks fine, but please make sure any new strings are wrapped in proper i18n(). I cannot approve this commit until that's please. spstarr: I think the only think that needed to be internationalized was the weather summary so correct me if I'm

Re: Review Request: big revamp of Device Notifier

2009-09-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2366 --- Ship it! this can go in as a draft of what will be there for 4.4

Re: QtScript bindings

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Tommi Mikkonen wrote: can you provide some concrete examples? QFrame vs. Frame and QWebView vs. Webview is QtScriptGenerator and Plasmoids, Frame is not a QFrame, it's a Plasma::Frame. WebView is not a QWebView, it's a Plasma::WebView. and at the same time

Re: KDE/kdebase/workspace/plasma

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Chani wrote: also, in moving i noticed the screensaver shell still tried to include and use appletbrowser.h, i really wonder why it was still building. now those parts are just commented out but a port is badly needed. ah crud. :/ I don't know if I'll have time for

Re: KDE/kdebase/workspace/plasma

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Marco Martin wrote: SVN commit 1023511 by mart: move stuff around: i really don't like the shells/ directories. plasma/netbook/shells/netbook/ plasma/desktop/shells/desktop/ plasma/screensaver/shells/screensaver that's all very redundant. there are no other entries in

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-14 Thread 潘卫平(Peter Pan)
David Faure 写道: [Too much cross-posting, removing kde-devel from the CC list] On Wednesday 02 September 2009, 潘卫平(Peter Pan) wrote: === --- trashimpl.cpp (revision 1018673) +++ trashimpl.cpp (working copy) @@

Any easy way to add picture frame programmatically?

2009-09-14 Thread Reza Shah
Hi, I want to add picture frame programmatically and set it content to user selected image. For example my program (not a plasmoid) has a list view which contains image thumbnails, right click on an image, then invoke add picture frame function. Can somebody give clues? Regards, Reza

Re: [PATCH] BUG 202473 no sound on emptying trash widget although sound is configured in systemsettings

2009-09-14 Thread 潘卫平(Peter Pan)
潘卫平(Peter Pan) 写道: Aaron J. Seigo 写道: On September 1, 2009, 潘卫平(Peter Pan) wrote: How about the patch followed? the applet would need to follow the contents of trash:/ then, so when a file is trashed in dolphin, konqueror or some other app it would become enabled. That has been already

Re: Any easy way to add picture frame programmatically?

2009-09-14 Thread Aaron J. Seigo
On September 14, 2009, Reza Shah wrote: Can somebody give clues? short answer: plasma is not ready for this. longer answer: letting external applications place content and/or widgets into the running desktop is really asking for problems and general abuse. we already support extensive drag

Re: Review Request: associate an external tool to an applet

2009-09-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1606/#review2367 --- /trunk/KDE/kdelibs/plasma/applet.h