Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Davide Bettio
On 2009-09-21 13:41:29, Thorsten Staerk wrote: Good to see you working on my baby ktimetracker. Let's have a discussion on irc. Davide Bettio wrote: ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find me in #plasma. Thorsten Staerk wrote:

Re: Ayatana notifications for Plasma

2009-09-28 Thread Aurélien Gâteau
Sebastian Kügler wrote: On Thursday 24 September 2009 09:16:25 Aurélien Gâteau wrote: Aaron J. Seigo wrote: On September 23, 2009, Aurélien Gâteau wrote: Aaron J. Seigo a écrit : On September 23, 2009, Marco Martin wrote: every other consideration aside, i feel that it would have been -far-

Re: Review request: Container plasma applet

2009-09-28 Thread Riccardo Iaconelli
On Monday 28 September 2009 05:20:06 Aaron J. Seigo wrote: first thought i have is that if there are different svg's for different sizes, let's put those different svg's in a file and use them. Yup! I think that Marco is a bit too much optimistic too, but details follow in the mail answering

Re: Review request: Container plasma applet

2009-09-28 Thread Riccardo Iaconelli
On Sunday 27 September 2009 23:19:41 Sebastian Kügler wrote: [...] The problem might be that the battery.svg has not been touched by an artist in two years. I've hacked an icon's SVG from lng ago into the battery.svg theme. I'm bad at Inkscape today, and I certainly had any concept of

Re: Ayatana notifications for Plasma

2009-09-28 Thread Sebastian Kügler
On Monday 28 September 2009 15:03:05 Aurélien Gâteau wrote: Sebastian Kügler wrote: On Thursday 24 September 2009 09:16:25 Aurélien Gâteau wrote: Aaron J. Seigo wrote: On September 23, 2009, Aurélien Gâteau wrote: Aaron J. Seigo a écrit : On September 23, 2009, Marco Martin wrote:

Re: Review request: Container plasma applet

2009-09-28 Thread Riccardo Iaconelli
On Sunday 27 September 2009 23:58:56 Marco Martin wrote: to summarize, here there are 3 problems: i don't think good pixel alignment could be reached using just svg, no matter how good the renderer is (unless we will have someday something as crazy as the truetype hinting language,

Re: Review request: Container plasma applet

2009-09-28 Thread Riccardo Iaconelli
On Sunday 27 September 2009 21:10:44 Marco Martin wrote: this depends from the idea of having in the systray having only system and hardware items, with all applications moved in the taskbar and maybe the network ones in some kind of different area... otherwise yes, wouldn't look

Re: Ayatana notifications for Plasma

2009-09-28 Thread Roderick B. Greening
I wonder if it would be worthwhile for Sebastian and Aurelien to get together and chat offline. I see some opportunity for clarification in a one-on-one via irc, etc. I believe we had some great discussions at UDS and Sebastian was awesome at helping provide guidance to Aurelien at the time.

Re: Review request: Container plasma applet

2009-09-28 Thread Sebastian Kügler
On Monday 28 September 2009 16:44:09 Riccardo Iaconelli wrote: - bad quality of battery.svg nah, not battery.svgz, i think we can't get much better than that :-) It's oxygen after all! :P Have you actually opened the file in inkscape and looked at it? Even Nuno told me repeatedly that

Re: About PlasMate metadata editing

2009-09-28 Thread Yuen Hoe Lim
Hi Diego, Actually my chinese given name is 'Yuen Hoe' and not just 'Yuen' :P Think it's easier to just call me Jason or moofang? Anyway the editor code was already written to include the metadata file as a selectable item before I stepped in - but there was a bug in the code that caused

Re: Ayatana notifications for Plasma

2009-09-28 Thread Sebastian Kügler
On Monday 28 September 2009 17:01:34 Roderick B. Greening wrote: I wonder if it would be worthwhile for Sebastian and Aurelien to get together and chat offline. I see some opportunity for clarification in a one-on-one via irc, etc. Not sure, it sounds like you see personal issues between

Re: About PlasMate metadata editing

2009-09-28 Thread Shantanu Tushar Jha
Also, a short note to Diego, please send/CC all mails to the mailing list itself so that everybody can share views. This is what mailing lists are for. Cheers ! On Mon, Sep 28, 2009 at 8:37 PM, Yuen Hoe Lim yuenho...@gmail.com wrote: Hi Diego, Actually my chinese given name is 'Yuen Hoe' and

Re: Ayatana notifications for Plasma

2009-09-28 Thread Roderick B. Greening
On Monday 28 September 2009 17:01:34 Roderick B. Greening wrote: I wonder if it would be worthwhile for Sebastian and Aurelien to get together and chat offline. I see some opportunity for clarification in a one-on-one via irc, etc. Not sure, it sounds like you see personal issues

Re: About PlasMate metadata editing

2009-09-28 Thread Aaron J. Seigo
On September 28, 2009, Yuen Hoe Lim wrote: I agree that the current method of editting metadata is bad, but I think that we should nonetheless make it possible to edit the metadata file - experienced developers should be able to use plasmate as well. I remember an idea floating around to

Re: Review Request: Center tool tips in Plasma

2009-09-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/#review2486 --- Ship it! :) - Aaron On 2009-09-27 13:18:54, Michal Dutkiewicz

Re: Review Request: Allows selection of icons using the SHIFT key.

2009-09-28 Thread Shantanu Tushar Jha
If this might be useful, please review. Thanks :) On Thu, Sep 24, 2009 at 10:07 PM, Shantanu Tushar Jha jhahon...@gmail.comwrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1709/

Re: Review request: Container plasma applet

2009-09-28 Thread Riccardo Iaconelli
On Monday 28 September 2009 17:06:07 Sebastian Kügler wrote: Have you actually opened the file in inkscape and looked at it? Even Nuno told me repeatedly that it's crap. Can't argue with that. Maybe he was talking of something else? Like the rendering in the panel? I confirm that's the

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Thorsten Staerk
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2487 --- I dislike if libraries change, like this change from KSystemTray to

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/ --- (Updated 2009-09-28 20:26:09.228700) Review request for Plasma, Aaron Seigo and

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-28 Thread Aaron Seigo
On 2009-09-04 20:16:52, Aaron Seigo wrote: this results in a leak in that every window ever created will have an item that stays forever, no? shouldn't it only keep track of winIds that still exist, and do so in the manual grouping strategy? Christian Mollekopf wrote: Yes this

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Aaron Seigo
On 2009-09-28 19:13:17, Thorsten Staerk wrote: I dislike if libraries change, like this change from KSystemTray to KNotification or however this is called ... Here is your patch as I would like to commit: emTrayIcon( 0 ) +

Review Request: Full Konqueror History Runner

2009-09-28 Thread Jon de Andres
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1719/ --- Review request for Plasma. Summary --- The browserhistory runner in

Re: 'Next wallpaper' functionality for image plugin?

2009-09-28 Thread Chani
On September 26, 2009 11:03:37 Aaron J. Seigo wrote: On September 26, 2009, Yuen Hoe Lim wrote: the wallpaper plugin doesn't have control over the right-click-desktop context menu, and it will be inappropriate to hack the functionality into the core desktop code. that's correct; but we

Review Request: contextmenu on popupapplets

2009-09-28 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1737/ --- Review request for Plasma. Summary --- when I rightclick a popupapplet, I

Re: About PlasMate metadata editing

2009-09-28 Thread Yuen Hoe Lim
there already is one in plasmate/editors/metadata; it just needs to be used. Ok! Will look into it. By the way while we're on the topic, I find the current way the editor works (click on tree widget item, tree *disappears* to be replaced with katepart/editor) rather unintuitive and weird. I

Re: About PlasMate metadata editing

2009-09-28 Thread Aaron J. Seigo
On September 28, 2009, Yuen Hoe Lim wrote: which had the tree and the editor *side by side* instead, and I think this that was the original idea, yes. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by

Re: Review Request: contextmenu on popupapplets

2009-09-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1737/#review2494 --- yes, please make this private API, otherwise, it's good to go from my

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Thorsten Staerk
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2495 --- Ship it! I committed the change, see