Re: Review Request: Allows selection of icons using the SHIFT key.

2009-10-04 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1709/ --- (Updated 2009-10-04 13:46:56.620748) Review request for Plasma and Fredrik

Re: Review Request: WebView Kinetic Scrolling

2009-10-04 Thread Kenneth Christiansen
this whas added to achieve scrolling by flicking (even in an animate way, by dragging fastly the webview and launching it) right now is done by a private class (right now with timers, will be ported to kinetic) that sets the scrollvalue properties to achieve that. seems a sane approach? So

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: On Sunday 04 October 2009 12:36:49 you wrote: **Please notice that there is a OLD devicenotifier in kdereview; make sure you grab the right one** This is a joke right? Can't the plasma team make their mind up and remove the old one if it's

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you think! i still don't see the need for either of the popup control options. why should we care how long it

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Giulio Camuffo
2009/10/4 Aaron J. Seigo ase...@kde.org On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you think! i still don't see the need for either of the popup

Re: Review Request: WebView Kinetic Scrolling

2009-10-04 Thread Marco Martin
On Sunday 04 October 2009, Kenneth Christiansen wrote: this whas added to achieve scrolling by flicking (even in an animate way, by dragging fastly the webview and launching it) right now is done by a private class (right now with timers, will be ported to kinetic) that sets the

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you think! with options out of the way :) some thoughts on the plasmoid itself: * it still says Devices recently

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Giulio Camuffo
In data domenica 04 ottobre 2009 17:53:24, Aaron J. Seigo ha scritto: : On October 4, 2009, Giulio Camuffo wrote: the point of this thing is as a device *notifier*. it's not just a device *lister*. but in the real world the main point of this applet is to access the devices, because

Re: Review Request: Delays ensureRectVisible() to allow the widget to resize

2009-10-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1759/#review2542 --- Ship it! to me is ok, just that small issue below

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you think! with options out of the way :) some

Re: Adjustable Clock, Spell Check and Window List applets moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Emdek wrote: Hello I've moved Adjustable Clock, Spell Check and Window List applets to kdereview some minutes ago. I want to move them to kdeplasma-addons or extragear eventually. Adjustable Clock is a clock that uses WebKit to render advanced date and time formats

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Giulio Camuffo wrote: yes, but someone could find the popup coming without asking annoying, while simply a click would be enough. i can imagine any number of things being annoying to someone out there. if that is the measure for when an option should be included,

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
* when an item is expanded, should the background remain painted? it might make it more evident that the item is open, and it would also allow a way to solve the next point, too. (and if the background remains, perhaps the capacity bar should too?) Now that I think some more about it...

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 22:31:49 Aaron J. Seigo wrote: * when an item is expanded, should the background remain painted? it might make it more evident that the item is open, and it would also allow a way to solve the next point, too. (and if the background remains, perhaps the

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Sebastian Kügler
On Sunday 04 October 2009 18:52:34 Giulio Camuffo wrote: 2009/10/4 Aaron J. Seigo ase...@kde.org On October 4, 2009, Jacopo De Simoi wrote: now, we believe that it is ready for merging into trunk. Of course we need your feedback first, so grab it, try it out and tell us what you