Re: plasma+nepomuk activities, take N

2009-10-16 Thread Sebastian Kügler
On Thursday 15 October 2009 21:40:34 Ivan Čukić wrote: I'd still like to see a minimal implementation of this to already get used to having this kind of stuff. So please, don't postpone. Plasma is not the only potential user of this ... Heh, Sebas, you haven't read the rest of the mails

Review Request: custom toolbox support

2009-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1861/ --- Review request for Plasma. Summary --- this adds a setToolboxItem

Re: Moved kill runner to kdereview

2009-10-16 Thread Aaron J. Seigo
On October 16, 2009, Jan Gerrit Marker wrote: Hello 2009/10/16 Aaron J. Seigo ase...@kde.org i've made a few changes to it, but i think it's ready to go now. i'd like to see this in kdebase/workspace/generic/runners Thanks for the corrections :) So shall I move it there? it should

Re: Review Request: use QGraphicsOpacityEffect in FadeAnimation

2009-10-16 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1860/#review2666 --- why are there data members not in a dptr in an exported class?

Moved runner Amarok to kdereview

2009-10-16 Thread Jan Gerrit Marker
Hello, I have moved a runner called Amarok into kdereview. It is in plasma/runners/amarok. I added it to the CMakeLists.txt file, too. I want it to go into the KDE libs. Cheers, Jan Gerrit Marker (jangmarker) ___ Plasma-devel mailing list

Re: Review Request: use QGraphicsOpacityEffect in FadeAnimation

2009-10-16 Thread Giulio Camuffo
On 2009-10-16 16:07:51, Aaron Seigo wrote: why are there data members not in a dptr in an exported class? you're right, i didn't think about it. i'll create a FadeAnimationPrivate On 2009-10-16 16:07:51, Aaron Seigo wrote: /trunk/KDE/kdelibs/plasma/animations/fade.cpp, line 47

Re: Review Request: use QGraphicsOpacityEffect in FadeAnimation

2009-10-16 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1860/ --- (Updated 2009-10-16 16:49:53.459654) Review request for Plasma and Adenilson

Re: Moved runner Amarok to kdereview

2009-10-16 Thread Aaron J. Seigo
hi Jan ... On October 16, 2009, Jan Gerrit Marker wrote: I have moved a runner called Amarok into kdereview. It is in plasma/runners/amarok. I added it to the CMakeLists.txt file, too. I want it to go into the KDE libs. first, the administrative details (i know, booring ;): * you need

Re: Review Request: custom toolbox support

2009-10-16 Thread Marco Martin
On 2009-10-16 17:29:58, Aaron Seigo wrote: the internal toolbox should just move to the properties system as well, and then we don't need two pointers, two code paths, etc. the only trick will be hooking up addToolBoxAction properly. options are: we export a basic ToolBox class

Re: Moved runner Amarok to kdereview

2009-10-16 Thread Jan Gerrit Marker
Hello, * you need to send an announcement to kde-core-de...@kde.org as well Done that. Marco Martin forwarded my mail about the Kill runner to it, so I've done that this time. But I'm not subscribed so it will need some time. Will change my subscription later... * runners can go into kdebase,

Re: Review Request: custom toolbox support

2009-10-16 Thread Aaron Seigo
On 2009-10-16 17:29:58, Aaron Seigo wrote: the internal toolbox should just move to the properties system as well, and then we don't need two pointers, two code paths, etc. the only trick will be hooking up addToolBoxAction properly. options are: we export a basic ToolBox class

Date format in Digital Clock applet

2009-10-16 Thread John Layt
There's a number of bugs accumulating for the formatting of the date in the Digital Clock, most of which are dupes which I'll close: https://bugs.kde.org/show_bug.cgi?id=162368 https://bugs.kde.org/show_bug.cgi?id=195837 https://bugs.kde.org/show_bug.cgi?id=197776

Review Request: add virtual desktop action for pager

2009-10-16 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1872/ --- Review request for Plasma. Summary --- just a simple addition: you can now

Re: Date format in Digital Clock applet

2009-10-16 Thread Aaron J. Seigo
On October 16, 2009, John Layt wrote: Personally I think 4 sounds the best for now from the viewpoint of keeping it simple but still allowing some choice. If anyone wants to have a go at 5) for System Settings for Date and Time formats that would be super :-) agreed on all points. --