Re: widget snap

2010-01-02 Thread Sebastian Kügler
On Saturday 02 January 2010 10:56:37 Marco Martin wrote: On Saturday 02 January 2010, Roman Shtylman wrote: I was sitting around trying to organize some of my plasmoids... and realized that you can't easily make a stack of plasmoids all exactly aligned ... at least not that I could figure

Re: widget snap

2010-01-02 Thread Marco Martin
On Saturday 02 January 2010, Sebastian Kügler wrote: On Saturday 02 January 2010 10:56:37 Marco Martin wrote: On Saturday 02 January 2010, Roman Shtylman wrote: I was sitting around trying to organize some of my plasmoids... and realized that you can't easily make a stack of plasmoids all

Re: Weather plasmoids ...

2010-01-02 Thread Sebastian Kügler
On Saturday 02 January 2010 02:13:14 Aaron J. Seigo wrote: On January 1, 2010, Hans Chen wrote: Also, due to a change in the BBC feeds (as far as I know), the search in some weather widgets are broken. This is fixed in 4.4, but since yawp etc. have their own release cycle they're likely

Re: widget snap

2010-01-02 Thread Roman Shtylman
The downside I saw with putting it into the DestopContainment was that handling things like snap on resize become much harder because the resize event has already happened for the plasmoid. To snap on resize, you have to adjust the new size during the resize event. Also, the information about what

Re: Review Request: Show the currently selected sensor in bubblemon applet settings

2010-01-02 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2464/#review3558 --- Ship it! Ok, seems to be good. Can be committed after feature freeze

Re: Review Request: Show the currently selected sensor in bubblemon applet settings

2010-01-02 Thread Beat Wolf
On 2010-01-02 18:04:46, Shantanu Tushar Jha wrote: Ok, seems to be good. Can be committed after feature freeze is over. i would say that this is a bugfix and can be committed now, hopefully before rc1 is tagged - Beat --- This is

Re: widget snap

2010-01-02 Thread Marco Martin
On Saturday 02 January 2010, Roman Shtylman wrote: The downside I saw with putting it into the DestopContainment was that handling things like snap on resize become much harder because the resize event has already happened for the plasmoid. To snap on resize, you have to adjust the new size

Re: how can I access DataEngines from JavaScript in the Web Plasmoids?

2010-01-02 Thread Patrick Aljord
On Fri, Jan 1, 2010 at 8:56 PM, Aaron J. Seigo ase...@kde.org wrote: requires today's trunk for everything to work perfectly enjoy. thanks, today's trunk is what will become kde 4.4 right? Or has that moved to a branch already? ___ Plasma-devel

Re: Review Request: Show the currently selected sensor in bubblemon applet settings

2010-01-02 Thread Shantanu Tushar Jha
On 2010-01-02 18:04:46, Shantanu Tushar Jha wrote: Ok, seems to be good. Can be committed after feature freeze is over. Beat Wolf wrote: i would say that this is a bugfix and can be committed now, hopefully before rc1 is tagged Committed revision 1069074. Close the review as

Re: how can I access DataEngines from JavaScript in the Web Plasmoids?

2010-01-02 Thread Petri Damstén
On Saturday 02 January 2010 03:56:48 Aaron J. Seigo wrote: On January 1, 2010, Patrick Aljord wrote: I just read a comment by Aaron saying that DataEngines can be accesed from JavaScript in the Web Plasmoids. I tried to figured how it can be done but couldn't so far. Any clue? :)

Re: KDE/kdebase/workspace/plasma/generic/scriptengines/webkit

2010-01-02 Thread Aaron J. Seigo
On January 2, 2010, Petri Damstén wrote: On Saturday 02 January 2010 03:55:40 Aaron J. Seigo wrote: SVN commit 1068805 by aseigo: make DataEngines work again For webkit pasmoids dataEngine, config and globalConfig are already exposed in plasmawebapplet.h. Is this for some other use?

Re: how can I access DataEngines from JavaScript in the Web Plasmoids?

2010-01-02 Thread Aaron J. Seigo
On January 2, 2010, Petri Damstén wrote: On Saturday 02 January 2010 03:56:48 Aaron J. Seigo wrote: On January 1, 2010, Patrick Aljord wrote: I just read a comment by Aaron saying that DataEngines can be accesed from JavaScript in the Web Plasmoids. I tried to figured how it can be

Re: widget snap

2010-01-02 Thread Aaron J. Seigo
On January 1, 2010, Roman Shtylman wrote: I was sitting around trying to organize some of my plasmoids... and realized that you can't easily make a stack of plasmoids all exactly aligned ... at least not that I could figure out. I thought it would snapping is a nice idea. putting it in the

Re: widget snap

2010-01-02 Thread Marco Martin
On Saturday 02 January 2010, Aaron J. Seigo wrote: On January 1, 2010, Roman Shtylman wrote: I was sitting around trying to organize some of my plasmoids... and realized that you can't easily make a stack of plasmoids all exactly aligned ... at least not that I could figure out. I thought

Re: widget snap

2010-01-02 Thread Roman Shtylman
Aaron: I will make those style changes (was not aware of the coding style page and tried to make it match as much as possible to what I saw). The reason for the x1...y4 is to avoid doing the calculation twice (in your example to fix it you still had the x1 there and that calculation would have