Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

2010-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5580/#review8073 --- The reported preferredSize is not bounded by the maximumSize.

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

2010-10-11 Thread Ingomar Wesp
On 2010-10-11 08:34:14, Marco Martin wrote: The reported preferredSize is not bounded by the maximumSize. you don't have to call maximumSize(), it's the hardcoded overriding size hint that you can set from the outside ith setMaximumSize. you just have to obtain it in hte same

Re: Review Request: Startup Feedback KWin Effect

2010-10-11 Thread Lubos Lunak
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/#review8075 --- Ship it! Seems ok. - Lubos On 2010-10-06 08:44:46, Martin

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

2010-10-11 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5580/ --- (Updated 2010-10-11 13:06:24.092922) Review request for Plasma. Changes

Move kdeplasma-addons to Git

2010-10-11 Thread Artur de Souza
Hello :) I had some spare time and started to play with the Git migration. Regarding the Plasma stuff, I thought that kdeplasma-addons would be an easier repo to start :). So, while looking at it's log I saw that there are some modules that were imported from playground at beginning as

Re: Move kdeplasma-addons to Git

2010-10-11 Thread Ivan Cukic
I had some spare time and started to play with the Git migration. Regarding the Plasma stuff, I thought that kdeplasma-addons would be an easier repo to start :). IIRC, there was a big move from playground to kdeplasma-addons in the beginning and it was all done by a single commit by

Re: Move kdeplasma-addons to Git

2010-10-11 Thread Artur de Souza
Quoting Marco Martin notm...@gmail.com: it would just be a bit more difficult to track eventual bugs on those recent things: what would be the most recent/problematic ones? I didn't try one by one to track if there is any recent/problematic :) But most of the stuff in this module came from

Re: Move kdeplasma-addons to Git

2010-10-11 Thread Artur de Souza
Quoting Ivan Cukic ivan.cu...@kde.org: IIRC, there was a big move from playground to kdeplasma-addons in the beginning and it was all done by a single commit by Aaron. But it is ancient history - it happened before 4.1 (maybe even before 4.0?). True. I can see this commit in the log. As

Re: Move kdeplasma-addons to Git

2010-10-11 Thread Artur de Souza
Quoting Marco Martin notm...@gmail.com: to me the problem is mostly those that came in in 4.5 - 4.6 but i don't remember at the moment if there is any. the other ones i think have enough history to track potential recently inserted bugs. as ivan said, the changes done in ancient history

Review Request: Fifteen puzzle config dialog upgrade

2010-10-11 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/ --- Review request for Plasma. Summary --- This patch fixes some usability