Review Request: Use Config to Provide Activity Icons

2012-05-21 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105008/ --- Review request for Plasma and Ivan Čukić. Description --- Since we ca

Re: A folderview QGraphicsView related bug

2012-05-21 Thread Aaron J. Seigo
On Friday, May 18, 2012 22:28:47 Ignat Semenov wrote: > Now the questions are: > 1)Why do we need to iterate through the views like this? Anything more > elegant in the Plasma library? i don't know if it is more elegant in the implementation, but there is QGraphicsView *Plasma::viewFor(const QGra

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Mark Gaiser
> On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: > > Ehm, sorry for nitpicking but why is shipping allowed? > > It (probably) can't be closed by pressing CTRL+Q and the glow hover is > > missing... > > > > There is an import to import org.kde.plasma.graphicswidgets 0.1 as > > PlasmaWidgets wh

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Greg T
> On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: > > Ehm, sorry for nitpicking but why is shipping allowed? > > It (probably) can't be closed by pressing CTRL+Q and the glow hover is > > missing... > > > > There is an import to import org.kde.plasma.graphicswidgets 0.1 as > > PlasmaWidgets wh

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/ --- (Updated May 21, 2012, 6:46 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Avoid multiple map - engine connections

2012-05-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105003/#review14021 --- Ship it! code wise looks good, the code also looked it was cau

Re: Review Request: Avoid multiple map - engine connections

2012-05-21 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105003/ --- (Updated May 21, 2012, 1:51 p.m.) Review request for Plasma and Aaron J. S

Review Request: Avoid multiple map - engine connections

2012-05-21 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105003/ --- Review request for Plasma and Aaron J. Seigo. Description --- This fi

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Mark Gaiser
> On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: > > Ehm, sorry for nitpicking but why is shipping allowed? > > It (probably) can't be closed by pressing CTRL+Q and the glow hover is > > missing... > > > > There is an import to import org.kde.plasma.graphicswidgets 0.1 as > > PlasmaWidgets wh