Re: qml systemtray: small refactorings

2012-10-25 Thread Aaron J. Seigo
On Friday, October 26, 2012 10:04:24 Dmitry Ashkadov wrote: > Thank you for your answer. What workflow does KDE team use to bring > changes from master branch to KDE4.X branch? For example, some fixes > should be applied to master and KDE4.X branches at the same time. if they are bug fixes, then t

Re: qml systemtray: small refactorings

2012-10-25 Thread Dmitry Ashkadov
26.10.2012 09:51, Luca Beltrame пишет: In data venerdì 26 ottobre 2012 09:40:25, Dmitry Ashkadov ha scritto: branch should I use to make some refactoring/changes? As I know today 4.10 branch must be created. Today marks the *soft* feature freeze: in other words, not yet frozen for new features

Re: qml systemtray: small refactorings

2012-10-25 Thread Luca Beltrame
In data venerdì 26 ottobre 2012 09:40:25, Dmitry Ashkadov ha scritto: > branch should I use to make some refactoring/changes? As I know today > 4.10 branch must be created. Today marks the *soft* feature freeze: in other words, not yet frozen for new features, there's just a limit to new features

Re: qml systemtray: small refactorings

2012-10-25 Thread Dmitry Ashkadov
26.10.2012 00:43, Aaron J. Seigo пишет: hi... i suppose this is mostly for Dmitry, but its nice to have these discussions here :) so .. system tray plasmoid. works pretty well it seems. :) Hello! Thank you for your questions! But first of all, I'd like to know what branch should I use to ma

re: move plasma tools to plasmate

2012-10-25 Thread Shaun Reich
(changing title as the other thread was freaking huge and a bit bikesheddy). seems the man-plasmaenginexplorer in workspace/doc/plasma-desktop has not been moved out, along with the tool itself in that move, tereitor, care to fix? (i don't have that cloned) -- Shaun Reich, KDE Software Developer

qml systemtray: small refactorings

2012-10-25 Thread Aaron J. Seigo
hi... i suppose this is mostly for Dmitry, but its nice to have these discussions here :) so .. system tray plasmoid. works pretty well it seems. :) started looking through the code a bit more deeply and i think we can start to tighten it up a bit. for example, it seems that TasksPool duplica

Review Request: Convert file content to local encoding before uploading text file in the "share" dataengine

2012-10-25 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107044/ --- Review request for Plasma. Description --- When dragging a text file

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Aaron J. Seigo
> On Oct. 25, 2012, 11:36 a.m., Aaron J. Seigo wrote: > > the real fix here is to not use IconWidget :) that's a QGraphicsWidget > > thing and will need to be replaced eventually anyways. > > > > this should be using the Button QML element, which does support using SVG > > files. > > Dmitry A

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106244/#review20913 --- Ship it! i've fixed the bug being worked around as noted below

Re: Review Request: Fix ReferenceErrors in ListItem

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20874 --- This review has been submitted with commit 6fe8ee6ed91ac087177

Re: Review Request: Fix screenChanged signal in javascript appletinterface

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106936/#review20873 --- This review has been submitted with commit 51398decee51459120d

Re: Review Request: Fix screenChanged signal in javascript appletinterface

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106936/#review20872 --- This review has been submitted with commit 42a30676af53614da0c

Re: Review Request: Fix ReferenceErrors in ListItem

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20871 --- This review has been submitted with commit 602968b41655fdefba0

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Dmitry Ashkadov
> On Oct. 25, 2012, 11:36 a.m., Aaron J. Seigo wrote: > > the real fix here is to not use IconWidget :) that's a QGraphicsWidget > > thing and will need to be replaced eventually anyways. > > > > this should be using the Button QML element, which does support using SVG > > files. IconWidget s

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-25 Thread Ural Mullabaev
Hi Andreas! > Much more readable now, great. Still it should obey the theme text > color which > is black instead of while. See sebas suggestion: I set color for text from theme. And I detected black font with shadow too dark on the light background. I had to switch off shadows. > Another featur

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/#review20863 --- the real fix here is to not use IconWidget :) that's a QGraphic

Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106978/#review20847 --- there are a number of style issues with this patch, but the rea

Re: Testing several plasmoid instances at the same time

2012-10-25 Thread Giorgos Tsiapaliokas
On 25 October 2012 11:47, Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 22:25:12 Michał 'rysiek' Woźniak wrote: > > Hi there, > > > > I am writing a plasmoid that is supposed to have drag and drop support > > - but am unable to test it efficiently with plasmoidviewer, as I have > > no

Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-25 Thread Aaron J. Seigo
> On Oct. 19, 2012, 3:09 p.m., Greg T wrote: > > looks good, just a couple of notes: > > why are you installing 2 desktop files for the kickoff launcher: > > - metadata.desktop and the old plasma-applet-launcher.desktop > > - we don't need CMakeLists.txt in core/ anymore? > > - also it conflicts

Re: Review Request: Fix ReferenceErrors in ListItem

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20842 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 18, 2012, 2:39 a

Re: Review Request: Fix screenChanged signal in javascript appletinterface

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106936/#review20841 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 18, 2012, 1 a.m.

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106244/#review20838 --- just some whitespace and code style issues to address; the patc

Re: Testing several plasmoid instances at the same time

2012-10-25 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 22:25:12 Michał 'rysiek' Woźniak wrote: > Hi there, > > I am writing a plasmoid that is supposed to have drag and drop support > - but am unable to test it efficiently with plasmoidviewer, as I have > not found a way to display several instances of the same plasmoi