Re: QML style guide

2012-11-07 Thread Dmitry A. Ashkadov
Hello, Aaron! 1. If usage of item consist of only one property that is set, then may it be placed on one line? Example: ScriptAction { script: targetItem.smooth = false } PlasmaCore.SvgItem { ... // blablabla svg: PlasmaCore.Svg { imagePath: path } ... // blablabla } 2. Maybe is it better

Re: QML style guide

2012-11-07 Thread Aaron J. Seigo
On Wednesday, November 7, 2012 11:26:10 Dmitry A. Ashkadov wrote: Hello, Aaron! 1. If usage of item consist of only one property that is set, then may it be placed on one line? Example: ScriptAction { script: targetItem.smooth = false } PlasmaCore.SvgItem { ... // blablabla svg:

Re: Review Request: ToolBox bindings for declarative containments

2012-11-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107232/#review21536 --- to me is starting to look good, just a copuple of remaining

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-07 Thread Luis Gabriel Lima
On Nov. 7, 2012, 12:33 a.m., Aleix Pol Gonzalez wrote: I'm unsure what's the reasoning behind, but isn't that exactly the opposite direction we want to go with KF5? +1 - Luis Gabriel --- This is an automatically generated e-mail.

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-07 Thread Aaron J. Seigo
On Nov. 7, 2012, 12:33 a.m., Aleix Pol Gonzalez wrote: I'm unsure what's the reasoning behind, but isn't that exactly the opposite direction we want to go with KF5? Luis Gabriel Lima wrote: +1 we don't have KF5 yet, however, and feedback from kdereview was to use KDialog. if we

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Aaron J. Seigo
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization and

Review Request: SystemTray: Removing IconWidget for an arrow

2012-11-07 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107239/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description

Re: Review Request: SystemTray: Removing IconWidget for an arrow

2012-11-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107239/#review21547 --- Ship it! Ship It! - Marco Martin On Nov. 7, 2012, 12:11

kwin scripted effects - easing curves?

2012-11-07 Thread Aaron J. Seigo
hi.. this one is mostly for Martin G, i suppose: in the kwin scripting API for effects, the animate function can take a QEasingCurve .. however i do not see how to create one from the javascript. is this simply functionality that is currently missing, or? -- Aaron J. Seigo signature.asc

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization and

SocialFeed in 4.10?

2012-11-07 Thread Martin Klapetek
Hey all, here's the current status of the SocialFeed project: * parts needed in kdepimlibs are in place * facebook resource is in review for kdepim-runtime * libkfacebook^W libkfbapi is in kdereview to be included in extragear/libs * the plasmoid is in a branch * the qml plugin still lives

Re: SocialFeed in 4.10?

2012-11-07 Thread Marco Martin
On Wed, Nov 7, 2012 at 2:59 PM, Martin Klapetek martin.klape...@gmail.comwrote: (as it seems I'm the only one testing it) and given tomorrow's hard feature freeze and my limited time to work on this, I'm unsure if I should push for including this in 4.10. I'd rather prefer putting the

Re: Review Request: ToolBox bindings for declarative containments

2012-11-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107232/ --- (Updated Nov. 7, 2012, 2:40 p.m.) Review request for Plasma. Changes

Re: Review Request: ToolBox bindings for declarative containments

2012-11-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107232/#review21556 --- Ship it! to me is good to go, if someone has something to

Re: Re: SocialFeed in 4.10?

2012-11-07 Thread Alex Fiestas
On Wednesday 07 November 2012 15:05:43 Marco Martin wrote: On Wed, Nov 7, 2012 at 2:59 PM, Martin Klapetek martin.klape...@gmail.comwrote: (as it seems I'm the only one testing it) and given tomorrow's hard feature freeze and my limited time to work on this, I'm unsure if I should

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/ --- (Updated Nov. 7, 2012, 3:20 p.m.) Review request for Plasma, Aaron J.

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization and

Re: Review Request: ToolBox bindings for declarative containments

2012-11-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107232/#review21564 --- This review has been submitted with commit

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Aaron J. Seigo
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization and

Re: kwin scripted effects - easing curves?

2012-11-07 Thread Martin Gräßlin
On Wednesday 07 November 2012 13:23:34 Aaron J. Seigo wrote: hi.. this one is mostly for Martin G, i suppose: would help to CC me or k...@kde.org if my plasma inbox is showing 37 unread mails ;-) in the kwin scripting API for effects, the animate function can take a QEasingCurve ..

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-07 Thread Martin Gräßlin
On Nov. 7, 2012, 12:33 a.m., Aleix Pol Gonzalez wrote: I'm unsure what's the reasoning behind, but isn't that exactly the opposite direction we want to go with KF5? Luis Gabriel Lima wrote: +1 Aaron J. Seigo wrote: we don't have KF5 yet, however, and feedback from kdereview

Re: Re: Re: SocialFeed in 4.10?

2012-11-07 Thread Martin Gräßlin
On Wednesday 07 November 2012 16:03:24 Alex Fiestas wrote: On Wednesday 07 November 2012 15:05:43 Marco Martin wrote: On Wed, Nov 7, 2012 at 2:59 PM, Martin Klapetek martin.klape...@gmail.comwrote: (as it seems I'm the only one testing it) and given tomorrow's hard feature

Review Request: libs/mediacenter/CMakeLists.txt: find Taglib properly

2012-11-07 Thread Sebastian Gottfried
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107247/ --- Review request for Plasma. Description --- Without it my system

Re: Review Request: libs/mediacenter/CMakeLists.txt: find Taglib properly

2012-11-07 Thread Sebastian Gottfried
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107247/ --- (Updated Nov. 7, 2012, 4:53 p.m.) Review request for Plasma.

Re: SocialFeed in 4.10?

2012-11-07 Thread Artur Souza
On 07/11/2012 11:05, Marco Martin wrote: i think the most reasonable way would be aiming to do an independent release that can work on top of 4.10, and then aiming for 4.11 +1 Cheers! Artur ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: SocialFeed in 4.10?

2012-11-07 Thread Daker Fernandes Pinheiro
+1 Br, Daker Fernandes Pinheiro http://codecereal.blogspot.com 2012/11/7 Artur Souza ar...@morpheuz.cc On 07/11/2012 11:05, Marco Martin wrote: i think the most reasonable way would be aiming to do an independent release that can work on top of 4.10, and then aiming for 4.11 +1

Re: [Kde-pim] SocialFeed in 4.10?

2012-11-07 Thread Kevin Krammer
On Wednesday, 2012-11-07, Martin Klapetek wrote: Hey all, here's the current status of the SocialFeed project: * parts needed in kdepimlibs are in place * facebook resource is in review for kdepim-runtime * libkfacebook^W libkfbapi is in kdereview to be included in extragear/libs * the

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization and

Re: Review Request: libs/mediacenter/CMakeLists.txt: find Taglib properly

2012-11-07 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107247/#review21577 --- Ship it! Ship It! - Shantanu Tushar On Nov. 7, 2012, 4:53

Re: Re: Re: SocialFeed in 4.10?

2012-11-07 Thread Martin Klapetek
On Wed, Nov 7, 2012 at 6:10 PM, Martin Gräßlin mgraess...@kde.org wrote: On Wednesday 07 November 2012 16:03:24 Alex Fiestas wrote: On Wednesday 07 November 2012 15:05:43 Marco Martin wrote: i think the most reasonable way would be aiming to do an independent release that can work on

Re: Review Request: ToolBox bindings for declarative containments

2012-11-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107232/#review21588 --- This review has been submitted with commit

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-07 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/ --- (Updated Nov. 7, 2012, 9:31 p.m.) Review request for Plasma. Changes

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21594 --- Ship it! Three niggles, otherwise good to go. Please fix