Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108400/ --- (Updated Jan. 14, 2013, 9:08 a.m.) Review request for kwin and Plasma.

Re: Re: reflecting on 4.10

2013-01-14 Thread Martin Gräßlin
On Saturday 12 January 2013 17:56:14 Kevin Ottens wrote: [*] Historical note no one will probably care about actually, i care :) i rather suspected this was the case, given the number of developers i've heard this same kind of story from. the reason for moving to packages varies, but

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Martin Gräßlin
of course I have forgotten to mention one suggestion. In KWin we added a totally awesome feature to get introspection on the running instance. If you have not seen it yet, just try: qdbus org.kde.kwin /KWin supportInformation This significantly improved the time we spent on bug reports. Instead

Re: Re: Re: reflecting on 4.10

2013-01-14 Thread Alex Fiestas
On Monday 14 January 2013 11:16:43 Martin Gräßlin wrote: On Saturday 12 January 2013 17:56:14 Kevin Ottens wrote: [*] Historical note no one will probably care about actually, i care :) i rather suspected this was the case, given the number of developers i've heard this same kind

Re: XDpms in screenlocker

2013-01-14 Thread Dario Freddi
Hi everyone, 2013/1/14 Oliver Henshaw oliver.hens...@gmail.com On 13 January 2013 22:57, Thomas Lübking thomas.luebk...@gmail.com wrote: ** please keep me in cc as well as likely dario ** I looked into the powerdevil sources, reactivated the turnOffScreen dbus method, implemented it

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Alex Merry
On 14/01/13 10:22, Martin Gräßlin wrote: I think this would also be interesting for Plasma: * which Plasmoids are running * which containments are present * what are the settings of each Plasmoid Note that there are potential privacy issues here. Unlike KWin, there is a fair chance that

Re: Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Martin Gräßlin
On Monday 14 January 2013 11:42:10 Alex Merry wrote: On 14/01/13 10:22, Martin Gräßlin wrote: I think this would also be interesting for Plasma: * which Plasmoids are running * which containments are present * what are the settings of each Plasmoid Note that there are potential privacy

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Alex Fiestas
Not going to quote... Long emails are long :p I pretty much agree and will feel comfortable working with this process, besides the bug for feature part, we have been doing the same in solid, for example in kscreen right now we have: 6 bugs as NeedInfo, waiting 3 wishes in Unconfirmed Similar

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Sebastian Kügler
On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability in

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Martin Gräßlin
On Jan. 14, 2013, 8:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability in

Re: krunner qml

2013-01-14 Thread Aleix Pol
On Fri, Jan 11, 2013 at 3:49 PM, Aaron J. Seigo ase...@kde.org wrote: On Friday, January 11, 2013 13:16:03 Aleix Pol wrote: Why do we need a place to put it? because people were generally unaware the System Activity window even existed because there was no visible ui to show it. this was

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Thomas Lübking
On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability in

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Martin Gräßlin
On Jan. 14, 2013, 8:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability in

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Alex Fiestas
On Sunday 13 January 2013 15:50:25 Martin Gräßlin wrote: *Every commit should be referenced to a bug* What is the motivation for a commit? It's either a bug fix or it is a new feature/improvement. If it's a bug it's clear that there has to be a bug report for it (out of experience: there is

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Aaron J. Seigo
On Sunday, January 13, 2013 15:50:25 Martin Gräßlin wrote: I think the problem with our QM process is, that we don't have a tool to support it. Our bugtracker is (in it's current state) totally useless. Let me just show a few stats for Plasma: the difference betwen Plasma and KWin components

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Aaron J. Seigo
On Sunday, January 13, 2013 21:16:16 Paulo Nogueira wrote: I'm writing a very basic plasma widget using PyQt and QWebKit, where I'm trying to set a custom size for my widget bellow of 128px. could be due to this in the implementation of Plasma::WebView: QSizeF WebView::sizeHint(Qt::SizeHint

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Luca Beltrame
In data lunedì 14 gennaio 2013 16:30:15, Aaron J. Seigo ha scritto: the real fix, however, is not to do the UI in python. use QML. Speaking of that, how does Plasma (or the workspace in general) fit when using QML, according to these 3 definitions (taken from the PyQt docs): 1. Pure

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Alex Merry
On 14/01/13 15:21, Alex Fiestas wrote: On Sunday 13 January 2013 15:50:25 Martin Gräßlin wrote: *Every commit should be referenced to a bug* What is the motivation for a commit? It's either a bug fix or it is a new feature/improvement. If it's a bug it's clear that there has to be a bug report

4.10 reflection summary

2013-01-14 Thread Aaron J. Seigo
hi... i hope i capture all the feedback below, if i missed something, please say so in a reply to this email :) Question: how do you think 4.10 went? Answers: Consensus seems to be that some good things were done, but few, if any of us, were truly satisfied with the 4.10 cycle. Commentary:

Re: Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Martin Gräßlin
On Monday 14 January 2013 16:21:04 Alex Fiestas wrote: On Sunday 13 January 2013 15:50:25 Martin Gräßlin wrote: *Every commit should be referenced to a bug* What is the motivation for a commit? It's either a bug fix or it is a new feature/improvement. If it's a bug it's clear that there has

Re: Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Martin Gräßlin
On Monday 14 January 2013 16:24:28 Aaron J. Seigo wrote: Whoever is maintainer of a component, should become the default assignee for bugs in that component. No longer a one address for all assignee. i think the maintainer should be added as a default CC, but if each component goes to a

Re: Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Martin Gräßlin
On Monday 14 January 2013 16:24:28 Aaron J. Seigo wrote: *Every commit should be referenced to a bug* What is the motivation for a commit? It's either a bug fix or it is a new feature/improvement. If it's a bug it's clear that there has to be a bug report for it (out of experience: there

Re: reflecting on 4.10

2013-01-14 Thread Aaron J. Seigo
ok, so finally my answers ... i deliberately waited until the discussion was done give my own answers as it's really hard to facilitate a discussion and participate at the same time. (well, i did poke my thoughts into the thread a few times .. :) On Thursday, January 10, 2013 22:05:28 Aaron J.

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Aaron J. Seigo
On Monday, January 14, 2013 16:33:48 Luca Beltrame wrote: In data lunedì 14 gennaio 2013 16:30:15, Aaron J. Seigo ha scritto: the real fix, however, is not to do the UI in python. use QML. Speaking of that, how does Plasma (or the workspace in general) fit when using QML, according to these

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Luca Beltrame
In data lunedì 14 gennaio 2013 17:39:12, Aaron J. Seigo ha scritto: (apologies if this comes doubled, wrong address in the From field) [Plasma Python bindings] do we need python bindings? The bindings are there because libplasma is in kdelibs, and as such they are provided by PyKDE4 (which

repositories beyond kde-workspace

2013-01-14 Thread Aaron J. Seigo
hi.. as Alex noted in an email in the reflecting on 4.10 thread, we have several current and upcoming git repos that are topically part of the workspaces. such repositories include: * bluedevil * networkmanagement * kscreen (it's dependency, libkscreen, is probably a Frameworks topic, not

Review Request 108414: watch for screen addition/removal and resize

2013-01-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108414/ --- Review request for Plasma. Description --- it's quite rare that a

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Alex Merry
On 14/01/13 15:24, Aaron J. Seigo wrote: * it means adopting bugzilla as our One True Workflow tool. that doesn't just sound beaurocratic, it is beaurocratic. if someone appears with a patch fixing some bug or implementing some feature that isn't in bugzilla, do we first send them to create one

Re: Review Request 108414: watch for screen addition/removal and resize

2013-01-14 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108414/#review25510 --- I guess you want to check

Re: Review Request 108414: watch for screen addition/removal and resize

2013-01-14 Thread Marco Martin
On Jan. 14, 2013, 6:34 p.m., Xuetian Weng wrote: I guess you want to check https://git.reviewboard.kde.org/r/108375/ , that patch seems already cover this. indeed, that patch covers it. i would prefer that one to this. - Marco

KActivities::Info::linkedResources

2013-01-14 Thread Ivan Čukić
Hi all, KActivities::Info::linkedResources() is an evil method that needs to go away - it retrieves a list of linked resources synchronously. Currently, it is used only in Share-Like-Connect, in a funny way - to check whether a specific resource is linked to the activity like this:

Re: Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread Ben Cooksley
On Tue, Jan 15, 2013 at 5:11 AM, Martin Gräßlin mgraess...@kde.org wrote: On Monday 14 January 2013 16:24:28 Aaron J. Seigo wrote: Whoever is maintainer of a component, should become the default assignee for bugs in that component. No longer a one address for all assignee. i think the

Re: KActivities::Info::linkedResources

2013-01-14 Thread Marco Martin
On Monday 14 January 2013, Ivan Čukić wrote: Hi all, KActivities::Info::linkedResources() is an evil method that needs to go away - it retrieves a list of linked resources synchronously. Currently, it is used only in Share-Like-Connect, in a funny way - to check whether a specific resource

Re: Review Request 108377: fix rest von 313020

2013-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108377/#review25515 --- This review has been submitted with commit

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108375/#review25514 --- This review has been submitted with commit

Re: Review Request 108318: Port screenlocker greeter app away from Kephal

2013-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108318/#review25516 --- This review has been submitted with commit

Re: Review Request 108377: fix rest von 313020

2013-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108377/#review25518 --- This review has been submitted with commit

Re: Review Request 108375: fix bug 311116 / screenlocker hiding

2013-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108375/#review25517 --- This review has been submitted with commit

Re: repositories beyond kde-workspace

2013-01-14 Thread Marco Martin
On Monday 14 January 2013, Aaron J. Seigo wrote: hi.. as Alex noted in an email in the reflecting on 4.10 thread, we have several current and upcoming git repos that are topically part of the workspaces. such repositories include: * bluedevil * networkmanagement * kscreen (it's

Re: KActivities::Info::linkedResources

2013-01-14 Thread Ivan Čukić
the method is indeed evil, not sure about breaking the released api tough That is why I'm asking - we have two evils - bad method vs semantic api change i think it should stay just a deprecated, or at most be a noop (modulo some kWarning) I'd like to go for a noop. now a thing i wonder,

Re: KActivities::Info::linkedResources

2013-01-14 Thread Marco Martin
On Monday 14 January 2013, Ivan Čukić wrote: could be isResourceLinked() factored in a change so small that can be backported? The service in 4.10 already has this method (it would need to be implemented in a better way than it is), but the library doesn't expose it. Can we change the API

Please unbreak kdeplasma-addons

2013-01-14 Thread Albert Astals Cid
Note: I'm not subscribed to plasma-devel, keep me in CC Hi Weng, it seems you broke the build of kdeplasma-addons with http://build.kde.org/view/FAILED/job/kdeplasma-addons_stable/101/changes Error at http://build.kde.org/view/FAILED/job/kdeplasma-addons_stable/101/console Can you please

Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108417/ --- Review request for Plasma and Dario Freddi. Description --- Requires

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108417/#review25531 --- ksmserver/screenlocker/greeter/greeterapp.cpp

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Thomas Lübking
On Jan. 14, 2013, 9:52 p.m., Dario Freddi wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, lines 272-275 http://git.reviewboard.kde.org/r/108417/diff/1/?file=107301#file107301line272 Just in case: should we check for the existence of the interface? I can picture a case where

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108417/#review25537 --- Ship it! Ship It! - Dario Freddi On Jan. 14, 2013, 9:12

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Thomas Lübking
On Jan. 14, 2013, 9:52 p.m., Dario Freddi wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, lines 272-275 http://git.reviewboard.kde.org/r/108417/diff/1/?file=107301#file107301line272 Just in case: should we check for the existence of the interface? I can picture a case where

Re: Review Request 108417: screenlocker make [escape] conditionally turn off the screen

2013-01-14 Thread Dario Freddi
On Jan. 14, 2013, 9:52 p.m., Dario Freddi wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, lines 272-275 http://git.reviewboard.kde.org/r/108417/diff/1/?file=107301#file107301line272 Just in case: should we check for the existence of the interface? I can picture a case where

Re: Thoughts about a better Quality Management process for Plasma

2013-01-14 Thread David Edmundson
On Mon, Jan 14, 2013 at 3:24 PM, Aaron J. Seigo ase...@kde.org wrote: On Sunday, January 13, 2013 15:50:25 Martin Gräßlin wrote: I think the problem with our QM process is, that we don't have a tool to support it. Our bugtracker is (in it's current state) totally useless. Let me just show a

Re: KActivities::Info::linkedResources

2013-01-14 Thread Ivan Čukić
if is an addition rather than changing something already there i think so, because in this case if the old method is nooped now, it would avoid potential new users for it (and potential performance drains) that could happen during 4.10. Monday, December 17, 2012: KDE SC 4.10 Hard API Freeze

Re: Review Request 108400: Improve highlighted contrast in thumbnail tabbox

2013-01-14 Thread Thomas Lübking
On Jan. 14, 2013, 7:59 a.m., Thomas Lübking wrote: my 2c only: if air has an unnotable *highlight* frame this should be fixed in the theme. if it is not fixable in the theme because the focus is on a mostly light and airy appearance i would frankly raise the question of usability in

[KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-14 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 202336: https://bugs.kde.org/show_bug.cgi?id=202336 Priority: NOR Severity: normal Platform: Gentoo

Re: Having an issue with the minimum size of Plasma.WebView

2013-01-14 Thread Paulo Nogueira
Hi Guys, thanks for your's replies. Looks like even implementing the sizeHint for Plasma.WebView it does not work. So I fixed it by replacing the Plasma.WebView for the QtWebKit.QGraphicsWebView and now it works as expected. More details can be found here: http://pastebin.com/HhMwsD9R Cheers,

Re: [KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-14 Thread Martin Gräßlin
Is actually anyone looking at these lists? If no: could we get rid off it? signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel