Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108585/#review26301 --- this still does not work p[roperly. now i'm getting a (too

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Thomas Lübking
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. See above, try setting

Review Request 108640: Check for Valid Wallet Pointer

2013-01-28 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108640/ --- Review request for Plasma. Description --- Related to bug 312137.

Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

2013-01-28 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108641/ --- Review request for Plasma. Description --- I think this is all

Re: Review Request 108640: Check for Valid Wallet Pointer

2013-01-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108640/#review26304 --- Ship it! dataengines/microblog/koauth.cpp

Re: Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

2013-01-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108641/#review26305 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 28, 2013, 12:43

Re: Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

2013-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108641/#review26307 --- This review has been submitted with commit

Re: Review Request 108640: Check for Valid Wallet Pointer

2013-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108640/#review26308 --- This review has been submitted with commit

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. Thomas Lübking wrote:

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. Thomas Lübking wrote:

Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/ --- Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/ --- (Updated Jan. 28, 2013, 2:38 p.m.) Review request for kwin, Plasma,

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote: this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now. Thomas Lübking wrote:

Re: Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

2013-01-28 Thread Oliver Henshaw
On Jan. 26, 2013, 2:03 p.m., Oliver Henshaw wrote: I don't have multiple monitors to test with, but can you test with the the LockWindow set to some colour other than black? Just so that any bizarre side effects are more obvious. Thomas Lübking wrote: What bizarre side effects

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26313 --- ksmserver/screenlocker/greeter/greeterapp.cpp

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26314 --- What kinda strucks me is that the window is translucent for

New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Sebastian Kügler
Hi, The new desktop containment is coming along nicely. After the first round of feedback (thanks for that, btw, for reference, it's the thread with subject [RFC] New (QML) Desktop Containment). In this iteration, the design is much closer to the current containment. The handle has been

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Sebastian Kügler
On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote: The new containnment has a (temporary, it's really only for testing and will be removed before release) tuning screen Ow, forgot: You can get at it by clicking the tiny configure icon in the top- left corner. Make sure no applet is

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Luca Beltrame
In data lunedì 28 gennaio 2013 16:58:19, Sebastian Kügler ha scritto: A movie says more than thousand words, so please watch this: http://www.youtube.com/watch?v=GR5UZUtcOGc The video is marked as private, was that intentional? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: What kinda strucks me is that the window is translucent for the Qt::transparent. This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed out of sth. else here (eg. plasma-desktop) or do you eventually run

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, line 210 http://git.reviewboard.kde.org/r/108643/diff/1/?file=109632#file109632line210 This is pointless because the greeter view is not managed

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: What kinda strucks me is that the window is translucent for the Qt::transparent. This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed out of sth. else here (eg. plasma-desktop) or do you eventually run

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Sebastian Kügler
On Monday, January 28, 2013 17:01:29 Luca Beltrame wrote: In data lunedì 28 gennaio 2013 16:58:19, Sebastian Kügler ha scritto: A movie says more than thousand words, so please watch this: http://www.youtube.com/watch?v=GR5UZUtcOGc The video is marked as private, was that intentional? Ah,

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Aaron J. Seigo
On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote: A movie says more than thousand words, so please watch this: http://www.youtube.com/watch?v=GR5UZUtcOGc cool; when you blog about this (assuming that's at least partly what the video is for), you may want to make it ++clear that the

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Sebastian Kügler
On Monday, January 28, 2013 17:26:07 Aaron J. Seigo wrote: On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote: A movie says more than thousand words, so please watch this: http://www.youtube.com/watch?v=GR5UZUtcOGc cool; when you blog about this (assuming that's at least partly

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Oliver Henshaw
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26318 --- This going to be a patch series, isn't it? There looks like

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Marco Martin
On Monday 28 January 2013, Sebastian Kügler wrote: Hi, The new desktop containment is coming along nicely. After the first round of feedback (thanks for that, btw, for reference, it's the thread with subject [RFC] New (QML) Desktop Containment). In this iteration, the design is much

repository changes for plasma2/frameworks5

2013-01-28 Thread Marco Martin
Hi all, As you know, Plasma is composed mainly by two parts: the library, now in kdelibs and a runtime part, now in kde-runtime. the runtime part is basically: * QML imports * A scriptengine to write plasmoids in QML, dataengines in javascript etc * a kpart * default theme * some command line

Re: repository changes for plasma2/frameworks5

2013-01-28 Thread Stephen Kelly
Marco Martin wrote: Most important, what is the less messy git way to do it? As we discussed on IRC, it may be better to split plasma out into its own repo now already, like we did with nepomuk. As the frameworks branch has a 'use-by' date, I'd prefer not to import more things into it from

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Aaron J. Seigo
On Jan. 28, 2013, 4:44 p.m., Oliver Henshaw wrote: This going to be a patch series, isn't it? There looks like there's a few things lumped together in this patch (port from kephal, change from transparent to black, removal of legacy code snippet, the geometry change fix, the greeter

Re: repository changes for plasma2/frameworks5

2013-01-28 Thread Marco Martin
On Monday 28 January 2013, Stephen Kelly wrote: Marco Martin wrote: Most important, what is the less messy git way to do it? As we discussed on IRC, it may be better to split plasma out into its own repo now already, like we did with nepomuk. As the frameworks branch has a 'use-by' date,

Fwd: KDE switch desktop direction

2013-01-28 Thread Chani
-- Forwarded message -- From: Anders Aspegren Søndergaard ander...@gmail.com Date: Mon, Jan 28, 2013 at 5:06 AM Subject: KDE switch desktop direction To: ch...@kde.org Hi When in KDE search and launch activity, scrolling up switches desktop to lower numbers and down to higher

Re: Fwd: KDE switch desktop direction

2013-01-28 Thread Sebastian Kügler
Hi Chani, On Monday, January 28, 2013 10:15:54 Chani wrote: When in KDE search and launch activity, scrolling up switches desktop to lower numbers and down to higher numbers. I.e. you go from Desktop n to Desktop n + 1 when scrolling down. Can this be reversed? Please direct the user to

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
On Jan. 28, 2013, 3:27 p.m., Thomas Lübking wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, line 210 http://git.reviewboard.kde.org/r/108643/diff/1/?file=109632#file109632line210 This is pointless because the greeter view is not managed

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-28 Thread Thomas Lübking
On Jan. 28, 2013, 3:30 p.m., Thomas Lübking wrote: What kinda strucks me is that the window is translucent for the Qt::transparent. This also requires it to be 32bit, ie. ARGB - is that lockerwindow constructed out of sth. else here (eg. plasma-desktop) or do you eventually run

Re: New (QML) Desktop Containment, Take 2 (with movie!)

2013-01-28 Thread Sebastian Kügler
On Monday, January 28, 2013 17:29:36 Sebastian Kügler wrote: On Monday, January 28, 2013 17:26:07 Aaron J. Seigo wrote: On Monday, January 28, 2013 16:58:19 Sebastian Kügler wrote: A movie says more than thousand words, so please watch this: http://www.youtube.com/watch?v=GR5UZUtcOGc

Non-OAuth Support in Microblogging Plasmoid

2013-01-28 Thread David Narvaez
Hi, As you'll see in the logs, I've been giving some maintenance to the Microblogging plasmoid. As I was reviewing open bug reports I stumbled upon bug 304704. The users expecto be able to use the microblogging plasmoid to log into any StatusNet instance, but we are only supporting OAuth right