Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-07 Thread Martin Gräßlin
On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37284 --- tier1/kconfig/autotests/kconfigloadertest.cpp

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-07 Thread Martin Gräßlin
On Aug. 7, 2013, 5:41 p.m., David Faure wrote: tier1/kconfig/autotests/kconfigloadertest.cpp, line 56 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176357#file176357line56 I have trouble understanding the purpose of this class. How is this different from

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 8, 2013, 6:58 a.m.) Review request for KDE Frameworks,