Review Request 112499: Rework finding of XCB

2013-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112499/ --- Review request for KDE Frameworks and Plasma. Description --- Rework

Re: documentation on QMLSceneGraph internals

2013-09-03 Thread Aaron J. Seigo
On Tuesday, September 3, 2013 14:21:37 Marco Martin wrote: > On Tuesday 03 September 2013, Aaron J. Seigo wrote: > > we should start a branch in kdeexamples that removes or ports all the > > examples currently there for plasma so that when Plasma.next() is released > > we’ll be ready with lots of b

Re: Questions about models in NotificationDelegate.qml

2013-09-03 Thread Marco Martin
On Tuesday 27 August 2013, Christoph Feck wrote: > Hi, > > Looking at the NotificationDelegate.qml file, I see several lines that > say "notificationsModel.remove(index)", fired from timers, running > animations etc. > > Do QML models automatically make sure the index is still valid, in > other w

Re: Questions about models in NotificationDelegate.qml

2013-09-03 Thread Christoph Feck
On Tuesday 27 August 2013 13:57:00 Christoph Feck wrote: > Hi, > > Looking at the NotificationDelegate.qml file, I see several lines > that say "notificationsModel.remove(index)", fired from timers, > running animations etc. > > Do QML models automatically make sure the index is still valid, in >

Re: Review Request 112484: make hotplug engine work

2013-09-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/#review39274 --- This review has been submitted with commit 9c1f11a64a3fd477a1f

Re: Review Request 112484: make hotplug engine work

2013-09-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/ --- (Updated Sept. 3, 2013, 3:17 p.m.) Status -- This change has been mar

Re: Review Request 112484: make hotplug engine work

2013-09-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/ --- (Updated Sept. 3, 2013, 3:07 p.m.) Review request for Plasma and Sebastian

Re: Review Request 112484: make hotplug engine work

2013-09-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/#review39265 --- plasma/generic/dataengines/hotplug/hotplugengine.cpp

Re: Review Request 112484: make hotplug engine work

2013-09-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/ --- (Updated Sept. 3, 2013, 2:30 p.m.) Review request for Plasma and Sebastian

Review Request 112484: make hotplug engine work

2013-09-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/ --- Review request for Plasma and Sebastian Kügler. Description --- summa

Re: Review Request 112088: active-about: add new Contributors for PA 4

2013-09-03 Thread Michael Bohlender
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112088/ --- (Updated Sept. 3, 2013, 1:18 p.m.) Status -- This change has been mar

Re: documentation on QMLSceneGraph internals

2013-09-03 Thread Marco Martin
On Tuesday 03 September 2013, Aaron J. Seigo wrote: > we should start a branch in kdeexamples that removes or ports all the > examples currently there for plasma so that when Plasma.next() is released > we’ll be ready with lots of beautiful examples demonstrating best > practices for people to use

Re: documentation on QMLSceneGraph internals

2013-09-03 Thread Marco Martin
On Tuesday 03 September 2013, Aaron J. Seigo wrote: > On Tuesday, September 3, 2013 13:36:54 Marco Martin wrote: > > the downside is that isn't exactly intuitive how is written: has quite > > some boilerplate and easy to get wrong... > > sounds like a perfect candidate for being put into kdeexampl

Re: documentation on QMLSceneGraph internals

2013-09-03 Thread Aaron J. Seigo
On Tuesday, September 3, 2013 13:36:54 Marco Martin wrote: > the downside is that isn't exactly intuitive how is written: has quite some > boilerplate and easy to get wrong... sounds like a perfect candidate for being put into kdeexamples for other people to copy and paste. we should start a bra

Re: documentation on QMLSceneGraph internals

2013-09-03 Thread Marco Martin
On Tuesday 03 September 2013, Marco Martin wrote: > that is also another of the many advantages of using standardized > components and sticking with it: for instance we have clip enabled only on > PlasmaExtras.ScrollArea and that's it (and plasmoids should normally never > have to touch that, we ha

Re: Review Request 104258: Save scrollbar position on plasma exit

2013-09-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated Sept. 3, 2013, 11:05 a.m.) Status -- This change has been di

Re: Review Request 108453: add an orientation engine and applet to plasma-mobile for screen and touch screen rotation.

2013-09-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108453/ --- (Updated Sept. 3, 2013, 11:05 a.m.) Status -- This change has been ma

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-09-03 Thread David Faure
> On Aug. 9, 2013, 7:27 p.m., David Faure wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 99 > > > > > > I wonder if this should really derive from KConfigSkeleton, rather than > > encapsulate it. > >

Re: documentation on QMLSceneGraph internals

2013-09-03 Thread Marco Martin
On Tuesday 03 September 2013, Aaron J. Seigo wrote: > hi all... > > you may have already seen this on qt blogs, but if not i highly recommend > reading: > > http://doc-snapshot.qt-project.org/qt5-dev/qtquick/qtquick-visualcanvas-sce > negraph-renderer.html > > the section on performance is going

Re: Re: naming the next major release

2013-09-03 Thread Martin Gräßlin
On Friday 30 August 2013 19:44:40 Aaron J. Seigo wrote: > If we say that “KDE Plasma” makes “Plasma” too much “KDE”, then we are > creating a real problem for ourselves: nothing can use “KDE” in conjunction > with its project name since that too would suggest exclusivity. There's another thing into