Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/#review45662 --- Ship it! Ship It! - Shantanu Tushar On Dec. 13, 2013, 3:05

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Shantanu Tushar
> On Dec. 13, 2013, 3:49 p.m., Aaron J. Seigo wrote: > > magical :) > > > > not for me to mark as "ship it", though; that's up to PMC people. > > > > one side note, though not related to this patch: the text on the main > > screen kind of SHOUTS at you with the large font size and multiple row

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45659 --- magical :) not for me to mark as "ship it", though; that's up

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, line 42 > > > > > > The PMC time doesn't get synced with desktop time. Can you tune this > > further to g

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/ --- (Updated Dec. 13, 2013, 3:05 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, line 42 > > > > > > The PMC time doesn't get synced with desktop time. Can you tune this > > further to g

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 3:01 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 2:59 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 2:57 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45648 --- Still needs some finishing touches. Also, whenever you submit p

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, line 42 > > > > > > The PMC time doesn't get synced with desktop time. Can you tune this > > further to g

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: > > Synced with desktop time now :-) - Heena --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/#review45627 ---

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, line 42 > > > > > > The PMC time doesn't get synced with desktop time. Can you tune this > > further to g

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/ --- (Updated Dec. 13, 2013, 2:20 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/ --- (Updated Dec. 13, 2013, 2:20 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 2:18 p.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Heena Mahour
> On Dec. 13, 2013, 12:54 p.m., Aaron J. Seigo wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, lines 39-41 > > > > > > this is incorrect; if you are using a DataEngine with an interval, then > > you le

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 2:11 p.m.) Review request for Plasma, Shantanu Tus

Re: activities and scripting

2013-12-13 Thread Nowardev-Team
neat. 2013/12/12 Aaron J. Seigo : > On Monday, December 9, 2013 14:09:40 Nowardev-Team wrote: >> and when you get the whole desktop filled by the png file you get a >> wrong resolution > > in a series of commits today, all the issues noted are resolve in the KDE/4.11 > branch of kde-workspace. > >

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45637 --- mediaelements/mediawelcome/CategoriesListDelegate.qml

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
> On Dec. 13, 2013, 2:40 a.m., Martin Gräßlin wrote: > > This looks like the wrong approach to me. The shadow gets installed by the > > widget style, but lancelot does not use a normal Qt style, but a Plasma > > style. Because of that it would need to use the plasma shadow (e.g. "panel > > sha

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
- Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote: > >

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- (Updated Dec. 13, 2013, 7:53 a.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request 114429: use of time data engine -> less code

2013-12-13 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45636 --- mediaelements/mediawelcome/HomeScreenFooter.qml

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, line 42 > > > > > > The PMC time doesn't get synced with desktop time. Can you tune this > > further to g