---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115871/#review50196
---
Ship it!
Looks ok to me
- Ivan Čukić
On Feb. 18, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115695/#review50197
---
src/knotification.cpp
On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote:
src/knotification.cpp, line 333
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243840#file243840line333
remove qDebugs?
As the description says - and for now it's full of QDebugs, that will all be
removed - so I'll
On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote:
src/knotificationmanager.cpp, line 66
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line66
This will be done in the future? Maybe it would be better to commit
when there are no regressions?
Yes it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115870/
---
(Updated Feb. 19, 2014, 11:11 a.m.)
Review request for Plasma and Sinny
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115871/#review50208
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115871/
---
(Updated Feb. 19, 2014, 11:12 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115870/#review50210
---
mediaelements/mediawelcome/HomeScreenFooter.qml
On Feb. 19, 2014, 6:35 a.m., Martin Gräßlin wrote:
kwin/effects/slide/slide.cpp, lines 241-245
https://git.reviewboard.kde.org/r/115859/diff/7/?file=244900#file244900line241
suggestion: loop over m_backgroundContrastForcedBefore - you are only
operating on them and the set should
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/
---
(Updated Feb. 19, 2014, 12:06 p.m.)
Review request for kwin and Plasma.
On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote:
kwin/effects/slide/slide.cpp, line 72
https://git.reviewboard.kde.org/r/115859/diff/3/?file=244774#file244774line72
what about setting and removing this with setting the slide flag and
catch windowAdded() while slide is true for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115857/
---
(Updated Feb. 19, 2014, 12:34 p.m.)
Status
--
This change has been
On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote:
src/knotificationmanager.cpp, line 180
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180
?
Martin Klapetek wrote:
Yet once again the description xD - it's full of ... FIXMEs to indicate
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/
---
(Updated Feb. 19, 2014, 12:52 p.m.)
Review request for kwin and Plasma.
On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote:
src/knotificationmanager.cpp, line 180
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180
?
Martin Klapetek wrote:
Yet once again the description xD - it's full of ... FIXMEs to indicate
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/#review50221
---
Ship it!
Thanks for going through this hard review
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115857/
---
(Updated Feb. 19, 2014, 1:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115857/#review50222
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/
---
(Updated Feb. 19, 2014, 1:12 p.m.)
Status
--
This change has been
On Feb. 2, 2014, 11:42 a.m., Bhushan Shah wrote:
Please test it with plasmaengineexplorer in my testing it shows no sources.
Any progress on this?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
Hi all,
The Plasma team has settled on a release schedule for the first stable
released based on Qt5 and KF5. You can find the schedule here:
http://techbase.kde.org/Schedules/Plasma/2014.6_Release_Schedule
For those too lazy to click: We'll release .0 on 17th June, two alphas, a beta
and an
On Feb. 19, 2014, 11:36 a.m., Sebastian Kügler wrote:
Perhaps this would help:
http://qt-project.org/doc/qt-4.8/qml-qt.html#formatTime-method
It seems to be providing the features needed to display a given time however
you want it. In your case the result should probably be something like
On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler se...@kde.org wrote:
Plasma Meeting February, 17th, 2014
Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco Martin,
Martin Grässlin, Martin Klapetek, Jens Reuterberg, Antonis Tsiapaliokas,
Sebastian Kügler, Vishesh Handa,
On Wednesday 19 February 2014 18:11:12 David Edmundson wrote:
On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler se...@kde.org wrote:
Plasma Meeting February, 17th, 2014
Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco
Martin,
Martin Grässlin, Martin Klapetek, Jens
On Wed, Feb 19, 2014 at 6:47 PM, Martin Graesslin mgraess...@kde.org wrote:
On Wednesday 19 February 2014 18:11:12 David Edmundson wrote:
On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler se...@kde.org wrote:
Plasma Meeting February, 17th, 2014
Present: Alex Fiestas, David Edmundson,
On Wed, Feb 19, 2014 at 8:10 PM, Mark Gaiser mark...@gmail.com wrote:
On Wed, Feb 19, 2014 at 6:47 PM, Martin Graesslin mgraess...@kde.org wrote:
On Wednesday 19 February 2014 18:11:12 David Edmundson wrote:
On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler se...@kde.org wrote:
Plasma
On Feb. 19, 2014, 1:10 p.m., Commit Hook wrote:
This review has been submitted with commit
848dd8c25b3511d89527ff8bd7b7e9125290385e by Sebastian Kügler to branch
master.
Just for the records, the commit is https://git.reviewboard.kde.org/r/115859/ -
this review was not submitted.
-
On Wed, Feb 19, 2014 at 9:12 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
no, one needs the QImage to load the data into the QSGTexture (you don't want
to use the FBO for that). Of course it should be fine to create the QImage on
the stack and discard it once it's loaded into the
On Wednesday 19 February 2014 22:24:41 David Edmundson wrote:
My benchmarking showed a massive saving, because everything was shared
from the precache-cache (ThemePrivate::pixmapsToCache) but the real
plasma-desktop only had a saving of 7Mb (still a step in the right
direction, but not very
On Wednesday 19 February 2014, David Edmundson wrote:
On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler se...@kde.org wrote:
Plasma Meeting February, 17th, 2014
Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco Martin,
Martin Grässlin, Martin Klapetek, Jens Reuterberg,
On Feb. 19, 2014, 7:06 a.m., Aleix Pol Gonzalez wrote:
src/notifybypopupgrowl.h, line 37
https://git.reviewboard.kde.org/r/115695/diff/3/?file=243849#file243849line37
Is growl still the thing for MacOS X?
Martin Klapetek wrote:
I'm not sure to be honest...I've heard they
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115902/
---
Review request for kwin and Plasma.
Repository: kde-workspace
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115902/
---
(Updated Feb. 20, 2014, 1:28 a.m.)
Review request for kwin and Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115903/
---
Review request for kwin and Plasma.
Bugs: 329991
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115903/#review50299
---
moving the GrabRole seems fine to me, but it has two small
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115902/#review50300
---
kwin/effects/slidingpopups/slidingpopups.cpp
36 matches
Mail list logo
