Re: Review Request 115910: Screenedge show support for Clients

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/ --- (Updated Feb. 21, 2014, 8:21 a.m.) Review request for kwin and Plasma.

Re: Review Request 115910: Screenedge show support for Clients

> On Feb. 20, 2014, 5:59 p.m., Thomas Lübking wrote: > > kwin/screenedge.cpp, line 170 > > > > > > what happens if two clients reserve overlapping geometry? > > One will be fired, the edge hidden, the cursor

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50447 --- Way to big to properly review to be honest. That said, I agree

Re: Review Request 114260: Port mouse dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Feb. 21, 2014, 6:54 a.m.) Review request for Plasma. Changes -

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 133 > > > > > > Q_NULLPTR it's still in the latest diff - Martin ---

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 127 > > > > > > nitpick: looking at the surrounding coding style the * should be moved > > from type to name

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50424 --- src/declarativeimports/core/svgitem.cpp

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50423 --- src/declarativeimports/core/svgitem.h

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 20, 2014, 11:45 p.m.) Review request for Plasma. Reposito

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 8:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 45 > > > > > > are you sure that you can delete the texture here? Is the object being > > destroyed from the

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 127 > > > > > > nitpick: looking at the surrounding coding style the * should be moved > > from type to name

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 45 > > > > > > are you sure that you can delete the texture here? Is the object being > > destroyed from the

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 8:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 132 > > > > > > I never really understood who takes ownership over the nodes: does one > > have to delete th

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 7:54 p.m., Marco Martin wrote: > > src/declarativeimports/core/svgitem.cpp, line 138 > > > > > > is this guaranteed to be always deleted? I believe so. There's a flag on QGSNode QSGNode::Own

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50402 --- src/declarativeimports/core/svgitem.cpp

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50401 --- pretty much good to go i think src/declarativeimports/core/s

Re: Review Request 115910: Screenedge show support for Clients

> On Feb. 20, 2014, 4:59 p.m., Thomas Lübking wrote: > > kwin/screenedge.cpp, line 1032 > > > > > > i think this is "wrong". > > > > you're trying to detect the orientation of the panel, but the client

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50398 --- src/declarativeimports/core/svgitem.cpp

Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 115910: Screenedge show support for Clients

> On Feb. 20, 2014, 5:59 p.m., Thomas Lübking wrote: > > kwin/screenedge.cpp, line 1032 > > > > > > i think this is "wrong". > > > > you're trying to detect the orientation of the panel, but the client

Re: Review Request 115910: Screenedge show support for Clients

> On Feb. 20, 2014, 4:59 p.m., Thomas Lübking wrote: > > kwin/screenedge.cpp, line 1032 > > > > > > i think this is "wrong". > > > > you're trying to detect the orientation of the panel, but the client

Re: Review Request 115910: Screenedge show support for Clients

> On Feb. 20, 2014, 5:59 p.m., Thomas Lübking wrote: > > kwin/screenedge.cpp, line 170 > > > > > > what happens if two clients reserve overlapping geometry? > > One will be fired, the edge hidden, the cursor

Review Request 115922: Drop taskbar thumbnail effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115922/ --- Review request for kwin and Plasma. Repository: kde-workspace Descripti

Re: Review Request 115910: Screenedge show support for Clients

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/#review50385 --- kwin/screenedge.cpp

Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114493/ --- (Updated Feb. 20, 2014, 4:52 p.m.) Status -- This change has been ma

Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114493/#review50387 --- This review has been submitted with commit 4c305e25d7f7c6584a

Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114493/#review50384 --- Ship it! I've found a few more smallish problems. Please addr

Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114493/ --- (Updated Feb. 20, 2014, 4:19 p.m.) Review request for Plasma. Repositor

Re: Review Request 115910: Screenedge show support for Clients

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/#review50370 --- Ship it! on plasma side, a +1 ;) - Marco Martin On Feb. 20

Review Request 115910: Screenedge show support for Clients

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/ --- Review request for kwin and Plasma. Repository: kde-workspace Descripti

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/#review50368 --- This review has been submitted with commit 0d9582627e055f80c3

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/ --- (Updated Feb. 20, 2014, 1:39 p.m.) Status -- This change has been ma

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/#review50367 --- Ship it! Ship It! - Martin Gräßlin On Feb. 20, 2014, 2:33

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/ --- (Updated Feb. 20, 2014, 1:33 p.m.) Review request for kwin and Plasma.

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/#review50366 --- Ship it! Also wanted to say: shipIt after fixing the one issu

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/#review50365 --- kwin/effects/slidingpopups/slidingpopups.cpp

Re: Review Request 105319: DBus-interface for changing wallpapers

> On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote: > > Varun, it seems Aaron had some comments, can you have a look at them? > > Varun Herale wrote: > Yes, I am looking at it right now. My patch, based on yours and code from kdeplasma-addons/applets/frame/frame.cpp: https://bugs.kde.org

Re: Review Request 115903: slidingpopups claim windowClosedGrabRole earlier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/ --- (Updated Feb. 20, 2014, 1:24 p.m.) Review request for kwin and Plasma.

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/#review50363 --- kwin/effects/slidingpopups/slidingpopups.cpp

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/#review50364 --- This review has been submitted with commit a2f398292d05b44ec2

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/ --- (Updated Feb. 20, 2014, 1:11 p.m.) Status -- This change has been ma

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/#review50362 --- Ship it! Ship It! - Martin Gräßlin On Feb. 20, 2014, 2:01

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/ --- (Updated Feb. 20, 2014, 1:01 p.m.) Review request for kwin and Plasma.

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115902/ --- (Updated Feb. 20, 2014, 12:49 p.m.) Review request for kwin and Plasma.

Re: Proposal: make libplasmaquick semi-privare

On Thursday 20 February 2014 12:45:15 David Edmundson wrote: > Can I request moving SVG and FrameSVG into PlasmaQuickPrivate -1 > 1) I need to tweak the API to get rid of the paint() methods and > instead add render hints to the pixmap() method > > 2) I want to destroy most of FrameSVG :) > > 3

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

> On Feb. 20, 2014, 7:33 a.m., Martin Gräßlin wrote: > > kwin/effects/slidingpopups/slidingpopups.cpp, line 295 > > > > > > are you sure you want to remove them in the slotWindowClosed? That > > sounds like you

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

> On Feb. 20, 2014, 6:33 a.m., Martin Gräßlin wrote: > > kwin/effects/slidingpopups/slidingpopups.cpp, line 295 > > > > > > are you sure you want to remove them in the slotWindowClosed? That > > sounds like you

Re: Re: Proposal: make libplasmaquick semi-privare

On Thursday 20 February 2014 12:45:15 David Edmundson wrote: > Can I request moving SVG and FrameSVG into PlasmaQuickPrivate > > 1) I need to tweak the API to get rid of the paint() methods and > instead add render hints to the pixmap() method > > 2) I want to destroy most of FrameSVG :) this wo

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

> On Feb. 20, 2014, 7:33 a.m., Martin Gräßlin wrote: > > kwin/effects/slidingpopups/slidingpopups.cpp, line 295 > > > > > > are you sure you want to remove them in the slotWindowClosed? That > > sounds like you

Re: Review Request 115902: Force backgroundcontrast during slidingpopup animations

> On Feb. 20, 2014, 6:33 a.m., Martin Gräßlin wrote: > > kwin/effects/slidingpopups/slidingpopups.cpp, line 295 > > > > > > are you sure you want to remove them in the slotWindowClosed? That > > sounds like you

Re: Proposal: make libplasmaquick semi-privare

Can I request moving SVG and FrameSVG into PlasmaQuickPrivate 1) I need to tweak the API to get rid of the paint() methods and instead add render hints to the pixmap() method 2) I want to destroy most of FrameSVG :) 3) I want to put in an implicit sharing of QSGTextures, exposed via Plasma::SVG