KActivities/master is now KF5/Qt5

2014-02-28 Thread Ivan Čukić
Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5 development. I have updated the branch name in kf5-frameworks-build-include (I guess David had something else in mind, so I'm CC-ing him even though he is a member of every list I'm sending this to

Re: Selecting wallpaper during Activity creation

2014-02-28 Thread David Edmundson
I've not seen much of Plasma Active but that idea certainly does look sensible. It's the first thing I change when I make an activity, as it's one of the easiest ways to tell activities apart. Our current inline editing of the activity name and icon could certainly be improved; being a larger

Re: Selecting wallpaper during Activity creation

2014-02-28 Thread Marco Martin
On Friday 28 February 2014 13:22:59 David Edmundson wrote: Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. one thing is that it would pretty much require to use the

Re: Selecting wallpaper during Activity creation

2014-02-28 Thread Thomas Pfeiffer
On 28.02.2014 13:22, David Edmundson wrote: Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. Good point, though in Plasma Active, from what I've learned from watching people

Re: Selecting wallpaper during Activity creation

2014-02-28 Thread Thomas Pfeiffer
On 28.02.2014 13:31, Marco Martin wrote: On Friday 28 February 2014 13:22:59 David Edmundson wrote: Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. one thing is that it

Re: Review Request 116460: Footer clock fix

2014-02-28 Thread Bhushan Shah
Hey, On Fri, Feb 28, 2014 at 7:04 PM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi, First of all apologies for the mistakes . I've started contributing to KDE very recently and it was my first patch. I'll keep this thing in mind in future. - Thanks Regards However its easy fix.. just

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

2014-02-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review51343 --- This review has been submitted with commit

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

2014-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review51342 --- [16:00] notmart so, if you are sure nothing is leaking (ii

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

2014-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 28, 2014, 3:23 p.m.) Status -- This change has been

Re: Review Request 116460: Footer clock fix

2014-02-28 Thread R.Harish Navnit
Hi Maulik, Let me try to elaborate what's being mentioned here, just in case things weren't clear( I had to discuss the issue with sebas later on in the IRC to really get a grip of what was going here). On Fri, Feb 28, 2014 at 6:41 PM, Sebastian Kügler se...@kde.org wrote: This is an

Re: Review Request 115475: Split KRunner out of plasma-framework

2014-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115475/ --- (Updated Feb. 28, 2014, 4:46 p.m.) Status -- This change has been

Re: KActivities/master is now KF5/Qt5

2014-02-28 Thread Ben Cooksley
On Fri, Feb 28, 2014 at 9:50 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5 development. I have updated the branch name in kf5-frameworks-build-include (I guess David had something else in mind, so

Re: KActivities/master is now KF5/Qt5

2014-02-28 Thread Ivan Čukić
The metadata has now been sorted Thanks man! On 28 February 2014 21:59, Ben Cooksley bcooks...@kde.org wrote: On Fri, Feb 28, 2014 at 9:50 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5

Re: Review Request 115764: Make playlist model aware of currently playing media

2014-02-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/#review51403 --- This review has been submitted with commit

Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- Review request for Plasma. Repository: plasma-mediacenter Description

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- Your diff contains commented out changes to

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Shantanu Tushar
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:27 a.m.) Review request for Plasma. Changes